Fix TODO tags to confirm with the projects standard
parent
eafe13d5a5
commit
e20a79ac61
|
@ -304,7 +304,7 @@ class Solver
|
||||||
// if ignoreinstalledsobsoletes is not set, we're also checking
|
// if ignoreinstalledsobsoletes is not set, we're also checking
|
||||||
// obsoletes of installed packages (like newer rpm versions)
|
// obsoletes of installed packages (like newer rpm versions)
|
||||||
//
|
//
|
||||||
/** @TODO: if ($this->noInstalledObsoletes) */
|
/** TODO if ($this->noInstalledObsoletes) */
|
||||||
if (true) {
|
if (true) {
|
||||||
$noObsoletes = isset($this->noObsoletes[$package->getId()]);
|
$noObsoletes = isset($this->noObsoletes[$package->getId()]);
|
||||||
$isInstalled = (isset($this->installedMap[$package->getId()]));
|
$isInstalled = (isset($this->installedMap[$package->getId()]));
|
||||||
|
|
|
@ -67,7 +67,7 @@ class SolverTest extends TestCase
|
||||||
$this->markTestIncomplete('Reporting this failure is not implemented/working yet');
|
$this->markTestIncomplete('Reporting this failure is not implemented/working yet');
|
||||||
//$this->fail('Unsolvable conflict did not resolve in exception.');
|
//$this->fail('Unsolvable conflict did not resolve in exception.');
|
||||||
} catch (SolverProblemsException $e) {
|
} catch (SolverProblemsException $e) {
|
||||||
// @todo: assert problem properties
|
// TODO assert problem properties
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -519,7 +519,7 @@ class SolverTest extends TestCase
|
||||||
$transaction = $this->solver->solve($this->request);
|
$transaction = $this->solver->solve($this->request);
|
||||||
$this->fail('Unsolvable conflict did not resolve in exception.');
|
$this->fail('Unsolvable conflict did not resolve in exception.');
|
||||||
} catch (SolverProblemsException $e) {
|
} catch (SolverProblemsException $e) {
|
||||||
// @todo: assert problem properties
|
// TODO assert problem properties
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -540,7 +540,7 @@ class SolverTest extends TestCase
|
||||||
$transaction = $this->solver->solve($this->request);
|
$transaction = $this->solver->solve($this->request);
|
||||||
$this->fail('Unsolvable conflict did not resolve in exception.');
|
$this->fail('Unsolvable conflict did not resolve in exception.');
|
||||||
} catch (SolverProblemsException $e) {
|
} catch (SolverProblemsException $e) {
|
||||||
// @todo: assert problem properties
|
// TODO assert problem properties
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue