Made fixes after review.
parent
3f38eede8a
commit
f59ca1e2f8
|
@ -87,7 +87,7 @@ class Rule
|
||||||
}
|
}
|
||||||
|
|
||||||
for ($i = 0, $n = count($this->literals); $i < $n; $i++) {
|
for ($i = 0, $n = count($this->literals); $i < $n; $i++) {
|
||||||
if (!($this->literals[$i]->getId() === $rule->literals[$i]->getId())) {
|
if ($this->literals[$i]->getId() !== $rule->literals[$i]->getId()) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -39,8 +39,7 @@ class ResultSetIteratorTest extends \PHPUnit_Framework_TestCase
|
||||||
$ruleSetIterator = new RuleSetIterator($this->rules);
|
$ruleSetIterator = new RuleSetIterator($this->rules);
|
||||||
|
|
||||||
$result = array();
|
$result = array();
|
||||||
foreach ($ruleSetIterator as $rule)
|
foreach ($ruleSetIterator as $rule) {
|
||||||
{
|
|
||||||
$result[] = $rule;
|
$result[] = $rule;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -58,8 +57,7 @@ class ResultSetIteratorTest extends \PHPUnit_Framework_TestCase
|
||||||
$ruleSetIterator = new RuleSetIterator($this->rules);
|
$ruleSetIterator = new RuleSetIterator($this->rules);
|
||||||
|
|
||||||
$result = array();
|
$result = array();
|
||||||
foreach ($ruleSetIterator as $key => $rule)
|
foreach ($ruleSetIterator as $key => $rule) {
|
||||||
{
|
|
||||||
$result[] = $key;
|
$result[] = $key;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue