Merge pull request #7399 from theofidry/bugfix/fix-suggest-reporter
Hide suggest reason when there is not onepull/7427/merge
commit
f92e15b032
|
@ -115,10 +115,10 @@ class SuggestedPackagesReporter
|
||||||
}
|
}
|
||||||
|
|
||||||
$this->io->writeError(sprintf(
|
$this->io->writeError(sprintf(
|
||||||
'%s suggests installing %s (%s)',
|
'%s suggests installing %s%s',
|
||||||
$suggestion['source'],
|
$suggestion['source'],
|
||||||
$this->escapeOutput($suggestion['target']),
|
$this->escapeOutput($suggestion['target']),
|
||||||
$this->escapeOutput($suggestion['reason'])
|
$this->escapeOutput('' !== $suggestion['reason'] ? ' ('.$suggestion['reason'].')' : '')
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -142,6 +142,20 @@ class SuggestedPackagesReporterTest extends TestCase
|
||||||
$this->suggestedPackagesReporter->output();
|
$this->suggestedPackagesReporter->output();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @covers ::output
|
||||||
|
*/
|
||||||
|
public function testOutputWithNoSuggestedPackage()
|
||||||
|
{
|
||||||
|
$this->suggestedPackagesReporter->addPackage('a', 'b', '');
|
||||||
|
|
||||||
|
$this->io->expects($this->once())
|
||||||
|
->method('writeError')
|
||||||
|
->with('a suggests installing b');
|
||||||
|
|
||||||
|
$this->suggestedPackagesReporter->output();
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @covers ::output
|
* @covers ::output
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in New Issue