1
0
Fork 0
Commit Graph

53 Commits (11810e3c2de5a0e24e34ce235bb713151e7ca0cb)

Author SHA1 Message Date
Jordi Boggiano d3c176ec69
PHPStan Level 5 (#10070)
* Bump PHPStan to level 5

* Update seld/phar-utils to latest

* Add phpstan-setup / phpstan scripts
2021-08-21 17:41:52 +02:00
jrfnl 7004e0d031 PHP 8.1/LibraryInstallerTest: add missing mock expectation
The `LibraryInstallerTest::testUninstall()` method mocks a `Package` object, but did not set an expectation for a call to `getName()`, while that method _is_ called in the `LibraryInstaller::uninstall()` method.

Without expectation, the mock returns `null`, which was subsequently being passed on to `strpos()` leading to the below error.

Fixes:
```
Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall:
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202)
1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...')
2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL)
3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure))
4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076))
...
```
2021-08-12 03:38:56 +02:00
Jordi Boggiano d942c65e0c
Fix more warnings 2020-09-11 11:32:09 +02:00
Jordi Boggiano 45ecbae8f5
Merge branch 'master' into 2.0 2020-02-07 22:20:51 +01:00
Ion Bazan db32d6bc18 do not use env 2020-02-07 13:07:01 +08:00
Jordi Boggiano 3dfcae99a9 Add parallel download capability to FileDownloader and derivatives 2019-01-18 08:39:03 +01:00
Gabriel Caruso 2a13bb2649 Fixes from PHPStan (#7687)
* fix docblocks

* remove redundant conditional

* fix wrong variable name

* fix wrong namespaces

* add missing private members

* remove unused/redundant arguments

* move testcase class

* exclude TestCase.php

* Tweak RuleWatchGraph type hints

* Tweak doc comment
2018-11-12 15:23:32 +01:00
Jordi Boggiano 066351c5b9 Remove use of deprecated getMock method 2018-04-12 10:24:56 +02:00
Jordi Boggiano 122e422682 CS fixes 2017-03-08 15:16:44 +01:00
Jordi Boggiano 59596ff012 Make sure we do not overwrite binaries but only re-create missing ones, refs #5127 2016-07-02 16:35:09 +01:00
Jeremy Benoist e9fc0e6548 Re-install binaries on update/install
Binaries are re-installed after an update/install (ie: removed and then installed)
2016-03-28 23:15:13 +02:00
Helmut Hummel b1ec99faed Extract binary installation and removal to own class
The functionality to install binaries might be useful
for other installers.
Create API for that by extracting this functionality from
the LibraryInstaller class.
2016-03-23 21:39:58 +01:00
Rob Bast a8995b2572 use dirsep so phpunit on windows doesnt fail 2016-01-26 11:23:08 +01:00
Rob Bast adf3b956d0 try to use unique test directories
any tests that use the filesystem should have their own unique directory, as we run our test suite in parallel and
cleanup of tests (removing directories) should not interfere with currently running tests
2016-01-26 09:41:21 +01:00
Jordi Boggiano 8398c9f2ab Fix target-dir update checks, fixes #2395 2013-11-04 13:36:30 +01:00
Jordi Boggiano 807600b255 Fix edge case where one adds a target-dir on a package that didnt have one before, refs #2279 2013-09-25 21:11:18 +02:00
Jordi Boggiano a813867065 Merge remote-tracking branch 'chx/913' 2013-09-25 20:58:13 +02:00
Jordi Boggiano 38917c2047 Add parallel build to travis script 2013-09-25 10:23:48 +02:00
Karoly Negyesi e32e4ad490 change the test to test for a target dir change 2013-09-22 19:42:05 +02:00
Karoly Negyesi 24c9ef72d6 make LibraryInstallerTest a little more strict 2013-09-20 06:04:15 +02:00
Karoly Negyesi c6ec739766 allow injecting a mock filesystem into LibraryInstaller and fix LibraryInstallerTest 2013-09-20 06:02:36 +02:00
Martin Hasoň b1c4eed57f Throw exception if the local repository does not contain a package to uninstall 2013-08-07 10:50:12 +02:00
Filippo Tessarotto 470adc47df Switched rand() to mt_rand() 2013-01-30 10:44:07 +01:00
Jordi Boggiano d6de4a0036 Rename Package interfaces to reduce BC issues 2012-08-24 02:29:31 +02:00
Jordi Boggiano a2171e2ed1 Expose LibraryInstallerTest properties to child classes 2012-08-16 11:22:30 +02:00
Alexey Prilipko ac3cebc633 Update PEAR Package Extractor to use 'task:replace', 'phprelease' commands and install role='script' files
Add PearInstaller
Change PEAR packages type from 'library' to 'pear-library' and dist type from 'pear' to 'file'
Remove PearDownloader
Refactor Channel Installer
2012-07-03 19:18:58 +11:00
Jordi Boggiano a4c829749e Expose the whole composer context to the custom installers, fixes #672 2012-06-24 20:11:17 +02:00
Grégoire Pineau f4e9dd4fb8 Fixed PSR rules 2012-06-14 12:10:01 +02:00
Jordi Boggiano ef300ca56a Fix tests 2012-04-18 01:06:23 +02:00
Jordi Boggiano 89e095b4b5 Handle --dev installs/updates 2012-04-14 23:38:10 +02:00
Jordi Boggiano ada9c20db1 Update Git/Hg downloaders tests, making sure they never use a live filesystem instance 2012-03-08 00:11:52 +01:00
Wookieb f93135b3bd Cosmetic tests fix - remove test directories 2012-02-24 12:28:41 +01:00
Wookieb 8d3b40ff8e Tests should remove created directories after testing process 2012-02-24 10:40:47 +01:00
Jordi Boggiano 3fe87b1e35 Force dev packages to be installed from source 2012-02-19 16:57:30 +01:00
Wookieb 2467456d3f Fix installer that create vendor and bin directory even if --dry-run parameter provided
* Move directories creation from constructor to "install" and "update" method
* Tests for LibraryInstaller
2012-02-16 22:43:10 +01:00
Jordi Boggiano 5da021ffa7 Moved Filesystem to base Util namespace 2012-02-09 18:45:28 +01:00
Jordi Boggiano 2262a3f864 Fix test 2012-02-05 21:13:16 +01:00
digitalkaoz 4d0fae688e removed replace, reinstalling as install 2012-01-23 15:43:42 +01:00
digitalkaoz 30e89a2402 fixed broken packages on filesystem 2012-01-23 15:19:05 +01:00
Jordi Boggiano e4dbee2648 Fix tests 2012-01-17 23:13:35 +01:00
Jordi Boggiano 94a8e8809c Fix travis builds 2011-12-21 16:46:23 +01:00
Jordi Boggiano 116b17dfc0 Fix test suite for OSX 2011-12-21 16:43:38 +01:00
Jordi Boggiano aefd2062c1 Update tests 2011-12-15 15:14:33 +01:00
Jordi Boggiano aa94918d50 Add binaries support in composer 2011-12-03 15:39:06 +01:00
Jordi Boggiano 14e9d4d84b Fix test 2011-11-21 18:19:32 +01:00
Jordi Boggiano 8e6f8ae57e Add prettyVersion to packages, fixes #76 2011-11-20 15:06:12 +01:00
Jordi Boggiano 4904e76185 Install every package in its own directory, fixes #73 2011-10-30 19:10:37 +01:00
Jordi Boggiano 8a571c05db Fix issues in new autoloader code 2011-10-23 19:40:22 +02:00
Jordi Boggiano 753caf2b55 Fix tests on windows 2011-09-25 23:14:12 +02:00
everzet 2fc0699492 Moved operations evaluation into new InstallationManager class 2011-09-25 19:31:51 +03:00