polarathene
1b2582ff5b
Chore: Improve create-project install UX
...
Provides feedback output before a potentially long wait on getBestCandidate() call on slow network connections where unresponsiveness/hang may be assumed.
2019-11-05 20:33:20 +13:00
polarathene
5987114f6c
Fix: Fail when install location is a file
...
In the event a file has the same name as the intended install directory, fail fast too.
2019-11-05 20:29:57 +13:00
polarathene
11207a9a2e
Fix: Check for null install directory earlier
...
Allows for failing fast when no install directory was provided to the command(uses package name instead).
2019-11-05 20:26:30 +13:00
polarathene
e5e8736383
Fix: Fail fast when the project directory is not empty
...
Avoid waiting until after `getBestCandidate()` has finished, as it can add notably delay on slow connections due to downloading megabytes of data. Only to fail if the install location is invalid.
2019-11-05 20:26:21 +13:00
Andreas Möller
f7f7883a5e
Fix: Xdebug vs xdebug
2019-11-03 14:08:14 +01:00
Jordi Boggiano
3496431a6c
Fix PSR warnings for optimized autoloader, refs #8397 , refs #8403
2019-11-01 17:13:02 +01:00
Jordi Boggiano
6a7f8ac335
Merge branch '1.9'
2019-11-01 16:41:16 +01:00
Jordi Boggiano
af86ca1fb3
Output a hint that maybe you are not in the right directory, fixes #8404
2019-11-01 16:32:34 +01:00
Jordi Boggiano
d059d90ecf
Fix PSR warnings for optimized autoloader, refs #8397 , refs #8403
2019-11-01 16:18:42 +01:00
Jordi Boggiano
502b68967a
Fix tests for PSR-fix in optimized autoloader, refs #8397
2019-11-01 15:31:55 +01:00
Jordi Boggiano
f6b8643dcd
Change PSR-fix for optimized autoloader to only warn for now, refs #8397
2019-11-01 14:50:15 +01:00
Jordi Boggiano
050707ed0c
Fix output of dump-autoload command to avoid interfering with warnings, refs #8397
2019-10-30 16:35:13 +01:00
Jordi Boggiano
3a0d05c148
Merge remote-tracking branch 'and800/fix-autoload-opts'
2019-10-30 16:22:44 +01:00
Jordi Boggiano
a0690525b5
Merge branch '1.9'
2019-10-30 15:25:57 +01:00
Jordi Boggiano
149250ab92
Remove credentials from git remotes in cache and vendor dirs
...
This only removes the credentials if they are managed by composer auth.json or equivalent, if the credentials were present in the package URL to begin with they might remain
Refs #8293
Fixes #3644
Closes #3608
2019-10-30 15:24:53 +01:00
Jordi Boggiano
4e43f849c7
Avoid overwriting credentials with existing ones from git repos, refs #8293
2019-10-30 12:56:08 +01:00
Jordi Boggiano
12184aa9c5
Fix github auth to try https with pwd also, fixes #8356
2019-10-30 12:01:23 +01:00
Jordi Boggiano
b925d06861
Fix gitlab support for basic-auth fallback from ssh URLs
2019-10-30 11:25:00 +01:00
Jordi Boggiano
ae9cc3db58
Avoid clearing the error output during removeDirectory execution, losing git error output, fixes #8351
2019-10-30 10:45:40 +01:00
Andriy Maletsky
ec293adabc
make optimized autoloader respect PSR standards
2019-10-29 20:36:29 +02:00
Armando Miani
82d939d7f7
Validate composer show with --tree and --path options set ( #8390 )
2019-10-29 15:06:07 +01:00
Jordi Boggiano
8bcacc8a3a
Merge branch '1.9'
2019-10-29 14:24:44 +01:00
MichaelKo
99e23d5263
Don't show root warning for docker containers
...
Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>
2019-10-29 14:24:33 +01:00
Markus Staab
e47aa38ad4
Added phpdoc for ComposerAutoloaderInit$SHA1::getLoader() ( #8393 )
2019-10-29 14:08:33 +01:00
Jordi Boggiano
eea4098f98
Merge branch '1.9'
2019-10-25 14:17:35 +02:00
Jordi Boggiano
4fc6479837
Fix require command to allow working on network mounts, fixes #8231
2019-10-25 14:08:30 +02:00
Jordi Boggiano
46657a8a7f
5.3 support :/
2019-10-24 15:26:55 +02:00
Jordi Boggiano
8d92048c8c
Update safeguard code, fixes #8383
2019-10-24 15:20:14 +02:00
xy2z
1a0d5dfacd
Now using findPackage() instead of HasPackageName()
2019-10-24 15:13:17 +02:00
Jordi Boggiano
78b8c365cd
Merge branch '1.9'
2019-10-24 15:05:45 +02:00
Jordi Boggiano
18dad48fa6
Merge pull request #8363 from sincilite/feature/error-reporting-for-missing-path
...
Improve error reporting for missing path in Repository Path
2019-10-24 11:34:55 +02:00
Jordi Boggiano
b311b2c077
Merge pull request #8375 from mathiasdonoso/feature/add-homepage-to-package-information-command
...
added package homepage information to the command 'show'
2019-10-24 11:32:59 +02:00
Jordi Boggiano
f2700bbd98
Merge pull request #8377 from TysonAndre/misc-nit
...
Fix misc phpdoc and strpos arg order nits for suggestions
2019-10-24 11:17:03 +02:00
Jordi Boggiano
d73cef3fb4
Avoid calling findPackage for non-platform packages
2019-10-24 11:16:42 +02:00
Jordi Boggiano
e85ade3107
Merge pull request #8386 from cedric-anne/bugfix/fix-php74-outdated-command
...
Fix composer outdated command on PHP 7.4; fixes #8346
2019-10-24 11:13:27 +02:00
Jordi Boggiano
82e0fdccca
Merge pull request #8384 from aboks/no-lock
...
Config option to disable lockfile generation
2019-10-24 11:06:02 +02:00
Jordi Boggiano
127ba941f1
Merge pull request #8376 from aschempp/bugfix/why-replaces
...
Consider replaces when checking package dependents
2019-10-24 10:48:09 +02:00
Jordi Boggiano
9082701ccb
Merge pull request #8359 from glaubinix/t/show-used-authentication-in-debug
...
Debug: display used authentication for http calls
2019-10-24 10:46:03 +02:00
Cédric Anne
9c9ca87537
Fix composer outdated command on PHP 7.4; fixes #8346
2019-10-21 13:04:31 +02:00
Stephan Vock
73b269fade
HgDriver: don't run command in non-existing directory
2019-10-21 11:11:10 +02:00
Mikhail Fesenko
c2f1a6b643
Added clear cache for windows, fix tests
2019-10-21 11:06:12 +02:00
Arnout Boks
7c5e5e3ede
Add option to disable the lock file
...
When the `lock` option is set to false, composer will not write a
`composer.lock` file to disk. This signals that the package is meant
to be developed with unlocked and always updated dependencies. At the
moment, both `install` and `update` are allowed to install the
dependencies for such a package. If #6822 is implemented, only `update`
should be used for packages without a lockfile.
https://github.com/composer/composer/issues/8354
2019-10-19 21:46:29 +02:00
Andreas Schempp
5f202efa0b
Added comment why source link check is necessary
2019-10-16 13:36:28 +02:00
Tyson Andre
4c8e41d9a9
Fix misc phpdoc and strpos arg order nits
...
https://www.php.net/strpos has the signature
`strpos ( string $haystack , mixed $needle [, int $offset = 0 ] ) : int`
(The needle is usually the constant)
`strpos('/', $suggestion)` would only be `false` for `''` and `'/'`
So the existing check would just not suggest **anything** that was
already installed (from pecl, built-in, or composer).
The intent seems to be to not suggest non-vendored php packages
that were already installed. (b20cc22ebb
)
2019-10-15 21:32:02 -04:00
Andreas Schempp
80317eb289
Remove invalid array keys
2019-10-15 10:56:43 +02:00
Andreas Schempp
20eb9e66cf
Consider replaces when checking package dependents
2019-10-15 08:26:19 +02:00
Mathías Donoso
07ec3bda3e
changed homepage information position
2019-10-15 00:38:24 -03:00
Mathías Donoso
14b3f09cf8
added package homepage information to the command 'show'
2019-10-15 00:19:57 -03:00
xy2z
a8abdd9639
Hide installed packages from suggestions when package is not found
2019-10-12 22:22:27 +02:00
Mike van Rooyen
e910e06f63
Add details of the path to aid debugging
2019-10-08 16:02:03 +01:00
Mike van Rooyen
18895064ad
Check that if the getUrlMatches method returns an empty value which means the path is incorrect
2019-10-08 15:46:35 +01:00
Alexander M. Turek
146aa4938f
Command::execute() should always return an integer.
2019-10-07 18:50:18 +02:00
Stephan Vock
0d1d35c346
Debug: display used authentication for http calls
2019-10-07 08:51:53 +01:00
Jordi Boggiano
1843312ddf
Merge pull request #8313 from unkind/feature-require-fixed
...
Provide `--fixed` option for the `require` command, fixes #8303
2019-10-06 21:39:45 +02:00
Jordi Boggiano
5b4fad9056
Update target version for master branch
2019-10-06 21:39:10 +02:00
Jordi Boggiano
9e2485aa4d
Make gitlab/bitbucket driver checks case insensitive
2019-10-06 21:37:16 +02:00
zakonnic
9f6e45051a
Optimize template for striping non-php blocks
2019-09-20 16:59:53 +03:00
zakonnic
ec96e5de64
Fix incorrect strip of non-php blocks in the file
2019-09-20 12:58:09 +03:00
Nikita Konstantinov
e3b6c67a44
Provide `--fixed` option for the `require` command, fixes #8303
2019-09-18 16:05:25 +03:00
James Ho
91732eee55
8330 Correct issue where permission umask of files were not set when archiving in zip format with ZipArchiver
2019-09-17 15:10:32 +01:00
Grey Baker
b09945c3ba
Allow for leading slash in path part of GitHub URLs
2019-09-02 22:26:35 +01:00
Jordi Boggiano
f0d565bb6d
Avoid transforming the origins when prompting for auth, fixes #8300
2019-08-30 17:52:08 +02:00
Jordi Boggiano
d3dc280322
Merge pull request #8296 from rbairwell/fix-php74-accessarray-offset-on-path
...
Fixes a problem with path based repositories on PHP7.4
2019-08-29 15:16:53 +02:00
Jordi Boggiano
7d99a56332
Combine conditionals in one
2019-08-29 15:16:34 +02:00
Jordi Boggiano
089fcde6cf
Merge remote-tracking branch 'davidszkiba/bugfix/issue-8289'
2019-08-29 15:09:14 +02:00
Jordi Boggiano
fd70d9cdc3
Stripe access tokens in a more generic way
2019-08-29 12:22:38 +02:00
rbairwell
550c01b471
Fixes a problem with path based repositories on PHP7.4 where an attempt is made to access null as an array
2019-08-27 20:53:57 +01:00
David Szkiba
0500e64f88
Respect COMPOSER_NO_INTERATION for search prompt.
...
As described in GH-8289, if no `composer.json` file is found in the current
directory, the user is prompted if she wants to use another `composer.json` file
from a parent directory even if the `COMPOSER_NO_INTERACTION` environment
variable is set. This is fixed here by just moving the check of the environment
variable up in the code so that it is evaluated before the user is prompted.
2019-08-25 17:25:44 +02:00
Stephan Vock
f9fccbab1e
GitHub: don't display access token in debug log
2019-08-21 10:07:36 +01:00
Jordi Boggiano
96ad0aa01f
Remove extra arg
2019-08-02 13:45:43 +02:00
Jordi Boggiano
872604ab36
Allow path repos to point to their own source dir as install target, resulting in noop, fixes #8254
2019-08-02 13:25:11 +02:00
Jordi Boggiano
362ebe4f68
Fix update mirrors to also update transport-options, fixes #7672
2019-07-31 18:43:18 +02:00
Jordi Boggiano
db6882b57f
Fix updating or URLs to include dist type and shasum, fixes #8216
2019-07-31 18:36:27 +02:00
Jordi Boggiano
0fe200d6d9
Fix origin computation
2019-07-31 18:01:08 +02:00
Jordi Boggiano
0261ce8092
Improve handling of non-standard ports for GitLab and GitHub installs, fixes #8173
2019-07-31 17:41:18 +02:00
Jordi Boggiano
5ddc40e93c
Load packages from the lock file for check-platform-reqs if no dependencies have been installed yet, fixes #8058
2019-07-31 15:21:32 +02:00
Thomas Perez
3e66d0514a
Fix error_handler return type declaration
2019-07-30 18:45:41 +02:00
Jordi Boggiano
26a3e12c96
Merge pull request #7994 from aschempp/feature/zip-util
...
Extract the ZIP utility functions from ArtifactRepository
2019-07-30 11:36:10 +02:00
Jordi Boggiano
3f5e4f0399
Add support for defining a {"packagist.org":false} repo in composer init, fixes #8210
2019-07-30 10:58:36 +02:00
Jordi Boggiano
14f2a6dd9a
Fix remove command not working with escaped slashes (e.g. foo\/bar), fixes #8249
2019-07-30 09:48:49 +02:00
Jordi Boggiano
1a391b572c
Prevent require command from allowing a package to require itself, fixes #8247
2019-07-30 09:18:19 +02:00
Jordi Boggiano
5de4a16115
Merge pull request #8221 from magnetik/ignore-platform-reqs-conflicts
...
Ignore platform reqs now handle conflict rules
2019-07-30 07:27:50 +02:00
Jordi Boggiano
7edd689533
Merge pull request #8243 from carusogabriel/remove-explict-void-return
...
Remove explicits void returns
2019-07-29 18:08:32 +02:00
Jordi Boggiano
d9c2f00891
Merge pull request #8240 from carusogabriel/remove-unused-private-properties
...
Remove unused private properties
2019-07-29 18:06:55 +02:00
Jordi Boggiano
8958f40f94
Make sure resetting composer also resets the IO and configuration, fixes #8224
2019-07-29 17:57:25 +02:00
Jordi Boggiano
33759d02c4
Fix require command to allow working on network mounts, fixes #8231
2019-07-29 17:42:34 +02:00
Jordi Boggiano
79e4ff4373
Merge pull request #8186 from freality/script_event_originating
...
allow Composer\Script\Event to reference originating event
2019-07-29 16:46:06 +02:00
Jordi Boggiano
369e8a2247
Fix indenting
2019-07-29 16:44:50 +02:00
Jordi Boggiano
45591597f6
Clarify how check-platform-reqs works, fixes #8191
2019-07-29 16:38:01 +02:00
Gabriel Caruso
8b5be1d08c
Remove explicts void returns
2019-07-24 03:07:25 +02:00
Gabriel Caruso
6c8ddd4d57
Remove unused private properties
2019-07-24 02:53:53 +02:00
Baptiste Lafontaine
a4611d511f
Ignore platform reqs now handle conflict rules
2019-07-11 16:48:57 +02:00
Nils Adermann
e022c07370
Merge branch '1.8'
...
* 1.8:
SVN: hide passwords for debug output
2019-06-27 14:06:49 +02:00
Jordi Boggiano
32ca426e38
Merge remote-tracking branch 'origin/1.8'
2019-06-25 11:29:25 +02:00
Stephan Vock
8da046e4e9
SVN: hide passwords for debug output
2019-06-23 18:59:36 +01:00
Nicolas Grekas
89d5d8f182
Free $solver asap
2019-06-21 18:34:16 +02:00
Rob Bast
7399638e43
fixes #8179
2019-06-17 10:48:19 +02:00
Ken Love
b51cfce8e6
return the upper-most event in chain
2019-06-13 14:51:27 -04:00
Ken Love
81a4f74b5b
Composer\Script\Event should have access to originating event details
2019-06-12 16:54:09 -04:00
Jordi Boggiano
3d88108dea
Merge branch '1.8'
2019-06-07 17:25:54 +02:00
Jordi Boggiano
b4e5db1c70
Revert "Allow overriding self-update target file with envvar COMPOSER_SELF_UPDATE_TARGET"
...
Revert "Add docs for COMPOSER_SELF_UPDATE_TARGET, refs #8151"
This reverts commit e7eecc6901
.
This reverts commit faa7c5eea2
.
2019-06-07 17:25:09 +02:00
Jordi Boggiano
79a300eaac
Merge branch '1.8'
2019-06-07 16:58:37 +02:00
Jordi Boggiano
088fb56c3d
Fix display of HHVM warning appearing when HHVM is not in use, fixes #8138
2019-06-07 16:55:22 +02:00
Jordi Boggiano
9d642fe9af
Merge pull request #8085 from danepowell/issue-8065-2
...
Fixes #8065 : Sort plugins deterministically before loading.
2019-06-07 16:53:49 +02:00
Jordi Boggiano
de10fef39c
Merge pull request #8160 from alcohol/fix-8159
...
fixes #8159
2019-06-07 16:50:51 +02:00
Jordi Boggiano
4afd50fec6
Merge pull request #8151 from naderman/self-update-target
...
Allow overriding self-update target file with env var COMPOSER_SELF_UPDATE_TARGET
2019-06-07 16:47:39 +02:00
Jordi Boggiano
472348a708
Merge pull request #8136 from pfofi/fix-urlCanon
...
Fix URL resolution for Composer repositories
2019-06-07 15:46:06 +02:00
Jordi Boggiano
fbb964888d
Merge branch '1.8'
2019-06-07 13:12:21 +02:00
Jordi Boggiano
659c72f9c8
Read classmap-authoritative and apcu-autoloader from project config when installing via create-project, fixes #8155
2019-06-07 13:12:10 +02:00
Jordi Boggiano
a8609ecf88
Merge pull request #8097 from ShiraNai7/fixStaticAutoloadPharPaths
...
Handle absolute phar:// paths in autoload_static.php
2019-06-07 12:26:49 +02:00
pfofi
82825ccc74
Use possessive quantifiers
2019-06-07 09:13:11 +02:00
Rob Bast
bd6b758a1b
fixes #8159
...
expand interface and add missing methods to aliaspackage
2019-05-29 08:48:51 +02:00
Nils Adermann
faa7c5eea2
Allow overriding self-update target file with envvar COMPOSER_SELF_UPDATE_TARGET
...
Useful if Composer is provided on a read-only filesystems, to allow
self-update to work with a different destination
2019-05-19 21:10:15 +02:00
pfofi
e7f02be9ff
Anchor pattern
2019-05-11 16:27:39 +02:00
pfofi
c751914410
Fix URL resolution for Composer repositories
...
Composer was unable canonicalize URLs in non-HTTP(S) Composer
repositories. For example it was not possible to use a `providers-url`
in a repository loaded via the `file://` scheme.
See also: #8115
2019-05-10 13:55:31 +02:00
Sam L
8288d2c456
Display branches and tags if verbose is specified
2019-05-09 08:38:34 +02:00
Rob Bast
51753bc08c
fixes #8131
2019-05-08 15:02:59 +02:00
Stephan Vock
e37ffb2a44
Fix: Bitbucket getChangeDate throws exception for branches containing a slash
2019-04-30 21:39:30 +02:00
ShiraNai7
a2b647a99e
Handle absolute phar:// paths in autoload_static.php
2019-04-11 20:23:31 +02:00
Dane Powell
188e2b0044
Merge branch 'master' into issue-8065-2
2019-04-09 11:15:33 -07:00
Dane Powell
3501423eab
Undo previous change.
2019-04-09 11:15:19 -07:00
Dane Powell
d4150cafc4
Move sortPackages to static helper class.
2019-04-09 10:59:02 -07:00
Dane Powell
266a41e046
Refactor sortPackageMap to depend on separate sortPackage function.
2019-04-09 10:58:47 -07:00
Marc Würth
d2ab4f66fd
Extract job packageName & constraint to variables
2019-04-09 13:06:33 +02:00
Jordi Boggiano
2b421a94cb
Merge branch '1.8'
2019-04-09 13:05:02 +02:00
Elan Ruusamäe
12e683e2ee
ext-imagick: support version string from ImageMagick 6.x
2019-04-09 12:49:25 +02:00
Jordi Boggiano
17810b2621
Revert composer.json changes if update process throws, fixes #8062
2019-04-09 12:47:24 +02:00
Kevin Boyd
5633a68689
Add a helper to disable process timeouts
...
The helper can be included in custom script definitions by calling
"Composer\\Config::disableProcessTimeout".
Example:
{
"scripts": {
"watch": [
"Composer\\Config::disableProcessTimeout",
"vendor/bin/long-running-script --watch"
]
}
}
2019-04-08 22:44:08 -07:00
Dane Powell
a908e22a91
Fixed code style issues.
2019-04-06 08:53:32 -07:00
Dane Powell
3e6300b5e8
code style fix.
2019-04-06 08:49:45 -07:00
Dane Powell
043b33ed38
Fixes #8065 : Sort plugins deterministically before loading.
2019-04-06 08:44:23 -07:00
Jordi Boggiano
717c21b78a
Merge remote-tracking branch 'PReimers/issue-8004'
2019-04-05 16:03:26 +02:00
Rob Bast
4ea8e48bf8
leading whitespace is optional, but newline is not
2019-04-04 08:45:08 +02:00
Rob Bast
25e3f6d4b9
expand regex and testcases
2019-04-04 08:31:26 +02:00
Rob Bast
971528916b
fix regex for heredoc/nowdoc
...
* take into account relaxed changes introduced in php 7.3
* see: 4887357269
* allow " as well as ', which was introduced in php 5.3
closes #8080
2019-04-03 10:46:35 +02:00
Jordi Boggiano
a186620210
Merge branch '1.8'
2019-04-01 18:01:19 +02:00
Jordi Boggiano
625bcee63a
Fix handling of warnings to incl all 4xx responses
2019-04-01 18:01:09 +02:00
Marc Würth
fb8b06edef
Remove unused local variable
2019-03-21 19:44:49 +01:00
Jordi Boggiano
f5e1a36f57
Merge pull request #8042 from Novicaine/patch-1
...
Fix for UNC Windows paths
2019-03-19 11:34:39 +01:00
Jordi Boggiano
8944627245
Fix syntax and backslash escaping
2019-03-19 11:34:23 +01:00
Novicaine
486b25fd30
Fix for UNC Windows paths
...
Made isAbsolutePath recognize Windows UNC-style absolute paths starting with \\
2019-03-15 13:15:01 -05:00
Christian Ego
7c64300a1b
using emptyDirectory instead of remove for clearing the cache
2019-03-11 10:24:39 +01:00
Patrick Reimers
8ae8d131d5
Add deprecation warning for name attribute
2019-03-05 10:44:55 +01:00
Jordi Boggiano
522ea033a3
Merge branch '1.8'
2019-03-04 17:26:35 +01:00
Markus Staab
c876613d5c
Added "Read more at" links to all commands ( #8019 )
2019-03-04 12:55:38 +01:00
Jordi Boggiano
e3f68016ac
Merge branch '1.8'
2019-03-04 11:59:16 +01:00
Jordi Boggiano
d96d046209
Fix require of platform packages with --ignore-platform-reqs, fixes #8012
2019-03-04 11:38:58 +01:00
Andreas Schempp
0e2215dc6c
Added full unit test coverage
2019-03-04 11:08:59 +01:00
Andreas Schempp
a91fd20673
Return the composer.json content instead of a zip:// path
2019-03-04 09:54:35 +01:00
Jordi Boggiano
9d139cb694
Merge branch '1.8'
2019-03-04 08:53:46 +01:00
Jordi Boggiano
6bce9da8c8
Only keep track of empty references that returned a 404
2019-03-04 08:53:18 +01:00
Patrick Reimers
627a832cc1
Return non zero exit code on deprecation
2019-03-01 19:39:07 +01:00
Andreas Schempp
0d0cb53f31
Adjust Zip Util to only find the root composer.json
2019-03-01 11:06:03 +01:00
Jordi Boggiano
ba1e5c213c
Merge branch '1.8'
2019-02-27 15:07:33 +01:00
Jordi Boggiano
6473dd9185
Minor improvements to VersionCacheInterface
2019-02-27 15:03:25 +01:00
Andreas Schempp
05d6b21785
Use self:: for private method
2019-02-25 08:02:04 +01:00
Andreas Schempp
9de07bed1b
Fixed docblocks
2019-02-25 08:01:38 +01:00
Jordi Boggiano
60f198c17d
Update target version
2019-02-21 14:06:41 +01:00
Jordi Boggiano
43a43f3cdf
Merge branch '1.8'
2019-02-21 14:06:17 +01:00
Jordi Boggiano
0f36a42d61
Allow filtering of warning/info msgs by composer version
2019-02-21 14:05:56 +01:00
Jordi Boggiano
4271167495
Improve version reporting
2019-02-21 14:05:12 +01:00
Jordi Boggiano
ba346ef04d
Add forward compatibility for upcoming v2 installed.json format, refs #7999
2019-02-21 12:57:27 +01:00
Jordi Boggiano
d3873a0565
Merge branch '1.8'
2019-02-20 08:43:56 +01:00
Jordi Boggiano
61cd8664e5
Avoid creating empty bitbucket files if there was no composer.json present in the original branch/tag
2019-02-20 08:43:40 +01:00
Jordi Boggiano
7a301d9ad1
Merge pull request #7980 from johnstevenson/safe-junctions2
...
Improve safe junction logic
2019-02-18 14:30:38 +01:00
Andreas Schempp
4d85e217c3
Extract the ZIP utility functions from ArtifactRepository
2019-02-16 18:46:59 +01:00
Jordi Boggiano
69745745b3
Merge branch '1.8'
2019-02-16 17:56:20 +01:00
Markus Staab
0aa030f09d
Fixed typo introduced in recent fix
2019-02-13 07:26:14 +01:00
johnstevenson
4cf069535f
Improve safe junction logic
2019-02-12 15:18:06 +00:00
Markus Staab
fc2c445c06
Make sure we properly usleep() on windows rmdir/unlink
...
usleep() returns void, therefore the previous code didn't work
2019-02-12 13:57:21 +01:00
johnstevenson
6212eadcb0
Only use junctions if they can be safely removed
2019-02-11 22:23:23 +00:00
johnstevenson
d1cf69fa92
Remove junctions with PHP rather than system rmdir
...
PHP will happily remove junctions using its `rmdir` function (tested on
versions back to 5.2.17). This saves invoking system `rmdir` through
cmd.exe.
2019-02-11 13:32:52 +00:00
Jordi Boggiano
d788c67547
Merge branch '1.8'
2019-02-11 10:52:53 +01:00
Jordi Boggiano
5ce6ae34a4
Merge pull request #7941 from johnstevenson/junctions
...
Fix mode bitmask when detecting a Windows junction
2019-02-11 10:18:10 +01:00
Nils Adermann
0619fbed58
Merge branch '1.8'
...
* 1.8:
Follow up to #7946 test: add solver flag to assert path execution
2019-02-10 20:28:05 +01:00
Nils Adermann
29ff6a40ae
Follow up to #7946 test: add solver flag to assert path execution
2019-02-10 20:26:47 +01:00
johnstevenson
da0dc74414
Update doc block, remove redundant clearstatcache
2019-02-10 14:41:20 +00:00
Jordi Boggiano
ff246e3e85
Merge branch '1.8'
2019-02-10 12:59:38 +01:00
Jordi Boggiano
94df554255
Make sure config command output is also output on --quiet so that warnings can be hidden, fixes #7963
2019-02-10 12:57:39 +01:00
Jordi Boggiano
e1ac0c7948
Recognize composer-plugin-api as a platform package, fixes #7951
2019-02-10 12:49:29 +01:00
Jordi Boggiano
408df4b878
Avoid dumping null values for dist reference/shasum and source reference, fixes #7955
2019-02-10 12:39:00 +01:00
Michael Telgmann
eee98018f7
Soften hard exit after revert of composer file
2019-02-10 11:38:47 +01:00
johnstevenson
f4b9bbbf42
Make unixy proxy code POSIX compatible
2019-02-08 17:33:13 +00:00
Jordi Boggiano
f2cc666c2c
Merge pull request #7913 from fredemmott/hhvm-version
...
Support identifying the HHVM version when not running with HHVM
2019-02-08 16:13:32 +01:00
Fred Emmott
41c7f4d2bf
Same but for Problem.php
2019-02-06 13:11:04 -08:00
Fred Emmott
17788c76f6
Better error message for present but incompatible versions
...
hhvm-nightly (and next week's release) now report 4.x, so all the 3.x
constraints are now giving misleading error messages with this patch.
Before:
```
- facebook/fbexpect v2.3.0 requires hhvm ^3.28 -> you are running this with PHP and not HHVM.
```
After:
```
- facebook/fbexpect v2.3.0 requires hhvm ^3.28 -> your HHVM version (4.0.0-dev) does not satisfy that requirement.
```
2019-02-06 12:51:30 -08:00
Nils Adermann
fdcae616b0
Merge branch '1.8'
...
* 1.8:
Fix solver problem exceptions with unexpected contradictory "Conclusions"
Also load config into IO if not freshly created
Only load configuration into IO if IO is available
Fix defaultRepos fallback does not use auth config
2019-02-05 15:32:52 +01:00
Nils Adermann
6b2edeae56
Fix solver problem exceptions with unexpected contradictory "Conclusions"
...
This 5 character fix comes with a solver test as well as a functional
installer test essentially verifying the same thing. The solver test is
more useful when working on the solver. But the functional test is less
likely to be accidentally modified incorrectly during refactoring, as
every single package, version and link in the rather complex test
scenario is essential, and a modified version of the test may very well
still result in a successful installation but no longer verify the bug
described below.
Background:
In commit 451bab1c2c
from May 19, 2012 I
refactored literals from complex objects into pure integers to reduce
memory consumption. The absolute value of an integer literal is the id
of the package it refers to in the package pool. The sign indicates
whether the package should be installed (positive) or removed (negative),
So a major part of the refactoring was swapping this call:
$literal->getPackageId()
For this:
abs($literal)
Unintentionally in line 554/523 I incorrectly applied this change to the
line:
$this->literalFromId(-$literal->getPackageId());
It was converted to:
-abs($literal);
The function literalFromId used to create a new literal object. By using
the abs() function this change essentially forces the resulting literal
to be negative, while the minus sign previously inverted the literal, so
positive into negative and vice versa.
This particular line is in a function meant to analyze a conflicting
decision during dependency resolution and to draw a conclusion from it,
then revert the state of the solver to an earlier position, and attempt
to solve the rest of the rules again with this new "learned" conclusion.
Because of this bug these conclusions could only ever occur in the
negative, e.g. "don't install package X". This is by far the most likely
scenario when the solver reaches this particular line, but there are
exceptions.
If you experienced a solver problem description that contained a
statement like "Conclusion: don't install vendor/package 1.2.3" which
directly contradicted other statements listed as part of the problem,
this could likely have been the cause.
2019-02-03 16:33:55 +01:00
Arnout Boks
82b010782d
Also load config into IO if not freshly created
2019-01-31 13:46:46 +01:00
Arnout Boks
e151a6c51c
Only load configuration into IO if IO is available
2019-01-31 13:46:45 +01:00
Arnout Boks
d1ce9f6246
Fix defaultRepos fallback does not use auth config
...
When a full 'composer' cannot be constructed (because there is no
local composer.json and no global composer.json), some commands
(e.g. `show -a`) fall back to the default repositories from the
`$COMPOSER_HOME/config.json` file. Without this fix, any auth
configuration from `$COMPOSER_HOME/auth.json` is not used for
these repositories in such a fallback scenario.
Steps to reproduce:
* Configure a password-protected composer repository in
`$COMPOSER_HOME/config.json`.
* Configure valid credentials for that repository in
`$COMPOSER_HOME/auth.json`.
* Make sure there is no file `$COMPOSER_HOME/composer.json`.
* Ensure the current working directory has no `composer.json`.
* Run `composer show -a some/package`.
Expected: Information about `some/package` is shown without
needing to enter credentials.
Actual: A prompt "Authentication required" is shown for the
private repository. When running the same command in a dir
that has a `composer.json`, or when `$COMPOSER_HOME/composer.json`
exists, things work as expected.
2019-01-31 13:46:45 +01:00
johnstevenson
e085a72f64
Fix mode bitmask when detecting a Windows junction
2019-01-31 11:23:48 +00:00
Jordi Boggiano
19ba2edd5c
Add warning/info msg when tweaking disable-tls setting to avoid confusion, fixes #7935
2019-01-30 08:58:38 +01:00
Jordi Boggiano
e05fa2368f
Merge branch '1.8'
2019-01-30 08:31:38 +01:00
Fred Emmott
1b196720bf
Support identifying the HHVM version when not running with HHVM
...
hhvm-nightly (and the next release) are no longer able to execute
Composer. Support executing Composer with PHP to install dependencies
for hack projects.
The goal is for this to be temporary, until Hack identifies a new
package manager, given that Composer does not aim to be a multi-language
package manager.
fixes #7734
2019-01-29 09:48:15 -08:00
Hans-Christian Otto
85617aa740
Installer: Initialize $nameMatchesRequiredPackage
...
We had a case where we got `Undefined variable: nameMatchesRequiredPackage` — I think it should be initialized with false, right?
2019-01-29 17:26:59 +01:00
Jordi Boggiano
f42d4d9ede
Merge branch '1.8'
2019-01-29 15:02:53 +01:00
Jordi Boggiano
585535a01d
Fix platform package regex
2019-01-29 14:58:37 +01:00
Jordi Boggiano
79af9d45af
Merge branch '1.8'
2019-01-29 13:49:25 +01:00
Jordi Boggiano
acea4a4d4d
Warn on invalid package name or require/provide/.., fixes #7874
2019-01-29 13:46:23 +01:00