1
0
Fork 0
Commit Graph

71 Commits (618e21f1c19e7085e1110299d8e419d1e92015b9)

Author SHA1 Message Date
Jérôme Tanghe a51563300c Warning about the UNIX permissions lost if unzip command is not installed.
Some packages provide (such as Symfony Panther or Dusk) executable files, but
as PHP's unzip extension does not handle UNIX permissions, those files will
lose their executable ones.
2018-10-31 18:10:36 +01:00
Jordi Boggiano 9bc578e24a Fix warning tag name, fixes #7494 2018-07-26 14:15:32 +02:00
Rasmus Schultz 5bae1913ab swap tests to prevent conflicting error-messages 2018-06-07 11:15:10 +02:00
Rasmus Schultz 07867724d0 add back the warning about missing unzip
display an error-message on non-Windows OS if unzip is unavailable, per #7383
2018-06-07 11:15:01 +02:00
AjiYakin 03c560ce05 Warn identical names w/ different capitalization for unzip
Warn about identical names with different capitalization on unzip archive
extract failure (Not a directory)

Issue #5938
2017-05-30 12:38:46 +07:00
Martin Hasoň 88ec172bd8 Fix CS 2017-05-19 15:14:47 +02:00
Jordi Boggiano c917c52f81 Message tweak, refs #6341 2017-05-16 22:45:47 +02:00
AjiYakin 8858b27ced Warn identical names w/ different capitalization - extract zip archive
Warn about identical names with different capitalization on zip archive
extract failure (Not a directory)

Issue #5938
2017-05-16 22:43:04 +02:00
Jordi Boggiano eff9326b0d Fix BC break, fixes #6419 2017-05-15 13:41:36 +02:00
Jordi Boggiano 61511cfed6 Fix CS issues, refs #6159 2017-03-30 09:29:48 +02:00
Guillaume ZITTA f89e01d622 switch first / fallback order 2017-03-14 23:43:48 +01:00
Guillaume ZITTA 2e8d715c2f fix bad visibility 2017-02-14 18:02:22 +01:00
Guillaume ZITTA 98b7bd68b4 fix docstring and useless return 2017-02-14 17:44:56 +01:00
Guillaume ZITTA 921ffe741f Cleaner fallback Algorithm 2017-02-13 15:54:55 +01:00
Guillaume ZITTA 211c874b93 split into 2 extract methods 2017-02-13 14:00:48 +01:00
Guillaume ZITTA 374ada6914 useless if, condition il already true 2017-02-13 13:43:36 +01:00
Jordi Boggiano 4d082f77b8 Simplify composer output to take less lines 2016-12-07 01:09:06 +01:00
johnstevenson 379fb70ad9 Use random name for tmp ini and delete after use
Thanks to Patrick Rose for reporting this issue.
2016-11-20 10:59:05 +00:00
Nicolas Grekas f063d28a59 Cleanup processes output handling 2016-09-02 18:44:55 +02:00
Nicolas Grekas 08d48cb61a Prefer ZipArchive over unzip on Windows 2016-03-11 11:07:36 +01:00
Niels Keurentjes d60e0c1842 Accidentally indented. 2016-02-26 14:45:19 +01:00
Niels Keurentjes 379d769132 Troubleshooting and warning in code related to issues with native ZipArchiver. 2016-02-26 08:38:39 +01:00
Jordi Boggiano a63f8d511e Avoid chmod on windows 2016-02-25 15:36:50 +00:00
Jordi Boggiano 2c67fb67f2 Rename variable and remove useless comment 2016-02-25 14:04:29 +00:00
Jordi Boggiano b945fc4d83 Add unzip support on windows and fail earlier if unzipping is impossible, fixes #4943 2016-02-25 13:09:15 +00:00
Niels Keurentjes 0dab63e050 Unified all Windows tests throughout the code. 2016-02-03 22:39:16 +01:00
Jordi Boggiano c1cc6bfecf Avoid doing too many loads of the remotefilesystem 2016-01-10 20:06:10 +00:00
Jordi Boggiano d35fc31f62 Add process error to the output of failed unzipping 2015-11-10 13:29:51 +00:00
frederik d1d40502bf ProcessExecutor::escape 2014-09-24 18:30:12 +02:00
frederik 7ae1430689 #3297 ProcessUtil class using ProcessUtil of Symfony Console 2014-09-24 17:18:15 +02:00
Jordi Boggiano ac497feaba CS fixes 2014-06-10 16:13:12 +02:00
Jordi Boggiano f16e3a88e2 Clean up code format and error message 2014-06-03 10:46:14 +02:00
Christian Schiffler 7cec839d30 Fix the ZipDownloader to catch the exceptions thrown in Symfony process.
The problem was introduced in 72d4bea8 and causes composer to not fallback
to ZipArchive when unzip can not be executed (i.e. when proc_open() is
not allowed).
2014-05-20 10:15:44 +02:00
Derrick Nelson 9a54c476eb Recursively set write permissions on unzipped package contents to resolve cache unlinking issue. 2013-09-09 21:03:49 -04:00
Nils Adermann 3960edd64e Turn EventDispatcher into generic solution handling plugins as well 2013-08-30 12:51:41 +02:00
Jordi Boggiano bd345c3b43 Add IO to proc executor in a few more places to get more debug info out 2013-08-10 02:44:11 +02:00
Jordi Boggiano 7912253df6 Retry downloading when a corrupt zip is found, fixes #2133, fixes #2128, fixes #2125 2013-07-31 20:33:20 +02:00
Jordi Boggiano 67407801b8 Add debugging info for invalid zip files to try and get to the bottom of it, refs #2125 2013-07-29 22:00:35 +02:00
Jordi Boggiano f98f093f7b Minor code reformatting and error message clarification 2013-02-11 22:55:14 +01:00
Romain Neutron 72d4bea89e Change strategy for ZipDownloader
Try to use unzip command-line before ZipArchive as this one does not correctly handle file permissions whereas unzip does.
2013-01-31 10:57:59 +01:00
Mikołaj Kopras 534fe36149 Added php.ini path to error message #1052 2012-11-28 21:26:58 +01:00
Jordi Boggiano 5a9d986e67 Implement cache GC and fix keys 2012-11-10 23:17:36 +01:00
Jordi Boggiano 39e69a3b12 Refactor OAuth acquisition code to generalize it 2012-10-21 17:56:57 +02:00
Baldur Rensch 1398757963 Added a check for the return code when extracting zip file 2012-08-17 13:06:58 -07:00
Jordi Boggiano 1bd4ccbd54 php-cs-fixer magic 2012-05-22 12:07:08 +02:00
Jordi Boggiano 98380f3aad Improve unzip failure message 2012-04-12 22:35:16 +02:00
Joseph Bielawski 9631d7c3fd [ZipDownloader] If `unzip` command failed, give cleaner error. 2012-04-10 15:59:20 +03:00
Jordi Boggiano bfd48b06bd Capture zip downloader output, fixes #533 2012-04-06 13:29:06 +02:00
Jordi Boggiano 1cd07e1a2c Fix up merged code 2012-03-29 15:08:47 +02:00
till eb8ad8b74f * docblock 2012-03-29 14:22:26 +02:00