Martin Herndl
995bf5a932
Add types to `Util` namespace, refs #10159 ( #10190 )
2021-10-19 14:35:37 +02:00
Jordi Boggiano
d1c8a4d1b4
Lots of typing improvements
2021-10-12 22:47:23 +02:00
Jordi Boggiano
a586a753df
Fix all remaining php8.1 test suite deprecations
2021-08-19 13:00:30 +02:00
Ondrej Mirtes
79093d664b
Update PHPStan and remove ignore
2021-07-21 10:10:09 +02:00
Jordi Boggiano
1b34495daa
Some phpstan level 4 fixes
2021-06-03 11:29:00 +02:00
Jordi Boggiano
b7d770659b
CS fixes
2020-11-22 14:52:39 +01:00
Simon Berger
2223b93efd
Several small code improvements
2020-09-26 00:55:19 +02:00
Simon Berger
80a75e9959
Minor code improvements
2020-09-20 02:16:28 +02:00
Simon Berger
a6475a7118
Removed unused variables, properties and parameters of private functions
2020-09-20 02:16:28 +02:00
Gabriel Caruso
8b5be1d08c
Remove explicts void returns
2019-07-24 03:07:25 +02:00
Jordi Boggiano
a9aaa25d4c
Fix compat with Symfony Process 4.2, fixes #7923
2019-01-28 14:46:34 +01:00
Gabriel Caruso
2a13bb2649
Fixes from PHPStan ( #7687 )
...
* fix docblocks
* remove redundant conditional
* fix wrong variable name
* fix wrong namespaces
* add missing private members
* remove unused/redundant arguments
* move testcase class
* exclude TestCase.php
* Tweak RuleWatchGraph type hints
* Tweak doc comment
2018-11-12 15:23:32 +01:00
Gabriel Caruso
2805a69e58
Simplify conditions and inline temp variables
2018-10-30 15:58:07 +01:00
Gabriel Caruso
71c8735e11
Use combined assignment operators
2018-09-10 14:24:41 +02:00
Jordi Boggiano
bf125295df
Fix escaping of URLs in Perforce and Subversion drivers
2018-08-25 18:48:56 +02:00
Gabriel Caruso
50045a7536
Add no_useless_else in phpcs
2017-12-19 09:20:29 -02:00
Jordi Boggiano
c8aea719b1
CS fixes
2017-12-18 16:02:48 +01:00
Gabriel Caruso
32a409a3ee
Clean elses
2017-12-16 04:23:48 -02:00
Vladimir Reznichenko
c8615358cb
SCA with PHP Inspections (EA Extended)
2017-09-11 19:40:43 +02:00
Jordi Boggiano
122e422682
CS fixes
2017-03-08 15:16:44 +01:00
Thomas Flori
7896b1ffab
cache only rendered composer information
...
As suggested we cache now only composer information and also the rendered version again. Perforce is using the same property cache as others and the `Util\Perforce::getComposerInformation()` is using the newly created methods.
2016-11-15 07:52:17 +01:00
Thomas Flori
ec27777341
code improvements as suggested
...
Thanks for your input!
2016-11-12 11:10:13 +01:00
Thomas Flori
33d026bb06
fix code style to be PSR-2 conform
...
I tried to solve all PSR-2 style guide violations in files that I changed. One I could not solve: const can not concatenate in php 5.3.
2016-11-12 09:33:05 +01:00
Thomas Flori
597f834ae9
add getFileContent function
...
This function is very similar to a part from getComposerInformation - so we can use this function in getComposerInformation too. And because it is almost everywhere the same we can put it to abstract class.
By implementing getComposerInformation in abstract class we need to add the getChangeDate to interface too. Only Problem: perforce seems not to support a ChangeDate. For this we use 'now' to have at least something.
2016-11-11 09:06:03 +01:00
Jordi Boggiano
d8840df4ac
Minor tweak
2016-04-11 15:13:51 +01:00
Andy Waterman
d4207ff49f
Strict type checks of null and bool
2016-04-06 20:55:53 +01:00
Jordi Boggiano
0ed5b541a9
Fix CS
2016-02-29 15:05:11 +00:00
Niels Keurentjes
f794ee7870
Fixes for implicit variable declarations, return type mismatches and invalid method declarations.
2016-02-27 23:39:57 +01:00
Niels Keurentjes
0dab63e050
Unified all Windows tests throughout the code.
2016-02-03 22:39:16 +01:00
Jordi Boggiano
ce08582671
Fix CS
2015-09-28 10:53:24 +01:00
Jordi Boggiano
94926218e8
CS fixes
2014-10-17 18:57:27 +01:00
Jordi Boggiano
ac497feaba
CS fixes
2014-06-10 16:13:12 +02:00
Clark Stuth
8dc6a13a1c
Removing dead code segment.
2014-03-25 10:48:38 -05:00
Clark Stuth
a12c4e2a17
Removed getWindowsFlag and setWindowsFlag methods from Perforce object.
2014-03-25 08:30:44 -05:00
Clark Stuth
dd1fd0e306
fixed perforce to reference labels instead of invalid tags
2014-03-24 15:19:35 -05:00
Clark Stuth
2651cbc5fe
Fixing perforce dev-master stored reference bug.
2014-03-21 13:51:18 -05:00
Clark Stuth
8fc1961463
Fixing delete client workspace bug.
2014-03-21 13:51:18 -05:00
Clark Stuth
c11105dd60
Fixing bug not cleaning up workspaces.
2014-03-21 13:51:18 -05:00
Clark Stuth
492539101c
got all unit tests passing
2014-03-21 13:51:18 -05:00
Clark Stuth
24dd42267f
almost all unit tests passing after IOInterface dependency refactor. no longer passing IOInterface into any Perforce methods
2014-03-21 13:51:18 -05:00
Clark Stuth
0f7b078d6c
added new dependency to Perforce object, updating some tests.
2014-03-21 13:51:18 -05:00
rockerest
9ff0c767af
Escape spaces when registering the Perforce client spec
2014-01-03 15:13:24 -06:00
mwhittom
dde9c309fd
incorporated change to Perforce: Capture output, stopping errors showing up if p4 is not available
2013-12-02 13:34:48 -06:00
mwhittom
a8084e46ff
Added error handling and error messages around missing perforce driver, invalid username/password
2013-12-02 13:34:47 -06:00
Chris Smith
c0316aa957
Capture output, stopping errors showing up if p4 is not available
2013-11-06 21:37:38 +00:00
mwhittom
0c5f4d9860
Update to fix issue with multiple perforce repositories
2013-10-17 13:39:32 -05:00
Fabian Grutschus
20854a50b4
Removed unnecessary test and just check for return code
2013-10-14 18:04:09 +02:00
Fabian Grutschus
0c5bd559f2
Changes comparsion to strict and removed a comment
2013-10-14 17:25:57 +02:00
Fabian Grutschus
67083e436b
Check for exit code is equal to 0 instead of 127
2013-10-14 15:07:35 +02:00
Fabian Grutschus
5ae5963acd
Fix for Preforce utility does not check if p4 command exists
2013-10-14 14:53:57 +02:00