Jordi Boggiano
ca5e2f8d50
Fix escaping issues on Windows which could lead to command injection, fixes GHSA-frqg-7g38-6gcf
2021-10-05 09:39:50 +02:00
Jordi Boggiano
083b73515d
Merge pull request from GHSA-h5h8-pc6h-jvvx
...
* Fix external process calls to avoid user input being able to pass extra parameters
* Tweak some fixes
2021-04-27 13:00:40 +02:00
Jordi Boggiano
fb7fc4a4ca
Fix git tests
2020-06-17 16:59:43 +02:00
Ion Bazan
58b34d13e8
fix risky tests (without any assertion)
2020-02-07 14:35:07 +08:00
Ion Bazan
a2137d5263
use Symfony PHPUnit Bridge
2020-02-07 12:22:22 +08:00
johnstevenson
7e649fac41
Fix Windows test regression from commit 149250a
...
Commit: 149250ab92
ProcessExecutor::escape handled a false value inconsistently across
platforms, returning an emtpy string on Windows, otherwise `''`. This
is fixed to return `""` on Windows.
The GitDownloaderTest code has been appropriately updated.
2019-11-07 12:50:42 +00:00
Jordi Boggiano
149250ab92
Remove credentials from git remotes in cache and vendor dirs
...
This only removes the credentials if they are managed by composer auth.json or equivalent, if the credentials were present in the package URL to begin with they might remain
Refs #8293
Fixes #3644
Closes #3608
2019-10-30 15:24:53 +01:00
Gabriel Caruso
2a13bb2649
Fixes from PHPStan ( #7687 )
...
* fix docblocks
* remove redundant conditional
* fix wrong variable name
* fix wrong namespaces
* add missing private members
* remove unused/redundant arguments
* move testcase class
* exclude TestCase.php
* Tweak RuleWatchGraph type hints
* Tweak doc comment
2018-11-12 15:23:32 +01:00
Gabriel Caruso
a17f051e29
Remove useless parentheses
2018-09-10 14:24:24 +02:00
Jordi Boggiano
c917865fe9
Fix handling of dev versions and consolidate logic, refs #7119
2018-04-13 13:55:02 +02:00
Jordi Boggiano
24ad6307a7
Merge remote-tracking branch 'austris-argalis/issue-7085'
2018-04-13 13:11:46 +02:00
Jordi Boggiano
066351c5b9
Remove use of deprecated getMock method
2018-04-12 10:24:56 +02:00
austris argalis
8a5645ffda
Wording: Downgrading instead of Updating #7085
2018-02-16 00:38:41 +02:00
Jordi Boggiano
50665aa18d
Simplify check for current revision, refs #6684
2017-12-19 17:50:02 +01:00
Robert Lu
3ce71a55bf
fix unittest
2017-11-07 13:54:52 +08:00
Jordi Boggiano
122e422682
CS fixes
2017-03-08 15:16:44 +01:00
AnrDaemon
1d2a949e3e
Properly fix git excludes.
...
Mindless copy-paste never gets old. Sorry. This is fixed proper this time.
2016-12-24 03:19:50 +03:00
AnrDaemon
ab70601700
Skip git-related tests if no git found.
2016-12-22 20:14:57 +03:00
Richard Heelin
c2f6c61f56
Updated the tests to match the new command that is executed
2016-10-21 15:49:27 +01:00
Jordi Boggiano
334d0cce6b
Make sure we do not clone from local mirror if mirroring failed
2016-07-02 23:52:10 +01:00
Jordi Boggiano
4998ee27b3
Re-use mirror code from the git driver, refs #5384
2016-07-02 17:20:51 +01:00
Marco Villegas
869b3ef954
New test to check git download behavior with cache.
2016-06-18 19:39:09 -05:00
Marco Villegas
cb6cfa9635
Isolate config setup to make it reusable at GitDownloaderTest.
2016-06-18 19:39:09 -05:00
Marco Villegas
b5c55d5167
Adjust GitDownloaderTest to include for the new getVersion() method in Git.
2016-05-30 11:58:25 -05:00
Luis Faceira
1d733ba21a
GitDownloaderTest uses temp dir as composer home config
...
When creating a DownloaderMock a home config dir is
ensured to exist, so that no test fails for lack of it
that on a regular run would be set by the Factory
2016-05-29 12:36:19 -05:00
Jordi Boggiano
73139a59bf
Update origin remote URL when package URL changed and origin still uses the same url as the composer remote, fixes #3874
2016-04-18 10:10:12 +01:00
Jordi Boggiano
b93b73e836
Rewrite git unpushed status checks, fixes #4987
2016-03-02 13:00:20 +00:00
Jordi Boggiano
fea99bcb1b
Clarify the fetch/push URL selection for github repos and various protocols, fix regression
2016-03-01 13:43:59 +00:00
Jordi Boggiano
b080a73840
Fix broken test on windows, fixes #4973
2016-03-01 13:25:39 +00:00
Jordi Boggiano
6f42b9c865
Disable git, svn, http protocols for VCS downloaders, fixes #4968
2016-03-01 13:20:35 +00:00
Niels Keurentjes
a409e158b8
Disabled unit test breaking on some platforms. Ref #4973
2016-02-28 01:08:25 +01:00
Jordi Boggiano
2f638c7d96
Fix test
2016-02-25 21:16:48 +00:00
Jordi Boggiano
be4d385942
Fix uncommitted change detection, refs #3633
2016-02-25 20:59:26 +00:00
Jordi Boggiano
9f4f8a9578
Merge remote-tracking branch 'greg0ire/improve-status-for-unpushed-branches'
2016-02-25 19:43:20 +00:00
Magnus Nordlander
4689d836fe
Fixed (and added a test for) a regression introduced in a77e2fb
, which causes package Git package updates to fail when the package has two or more URLs and the last URL is the only one that actually works.
2016-02-17 17:42:48 +01:00
Niels Keurentjes
0dab63e050
Unified all Windows tests throughout the code.
2016-02-03 22:39:16 +01:00
Rob Bast
adf3b956d0
try to use unique test directories
...
any tests that use the filesystem should have their own unique directory, as we run our test suite in parallel and
cleanup of tests (removing directories) should not interfere with currently running tests
2016-01-26 09:41:21 +01:00
Alexander Loutsenko
397ae2d7c8
review fixes
2015-12-14 18:50:04 +03:00
Alexander Loutsenko
fa5de786ff
clean garbage dirs in tmp after composer tests #4694
2015-12-14 17:52:37 +03:00
James Titcumb
d85bad29d6
Warn about unpushed changes
...
`composer status` now prevents overwriting Git package if changes have not been pushed.
2015-08-30 00:30:16 +02:00
Jordi Boggiano
0081964428
Merge remote-tracking branch 'colinodell/fix-tag-ambiguity'
...
Conflicts:
src/Composer/Downloader/GitDownloader.php
tests/Composer/Test/Downloader/GitDownloaderTest.php
2015-05-31 12:52:27 +01:00
hakre
7077803aa4
Git Checkout Branch / File Differentiation
...
This fixes a minor inaccuracy issue when creating git checkout commands
for branches.
The git checkout command used within `GitDownloader::updateToCommit()`
does not use the "`--`" sequence to separate branch from file parameters.
This leads to an inaccuary as git tries as well the branch name as file
name. If the non-existent branch is actually the name of a file, the file
is checked out. If the non-existent branch is not the name of a file, an
error message is given:
> error: pathspec 'non-existent-branch' did not match any file(s) known to
git.
Both cases are not expected for the program flow in
`GitDownloader::updateToCommit()`.
The only thing that is expected is a non-existent branch to fail to
checkout - but with a different error message:
> // reference was not found (prints "fatal: reference is not a tree:
$ref")
This can be easily fixed by adding the missing separator when constructing
the command which is applied with this commit.
2015-03-19 12:50:06 +01:00
Colin O'Dell
f304611014
Fix Git failures due to tag ambiguity (issue #3417 )
2014-11-14 10:31:52 -05:00
Jordi Boggiano
a309e1d89d
Fix tests and run it before the push url updater
2014-10-20 20:16:14 +01:00
Jordi Boggiano
77163f66fc
Add support for mirrors in composer repos
2014-05-07 19:34:35 +02:00
Jordi Boggiano
5d4900e79d
Add --no-checkout flag to avoid checking out the default branch first, fixes #2717
2014-02-18 13:28:46 +01:00
Jordi Boggiano
7148b22414
Add github-domains config value for GitHub Enterprise setups, fixes #728
...
Signed-off-by: Gennady Feldman <gena01@gmail.com>
2013-10-28 12:40:20 -04:00
Jordi Boggiano
7252078508
Attempt to fix travis build
2013-07-26 15:44:52 +02:00
Jordi Boggiano
771233a5a0
Make it clear what is going on when a vcs folder is missing, fixes #2108
2013-07-26 12:25:05 +02:00
Jordi Boggiano
0822683706
Fix tests
2013-06-28 20:42:06 +02:00