David Zülke
c45b403967
tests for empty or absent repository filters ( #11476 )
...
The behavior in FilterRepository is currently correct, but not explicitly tested.
Also add a test that ensures both filters can't be there simultaneously.
2023-05-28 15:02:12 +02:00
Jordi Boggiano
52f6f74b7c
Merge branch '2.5'
2023-05-24 15:00:53 +02:00
Jordi Boggiano
33c293aec3
Fix autoload regression with metapackage dependencies ( #11481 )
...
fixes #11480
introduced by #11455
2023-05-24 14:58:11 +02:00
Jordi Boggiano
5a96e6ae13
Merge branch '2.5'
2023-05-23 23:49:53 +02:00
Jordi Boggiano
23654389da
Fix lock file verification to take into account root provider/replacers and output mismatches there more clearly, fixes #11458 ( #11475 )
2023-05-23 23:15:07 +02:00
Stefan Grootscholten
9d965b9c65
Fix authentication issues with private bitbucket repos ( #11464 )
2023-05-23 23:14:11 +02:00
Jordi Boggiano
24361ae654
Merge branch '2.5'
2023-05-23 16:25:24 +02:00
Jordi Boggiano
e51d755a08
Fix numeric default-branches with v prefix (e.g. v2.x-dev) being treated as non-numeric and receiving an alias like e.g. dev-main
2023-05-23 16:25:08 +02:00
Jordi Boggiano
0d68dabb5f
Add more tests for install command, refs #11277
2023-05-15 21:54:40 +02:00
Alex Theobold
fb2c17d696
Test install command ( #11277 )
...
* Adds test class boilerplate
* test: Tests warning returned with dev flag
* test: warning returned with no-suggest flag
* test: packages passed is invalid
* test: no-install flag passed
---------
Co-authored-by: alex.theobold <alex.theobold@sykescottages.co.uk>
2023-05-14 14:15:44 +02:00
Yanick Witschi
f9944867c3
Added integration test
2023-05-02 22:10:18 +02:00
Yanick Witschi
995b806dfe
Optimize PoolBuilder to not load replaced targets if not required
2023-05-02 22:10:18 +02:00
Jason Woods
010bad5428
fix: If a replacer is updated to a version that no longer replaces, the replaced package is not loaded
2023-05-02 22:07:57 +02:00
Stephan
11879ea737
ArrayLoader: handle invalid support value ( #11440 )
2023-04-26 15:26:45 +02:00
David Zülke
e0c1ad1448
PlatformRepository library support for libpq (from ext-pq) and librdkafka (from ext-rdkafka) ( #11418 )
...
* libpq library version info for ext-pq
* librdkafka library version info for ext-rdkafka
Computes from RD_KAFKA_VERSION, faster than output buffering
2023-04-25 13:59:36 +02:00
Jordi Boggiano
776ff2ea51
Merge branch '2.5'
2023-03-21 11:53:54 +01:00
Jordi Boggiano
8b0a185d5d
Fixed display of empty objects showing [] instead of {} in config command, fixes #11302
2023-03-21 11:17:55 +01:00
Jordi Boggiano
5f298ae294
Merge branch '2.5'
2023-03-21 10:45:40 +01:00
Jordi Boggiano
5c3d8f35db
Update deps, fix phpstan issues, update baseline (1711, 49)
2023-03-21 10:36:42 +01:00
Stephan
685a2e6be2
Composer support string ( #11386 )
...
* GitHubDriver: fix support is set to string
* GitLabDriver: fix support is set to string
* BitbucketDriver: fix support is set to string
* Fix PHPStan
2023-03-20 20:18:19 +01:00
Edgaras Janušauskas
f41abfca34
Add platform check for 64-bit PHP ( #11334 )
2023-03-20 16:08:12 +01:00
Ben Ramsey
cd137ee29b
Add security to support options ( #11271 )
...
This support option allows projects to specify a URL to the project's
vulnerability disclosure policy (VDP).
2023-03-10 22:28:10 +01:00
Markus Staab
d8221bd443
PHPStan: Fixed handling of union types in ConfigReturnTypeExtension ( #11312 )
...
Co-authored-by: Markus Staab <m.staab@complex-it.de>
2023-02-10 14:00:33 +01:00
Andor
50cded331c
Default exclude patterns for the "archive" command ( #11239 )
...
* Issue #11235 - Adds default exclude patterns for the "archive" command based on the target file name
2023-01-27 17:16:33 +01:00
Jordi Boggiano
ad7bc18028
Fix self.version requirements failing the lock file integrity check if on a different version, fixes #11274 ( #11283 )
2023-01-27 16:54:45 +01:00
Jordi Boggiano
0a2846cb24
Fix autoloading on PHP 5.6 ( #11285 )
...
* Add a CI check to ensure the autoloader can run on php5.6+
* Fix autoloading on PHP 5.6
2023-01-27 16:26:04 +01:00
Jordi Boggiano
5165792f9c
Fix security advisory parsing when filter repo is used, fixes #11281
2023-01-27 11:09:34 +01:00
Jordi Boggiano
f6f972a699
Fix require regression with --fixed, fixes #11247
2023-01-19 21:42:22 +01:00
Jordi Boggiano
0d96fd8149
Warn when require ends up auto-selecting a feature branch, fixes #11264 ( #11270 )
2023-01-19 21:42:09 +01:00
Alex Theobold
2431b12230
Test home command ( #11254 )
...
Co-authored-by: alex.theobold <alex.theobold@sykescottages.co.uk>
2023-01-13 09:34:03 +01:00
Dan Barrett
ca9fb64691
Added tests for the Suggests command
2023-01-06 12:38:47 +11:00
Dan Barrett
7560873740
Added tests for the Remove command
2023-01-06 12:38:47 +11:00
Dan Barrett
29ae7b632a
Add "missing lockfile" test for the Audit command
2023-01-06 12:38:40 +11:00
Dan Barrett
b2304d0b12
Exclude PHPStan extensions from PHPUnit coverage
2023-01-03 18:57:00 +11:00
Jordi Boggiano
d047f38f73
Make sure autoloader closures do not have a scope class set
2022-12-22 21:01:38 +01:00
Jordi Boggiano
cbb7c91223
Fix ClassLoader to be serializable ( #11237 )
...
* Fix ClassLoader to be serializable
* Fix CI to use the source bin/composer as process for "composer" runs incl within simple-phpunit
* Store the closure statically to avoid serialization issues in a cleaner way
2022-12-22 15:17:04 +01:00
Jeffrey Cafferata
da611e089a
Docs: fix documention deep links ( #11233 )
...
* Docs: Fixed the deep links to the documentation website.
Search scope: `src/Composer/Command`.
* Docs: Fixed the deep links to the documentation website.
2022-12-21 09:32:50 +01:00
Jordi Boggiano
3534499c6b
Add test covering edge case of composer repo format, closes #11206
2022-12-17 23:15:40 +01:00
Ondřej Mirtes
2aa33aaafa
Update PHPStan ( #11222 )
...
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-12-17 23:12:38 +01:00
Jordi Boggiano
957e7a9165
Merge pull request #11218 from localheinz/fix/patch
...
Fix preserving of major.minor.patch version when running `composer bump` and installed patch version is `0`, and add bumping of >=x to >=latest
2022-12-17 23:05:21 +01:00
Jordi Boggiano
ef7ba73a6a
Add support for bumping >=x to >=latest, fixes #11179
2022-12-17 23:02:52 +01:00
Jordi Boggiano
7f9638f65a
Fix implementation to fix tests, fixes #11220
2022-12-17 22:50:19 +01:00
PrinsFrank
6d1b36be3b
Check missing-from-lock-file required packages when running install and fail when there are any ( #11195 )
2022-12-16 16:48:24 +01:00
Andreas Möller
caebfe14ee
Fix: Add test case for not dropping patch version
2022-12-12 17:25:20 +01:00
Ion Bazan
8ff237afb6
[Tests] Use static data providers ( #11197 )
2022-11-24 14:39:08 +01:00
Jordi Boggiano
bd6a5019b3
Update to composer/pcre 2.1 ( #11189 )
2022-11-17 11:34:54 +01:00
Jordi Boggiano
5b28754602
Avoid normalizing to absolute paths if base dir is /toplevel to improve docker portability, fixes #11165 , fixes #4404 ( #11169 )
2022-11-10 16:32:18 +01:00
Jordi Boggiano
6c85b875f2
Update to PHPStan 1.9
2022-11-03 21:53:42 +01:00
Jordi Boggiano
36bc30ffab
Make the require command guess versions more accurately by delegating to the solver (except with --no-update) ( #11160 )
2022-11-01 15:48:52 +01:00
Jordi Boggiano
6e55cb36d8
Add support for adding Command classes as scripts, ( #11151 )
...
* Add support for adding Command classes as scripts, fixes #11134
* Allow all options to be forwarded and allow using references to other scripts with args
* Fix build
* Add more checks
* Ensure exceptions are not swallowed, and remove naming restriction by using a single-command app
* Update docs
* Add tests, fix issue merging params when combining nested scripts and CLI params
2022-10-28 14:24:55 +02:00
Jordi Boggiano
a63ce7cf96
Add message when doing composer outdated --direct and there is nothing to show, fixes #11152 ( #11156 )
2022-10-27 16:21:53 +02:00
Alex Theobold
97f4fbc4b0
Adds test coverage to the Fund Command ( #11150 )
...
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-10-26 13:40:01 +02:00
Alex Theobold
b5b4e15876
test: Create test for CheckPlatformReqsCommand ( #10932 )
2022-10-25 19:42:42 +02:00
Giulio
1b3a2ed6f6
test: Coverage for ValidateCommand ( #11133 )
...
Co-authored-by: giulio-Joshi <me@joshi.it>
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-10-25 16:38:01 +02:00
Stephan Jorek
d54f2f21c5
Feature: Add support for autocompleting setting-keys in config-command ( #11130 )
...
* Add support for autocompleting setting-keys in config-command
This PR implements the support for autocompletion of setting-keys in the
config-command and its related funtional tests. The implementation takes
existing command-line options like `--unset` or `--global` into account, as
well as existing exposable package-properties. The result is a context-
sensitive auto-completion of individual lists of setting-keys.
Additionally showing the value `suggest.` sub-keys has been allowed in
the config-command, as setting and unsetting them has alwas been possible,
and I did not want to distinguish between showing, setting and unsetting
those keys.
In the setting-key flattening-method I used the `array_is_list()` function,
which was added in PHP 8.1 recently. For backwards PHP-compatiblity the
package `symfony/polyfill-php81` has been added.
Signed-off-by: Stephan Jorek <stephan.jorek@brandung.de>
2022-10-25 16:24:02 +02:00
Jordi Boggiano
8ffd8bef08
Merge branch '2.4'
2022-10-25 15:27:14 +02:00
Ayesh Karunaratne
90673e4f66
Update URL masking patterns for new GitHub fine-grained PATs
...
Updates GitHub Personal Access Token regex pattern to detect new [fine-grained PATs](https://github.blog/changelog/2022-10-18-introducing-fine-grained-personal-access-tokens/ )
2022-10-25 15:07:24 +02:00
Kuba Werłos
e5b8f2d838
Add "--dry-run" to bump command ( #11047 )
2022-10-25 15:03:36 +02:00
Jordi Boggiano
ce082cd5b3
Merge branch '2.4'
2022-10-13 11:21:52 +02:00
Jordi Boggiano
205ba37825
Fix tests
2022-10-13 11:21:41 +02:00
Leo Viezens
13e673df76
#10796 Add test for ExecCommand ( #11094 )
2022-10-13 11:21:19 +02:00
Gaëtan Faugère
52f91b2dd9
Add test and documentation regarding audit command when no packages are required ( #11092 )
2022-10-13 10:53:26 +02:00
Jesper Skytte Marcussen
b52e6b4a74
Add tests for BumpCommand ( #11097 )
...
I've added tests for the BumpCommand to increase the test coverage.
See #10796
Signed-off-by: Jesper Skytte <jesper@skytte.it>
Signed-off-by: Jesper Skytte <jesper@skytte.it>
2022-10-13 10:42:03 +02:00
Jesper Skytte Marcussen
d1bf685ea8
Added lots of new tests for `InitCommand` ( #11106 )
...
This commit adds tests for all the different input options.
2022-10-13 10:39:51 +02:00
Jesper Skytte Marcussen
c728569d33
Added new `LicensesCommandTest` class ( #11105 )
2022-10-12 17:25:28 +02:00
Mauro Bonfietti
d8a0127c0c
Added tests for Clear Cache Command. ( #11066 )
...
* Added tests for Clear Cache Command.
* Fix side-effects breaking other tests
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-10-12 17:19:58 +02:00
Jordi Boggiano
06359da3a3
Merge branch '2.4'
2022-10-12 16:55:56 +02:00
JT Smith
08c04d2c9c
Typofixes ( #11096 )
...
* Fixing typo in private method name
* Various comment-related typofixes
2022-10-12 16:45:10 +02:00
Jordi Boggiano
8618f004f7
Fix parsing of aliases used within complex OR constraints, fixes #11086
2022-10-12 16:16:31 +02:00
Abdullahi Temidayo Jimoh
05aecfbe8b
Test for About command ( #11078 )
2022-10-12 14:22:28 +02:00
Jordi Boggiano
822fd640d0
Add warning when outdated command rejects an existing version due to platform requirements, fixes #11016 ( #11113 )
2022-10-12 13:57:14 +02:00
Jellyfrog
8ed7c46179
Add download-only mode ( #11041 )
...
composer install --download-only to prime the cache/download archives but not do any actual of the actual installing
Fixes #11035
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-10-12 13:56:35 +02:00
Jordi Boggiano
7df744531b
Merge branch '2.4'
2022-10-12 11:27:30 +02:00
Kuba Werłos
f8435b6d10
Unify command names in the docs ( #11071 )
2022-10-12 10:55:57 +02:00
Jordi Boggiano
8600894003
Update deps, constrain a few types to non-empty-strings
2022-10-12 09:19:36 +02:00
Kuba Werłos
e870206c4a
Add "--dry-run" to bump command ( #11047 )
2022-09-19 08:45:49 +02:00
Jordi Boggiano
ef018748eb
Merge branch '2.4'
2022-09-14 14:02:28 +02:00
Jordi Boggiano
ec8bbe9056
Fix package filter on bump command, fixes #11053
2022-09-14 14:00:27 +02:00
Jordi Boggiano
02082905a3
Merge branch '2.4'
2022-09-13 15:17:04 +02:00
Jordi Boggiano
ab29ed5f97
Fix handling of upper-bound platform req ignores to not act on conflicts ( #11037 )
...
* Fix handling of upper-bound platform req ignores to not act on conflicts, fixes #11020
* Optimization
2022-09-13 14:50:27 +02:00
Jordi Boggiano
4164b30236
Fix show --platform regression failing if no composer.json exists, fixes #11046
2022-09-13 14:49:25 +02:00
Ondřej Mirtes
d951c48ac0
Tests bootstrap - require InstalledVersions only if it's not declared yet ( #11014 )
2022-08-31 12:42:26 +02:00
Jordi Boggiano
c10854d3f3
Remove extra lines
2022-08-31 12:42:26 +02:00
Jordi Boggiano
d0ac10ca6a
Merge branch '2.4'
2022-08-31 12:41:52 +02:00
Ondřej Mirtes
554914923d
Tests bootstrap - require InstalledVersions only if it's not declared yet ( #11014 )
2022-08-31 12:39:43 +02:00
Jordi Boggiano
5b754c797e
Remove extra lines
2022-08-31 12:26:58 +02:00
Jordi Boggiano
39de9899a7
Lock down include wrappers to avoid abuse from third parties ( #11015 )
2022-08-31 12:07:23 +02:00
Jordi Boggiano
c5932d810f
Merge branch '2.4'
2022-08-31 09:50:30 +02:00
Jordi Boggiano
3177b21324
Fix handling for double-zero prefix, refs #11032
2022-08-31 09:47:59 +02:00
Jordi Boggiano
7e0ac53fc4
Merge branch '2.4'
2022-08-30 20:47:34 +02:00
Jordi Boggiano
2d48c7dbb0
Fix handling of zero-major versions in outdated --major-only flag, fixes #11032
2022-08-30 20:45:07 +02:00
Ondřej Mirtes
b6028951b8
Tests bootstrap - require InstalledVersions only if it's not declared yet ( #11014 )
2022-08-22 15:00:18 +02:00
Thomas Landauer
ceb8bef778
Adding hint what "Direct dependencies" means ( #11013 )
2022-08-20 09:24:25 +02:00
Zan Baldwin
d2d8474013
Do not apply non-array package links in ArrayLoader ( #11008 )
2022-08-20 08:58:17 +02:00
Zan Baldwin
51774693c7
Do not apply non-string package link constraints in ArrayLoader ( #11009 )
2022-08-20 08:34:38 +02:00
Jordi Boggiano
131da999ac
Fix CS ( #11003 )
2022-08-17 14:20:07 +02:00
Jordi Boggiano
6e205a0c84
Fix minor bug in process executor mock
2022-08-17 13:23:16 +02:00
Jordi Boggiano
f95471f221
Show/outdated command fixes ( #11000 )
...
* Fix show command showing the split of direct/transitive deps from outdated, fixes #10999
* Fix a few minor edge cases in show command, add tests for show and outdated commands
2022-08-17 12:08:59 +02:00
Jordi Boggiano
cc33db9257
Only fetch remote default branch for mirrored git repos, not local ones, refs #10949 ( #10996 )
2022-08-16 15:53:57 +02:00
Thomas Lüder
41d6467b3b
Added token refresh for GitLab to support GitLab 15+ ( #10988 )
...
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-08-16 13:34:18 +02:00
Jordi Boggiano
f1877afc0b
Merge branch '2.3'
2022-08-16 11:27:40 +02:00
Jordi Boggiano
550fc3d321
Merge branch '2.2' into 2.3
2022-08-16 11:27:34 +02:00
Jordi Boggiano
f2141dd3ea
Fix tests from #10985
2022-08-16 11:25:15 +02:00
Stephan
1f0bd51f55
GitHubDriver: stricter URL validation to avoid issues with undefined index owner ( #10985 )
2022-08-16 11:08:03 +02:00
Ion Bazan
74a045783b
Add SearchCommand tests ( #10982 )
...
Signed-off-by: Ion Bazan <ion.bazan@gmail.com>
2022-08-16 10:52:01 +02:00
Jordi Boggiano
135ca98eb0
Remove workaround for upstream bug
2022-08-16 10:46:07 +02:00
Jordi Boggiano
a6d872191c
Disable packagist.org loading by default in initTempComposer test cases if other repos are provided
2022-08-16 10:41:58 +02:00
Jordi Boggiano
7377d1f003
Uniformize command description format, fixes #10971
2022-08-16 10:41:07 +02:00
Jordi Boggiano
d0b60f115b
Merge pull request #10958 from Seldaek/signal_fixes
...
Signal handling improvements
2022-07-21 11:09:30 +02:00
Jordi Boggiano
8352ab8eb7
Expand test to avoid regressions
2022-07-21 11:08:41 +02:00
Jordi Boggiano
9fbc386a7b
Fix package selector warnings to only show for versions that were actually skipped, #10942
2022-07-21 11:06:13 +02:00
Jordi Boggiano
9d90bc649d
Fix tests
2022-07-20 22:53:57 +02:00
Jordi Boggiano
1a4f2174e4
Add seld/signal-handler dependency
2022-07-20 22:32:09 +02:00
Jordi Boggiano
3595666e6e
Merge branch '2.3'
2022-07-17 13:07:44 +02:00
Jordi Boggiano
3c68b579ed
Merge branch '2.2' into 2.3
2022-07-17 13:06:43 +02:00
Jordi Boggiano
70b78137a9
Merge branch '2.3'
2022-07-05 16:54:43 +02:00
Jordi Boggiano
9a6d63f0f4
Fix build regressions
2022-07-05 16:22:29 +02:00
Jordi Boggiano
c422fefda4
Merge branch '2.3'
2022-07-01 12:24:58 +02:00
Jordi Boggiano
1703b74e73
Add missing return types
2022-07-01 12:24:54 +02:00
Jordi Boggiano
796d2bae08
Merge branch '2.3'
2022-07-01 12:15:30 +02:00
Jordi Boggiano
618fcb800b
Merge branch '2.2' into 2.3
2022-07-01 12:05:18 +02:00
Andreas Schempp
424547bb70
Correctly merge boolean flag of allow-plugin config ( #10909 )
2022-07-01 11:08:35 +02:00
Jordi Boggiano
1812862d5e
Update phpstan to latest, update baseline (1909, 103)
2022-06-30 17:07:18 +02:00
Jordi Boggiano
efd426f8bb
Extract some common logic for filtering away dev requirements into a RepositoryUtils
2022-06-30 15:05:34 +02:00
Jordi Boggiano
8c9f82dc1e
Move security advisory loading to repositories, allows others to provider them and reduces load on packagist.org for summary advisory reports
2022-06-24 16:26:57 +02:00
Jordi Boggiano
4229c2c641
Merge branch '2.3' into main
2022-06-24 11:10:07 +02:00
Stephan
6776cef441
Fix: ValidatingArrayLoader [TypeError]: strcasecmp(): Argument #1() must be of type string, int given ( #10897 )
2022-06-24 10:30:33 +02:00
Jordi Boggiano
eba49147e7
Add warning when the latest version of a package cannot be auto-selected in require/init/create-project, fixes #10884 ( #10896 )
2022-06-23 14:37:04 +02:00
Jordi Boggiano
611b215896
Fix PHPStan issues and a couple minor bugs in audit functionality, refs #10798
2022-06-22 15:39:51 +02:00
Guy Sartorelli
d93239ddd9
Add audit command to check for security issues ( #10798 )
...
Closes #10329
2022-06-22 15:15:01 +02:00
Mathias Reker ⚡️
d17c724f23
Php unit dedicate assert ( #10881 )
...
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-06-22 14:20:08 +02:00
Jordi Boggiano
d132b9e6fd
Fixup
2022-06-22 13:11:28 +02:00
Jordi Boggiano
3a945ac70f
Delete ClassMapGenerator tests which are not needed anymore
2022-06-19 14:08:02 +02:00
Jordi Boggiano
7d4d941392
Make use of new composer/class-map-generator package and build up BC layer
2022-06-19 14:02:24 +02:00
Jordi Boggiano
70f2dd6edd
Add bump command to bump requirements to the currently installed version, fixes #7273 ( #10829 )
2022-06-09 11:43:59 +02:00
Jordi Boggiano
ab1de96fcb
Do not verify rate limit OK as part of test as these might randomly fail
2022-06-06 17:01:31 +02:00
Jordi Boggiano
367012513d
Merge branch '2.3' into main
2022-06-06 16:49:52 +02:00
Jordi Boggiano
cb76394800
Merge branch '2.2' into 2.3
2022-06-06 16:34:34 +02:00
Jordi Boggiano
3c11895c1e
Command tests
2022-06-06 10:48:42 +02:00
Jordi Boggiano
8792163676
Merge branch '2.3' into main
2022-06-06 10:23:04 +02:00
Anatoly Pashin
a0b7896231
Fix processing null config value in DiagnoseCommand
...
Fixes #10814
2022-06-06 09:58:15 +02:00
Jordi Boggiano
15f7d24e7e
Parse openssl 3 versions cleaner
2022-06-02 21:17:44 +02:00
Jordi Boggiano
5888945c30
Fix tests on windows
2022-06-01 22:10:48 +02:00
Jordi Boggiano
e2645a13b6
Merge branch '2.3' into main
2022-06-01 22:00:44 +02:00
Jordi Boggiano
ef06702e45
Merge pull request #10320 from GromNaN/command-completion
...
Add completion to commands options and arguments
2022-06-01 21:59:39 +02:00
Jordi Boggiano
e1ab520d64
Merge branch '2.2' into 2.3
2022-06-01 21:39:31 +02:00
Nicolas Hedger
70a7b592e9
Fix JSON schema regex pattern ( #10811 )
2022-06-01 21:23:07 +02:00
Jordi Boggiano
556450b15b
Allow using temporary update constraints on all packages (incl non-root), fixes #10436 ( #10773 )
2022-05-27 14:51:46 +02:00
Jordi Boggiano
202ef9031c
Merge branch '2.2' into 2.3
2022-05-25 21:44:40 +02:00
Jordi Boggiano
10d3895f18
Ensure that dotfiles can be excluded, fixes #8866
2022-05-24 22:14:17 +02:00