1
0
Fork 0
Commit Graph

7919 Commits (da611e089af18275f3a56fc7100aa714f0ac94f9)

Author SHA1 Message Date
Jordi Boggiano 166542f981
Fix param nullability 2022-03-21 14:05:56 +01:00
Jordi Boggiano 8b373a1306
Make sure path repo reuses an existing ProcessExecutor if provided to it, fixes #10642 2022-03-21 13:43:38 +01:00
Stephan bd89a67398
SvnDriver: buildIdentifier must be of type int, string given (#10646) 2022-03-21 13:18:11 +01:00
Jordi Boggiano f68ea293d5
Reverting release version changes 2022-03-20 13:20:49 +01:00
Jordi Boggiano 36dc875e1c
Release 2.3.0-RC2 2022-03-20 13:20:49 +01:00
Jordi Boggiano fd2972247f
Add missing param types, fixes #10638 2022-03-18 14:45:59 +01:00
Jordi Boggiano c9ff588d68
Mark abstract class as such 2022-03-18 14:29:50 +01:00
Jordi Boggiano e0022880cc
Tiny wording tweak 2022-03-18 14:29:17 +01:00
Jordi Boggiano bbf2e94579
Fix a few type errors, update baseline (2170, 104) 2022-03-18 10:14:38 +01:00
Jordi Boggiano e63e15aea8
Fix usage of react/promise resolve() to prepare for v3 2022-03-18 09:20:42 +01:00
Jordi Boggiano 96ad838686
Add try/finally to ensure we always reset the max jobs 2022-03-18 09:08:44 +01:00
Jordi Boggiano b0665981c2
Parallellize the branch comparisons to speed up bootstrapping/version guessing when on a feature branch (#10632)
* Parallellize the branch comparisons to speed up bootstrapping/version guessing when on a feature branch, fixes #10568

* Allow ProcessExecutorMock to function with async calls
2022-03-17 14:52:14 +01:00
Jordi Boggiano ca3b874414
Fix issue in remove command when allow-plugins is not present at all, fixes #10629 2022-03-17 10:38:24 +01:00
Jordi Boggiano dec123770f
Fix phpversion() returning false when an extension has no version, fixes #10631 2022-03-17 10:34:40 +01:00
Jordi Boggiano a2bdf72fa4
Fix showing a single package by name in show command, fixes #10623 2022-03-16 15:00:34 +01:00
Jordi Boggiano a7c2bd8aa1
Fix false return value in findPackage, fixes #10622 2022-03-16 14:35:59 +01:00
Jordi Boggiano 20e410f3a2
Fix inconsistent parameter names in inheritance trees 2022-03-16 10:05:07 +01:00
Jordi Boggiano 38813e10f7
Reverting release version changes 2022-03-16 09:25:47 +01:00
Jordi Boggiano 3b150d0ef6
Release 2.3.0-RC1 2022-03-16 09:25:31 +01:00
Jordi Boggiano aad2f86edf
Merge branch '2.2' into main 2022-03-15 22:20:21 +01:00
Jordi Boggiano 78bdd8127b
Reverting release version changes 2022-03-15 22:13:38 +01:00
Jordi Boggiano 07eccf080a
Release 2.2.9 2022-03-15 22:13:37 +01:00
Jordi Boggiano 6b97524b25
Load plugins which modify install path early, fixes #10618 (#10621) 2022-03-15 22:11:19 +01:00
Jordi Boggiano ef5a128973
Fix type error 2022-03-15 15:57:54 +01:00
Svyatoslav Tregubov f863855647
`--patch-only` option for `show` and `outdated` commands (#10589)
Fixes #10503

Co-authored-by: Svyatoslav <tregubov.s@asteq.ru>
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-03-15 15:52:04 +01:00
Yanick Witschi f125fc1d0a
Improve performance of DefaultPolicy (#10585)
Add memoization to selectPreferredPackages
2022-03-15 15:37:14 +01:00
Christopher Hertel 3a1e07f3cc
Remove allow-plugin config on remove (#10615) 2022-03-15 15:30:07 +01:00
Yehuda Katz c3a41b944e
Allow global ignore-platform-req (#10616) 2022-03-15 15:29:25 +01:00
Jordi Boggiano 5122bd42fb
Merge branch '2.2' into main 2022-03-15 13:11:59 +01:00
Jordi Boggiano 7bee425b58
Reverting release version changes 2022-03-15 12:55:21 +01:00
Jordi Boggiano 26a587345d
Release 2.2.8 2022-03-15 12:55:20 +01:00
Jordi Boggiano 2d7f1569f3
Allow using self.version with require command, fixes #10593 2022-03-15 12:26:32 +01:00
Jordi Boggiano f31700bf19
Sort packages with the same weight alphabetically to have a completely stable sort not dependent on input order, fixes #10614 2022-03-15 11:35:33 +01:00
Jordi Boggiano d67953266f
Do not read require-dev except for the root package when sorting packages 2022-03-15 11:03:53 +01:00
Jordi Boggiano 890b8fad3d
Ignore phpstan issue 2022-03-15 10:01:23 +01:00
Jordi Boggiano 5b7ea9580e
Update composer/semver to latest 2022-03-15 09:43:22 +01:00
Yanick Witschi ced24da7b0
Fix PoolOptimizer should consider disjunctive MultiConstraints (#10579) 2022-03-12 14:16:38 +01:00
Jordi Boggiano 0a4c0778ab
Propagate decoration state to repo warnings, fixes #10601 2022-03-09 21:00:00 +01:00
bilogic ae23647f07
Create SYMLINKD instead of SYMLINK on Windows host/Linux guest filesystems (#10592)
Co-authored-by: bilogic <bilogic@example.com>
2022-03-09 20:45:19 +01:00
Jordi Boggiano 575fbfb53f
Fix phar build 2022-02-26 14:12:30 +01:00
Jordi Boggiano 18246212db
Upgrade to composer/pcre 2.x 2022-02-26 14:02:11 +01:00
Jordi Boggiano 1734d86907
Merge branch '2.2' into main 2022-02-25 20:54:42 +01:00
Martin Herndl 9715580bc0
Add file agument to archive help (#10574) 2022-02-25 20:47:19 +01:00
Antoine Makdessi 6c0a6e00b3
Fix #10575 (#10576)
Refactor the whole cleanChanges/getLocalChanges code to be more strict with null returns

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-02-25 20:44:10 +01:00
Jordi Boggiano 076925ebef
Merge pull request #10567 from Seldaek/strict_types
Add strict types declares to all files
2022-02-25 14:54:14 +01:00
Jordi Boggiano af995c3038
Merge branch '2.2' into main 2022-02-25 11:13:14 +01:00
Jordi Boggiano fa9a877246
Reverting release version changes 2022-02-25 11:12:28 +01:00
Jordi Boggiano 061d154dfd
Release 2.2.7 2022-02-25 11:12:27 +01:00
Yanick Witschi 8179d1ea33
Early return when a package was already marked to be kept 2022-02-25 10:43:24 +01:00
Jordi Boggiano beb575dd00
Fix more issues, update baseline (2203/106) 2022-02-24 13:24:35 +01:00
Jordi Boggiano 6a466a120a
Enable strict types on all files 2022-02-24 13:24:34 +01:00
Jordi Boggiano 3cdca37e85
Fix strict type issues 2022-02-24 13:24:25 +01:00
Jordi Boggiano b85e0eebc1
Allow 3rd parties to use URL_REGEX 2022-02-24 11:17:46 +01:00
Jordi Boggiano 0db443ba5f
Add visibility to all consts, fixes #10550 2022-02-23 14:28:04 +01:00
Jordi Boggiano 89ce53250e
Final type additions 2022-02-23 12:54:07 +01:00
Jordi Boggiano 7abc8da7d3
Add more types 2022-02-23 11:37:32 +01:00
Jordi Boggiano e52071a92c
Revert some return types for symfony/flex compatibility 2022-02-22 20:36:49 +01:00
Jordi Boggiano 225b4d7c27
Add some more return types 2022-02-22 19:29:40 +01:00
Jordi Boggiano 6da38f83a0
Add parameter types to all the things 2022-02-22 16:48:53 +01:00
Jordi Boggiano c9baeda95b
Merge pull request #10547 from Seldaek/add_returns
Add native return types where possible
2022-02-21 13:57:32 +01:00
Alexander Schranz 1321bfca36
Add return types to closures (#9) 2022-02-21 13:37:49 +01:00
Yanick Witschi 32da10dc2c
Improve the pool optimizer logging (#10545) 2022-02-19 12:47:35 +01:00
Jordi Boggiano 7b1fc4b2c8
Remove alias::getAliasOf return type as this is not compatible with PHP 7.2/7.3 2022-02-18 20:53:58 +01:00
Jordi Boggiano 84f0f19112
Split Composer into PartialComposer & Composer classes to avoid nullable properties on Composer for non-fully-loaded instances, add types to Composer\Factory 2022-02-18 14:45:08 +01:00
Jordi Boggiano eda9014bef
Add return types to all code which is not being extended by open source packages 2022-02-18 14:32:38 +01:00
Jordi Boggiano a16ed3d0ed
Add return types to private/internal methods 2022-02-18 11:22:01 +01:00
Jordi Boggiano abdc6893a6
Add void types where no return statement is present 2022-02-18 10:38:54 +01:00
Jordi Boggiano 32852304d0
Make use of some new PHP features 2022-02-18 10:20:20 +01:00
Jordi Boggiano 86fb8d4412
Fix CS 2022-02-18 08:50:11 +01:00
Jordi Boggiano 2e40cdf2dc
Clean up properties that belong in PackageDiscoveryTrait 2022-02-18 08:26:59 +01:00
Jordi Boggiano 40de07569d
Merge branch '2.2' into main 2022-02-16 16:05:05 +01:00
Jordi Boggiano 2a2440c2a1
Fix handling of virtual packages when searching for packages or when looking up the preferred version (init & require command), refs #10489 2022-02-16 15:44:43 +01:00
Jordi Boggiano 8b5254688c
Drop early package name validation if a version is provided to require/init command, fixes #10489 2022-02-16 15:13:21 +01:00
sasezaki 0c4cefaaa1
Introduce phpstan-type about autoload array type to be DRY (#10516) 2022-02-16 14:34:10 +01:00
Jordi Boggiano 63b5f2737b
Merge branch '2.2' into main 2022-02-16 13:44:40 +01:00
Jordi Boggiano 53810b0cfb
Fix return type 2022-02-16 13:30:54 +01:00
Jordi Boggiano 5c98a2cf8e
Add phpstan-symfony to get type info about console InputInterface, fix many errors (#10476)
Extract common init/require commands functionality into PackageDiscoveryTrait
Extract some helper methods into BaseCommand for better types
2022-02-16 13:24:57 +01:00
Jordi Boggiano 28ec4fa7b0
Fix handling of invalid emails 2022-02-16 13:24:15 +01:00
Jordi Boggiano f1ebc1d2b6
Fix init author support to make email optional, fixes #10538 2022-02-16 13:08:54 +01:00
Jordi Boggiano 6ea5b84bd9
Fix licenses command summary to count all licenses of a package 2022-02-16 12:26:49 +01:00
Marko H. Tamminen 8756f54da0
Handle missing license when showing license summary (#10537)
Fixes the issue of license summary command aborting when a package is
missing license information.
2022-02-16 12:17:49 +01:00
Stephan 3eb12efae5
VcsRepositories: handle initialize with invalid repository URL (#10525) 2022-02-16 09:37:36 +01:00
Jordi Boggiano 45218092b4
Merge branch '2.2' into main 2022-02-15 16:52:03 +01:00
Jordi Boggiano f808e4907c
Fix handling for non-lowercased enum keyword, fixes #10521 2022-02-15 16:41:06 +01:00
Jordi Boggiano eee8816bc3
Fix allow-plugins:false handling, fixes #10530 2022-02-15 16:14:06 +01:00
Stephan 23b0a3819b
ComposerRepository: fix array_keys(): Argument #1 () must be of type array, null given (#10529) 2022-02-09 11:45:10 +01:00
Jordi Boggiano ae68ada127
Merge branch '2.2' into main 2022-02-08 14:55:10 +01:00
Markus Staab eefb4644b0
InstallerInterface: describe `getInstallPath()` to return a absolute path (#10524) 2022-02-08 14:24:59 +01:00
Volodymyr Panivko a0b0ddcd73
Add config option for update reference in path repository (#10488) 2022-02-07 13:54:17 +01:00
Jordi Boggiano 2c318ff09b
Reverting release version changes 2022-02-04 17:00:39 +01:00
Jordi Boggiano ce785a18c0
Release 2.2.6 2022-02-04 17:00:38 +01:00
Jordi Boggiano 3446091027
Merge branch '2.2' into main 2022-02-04 16:31:14 +01:00
Jordi Boggiano d124c13a42
Add hints when the arg of show is not found, fixes #10493 2022-02-04 16:17:02 +01:00
Jordi Boggiano ee36c5e54a
Fix error reporting issues when partial updates cannot update due to a symlinked path repo package, fixes #10451 2022-02-04 15:58:50 +01:00
Jordi Boggiano 8053d794a8
Fix reinstall command not firing pre-install-cmd/post-install-cmd events, fixes #10508 (#10514) 2022-02-04 14:08:07 +01:00
Jordi Boggiano 88171e409d
Remove superfluous arg 2022-02-04 13:04:02 +01:00
Jordi Boggiano 39cb505d69
Fix phpstan warnings 2022-02-04 13:01:48 +01:00
Florian Engelhardt 3d82719b70
Fix package search not urlencoding the input (#10500) 2022-02-04 10:23:10 +01:00
Jordi Boggiano e7c04e3e12
Improve error reporting when a tag was recreated or a commit is missing, fixes #10484 2022-02-04 10:17:49 +01:00
Jordi Boggiano 7c2954d349
Minor BC Break! Rename COMPOSER_BIN_DIR available inside binaries to COMPOSER_RUNTIME_BIN_DIR (#10512)
This was available to non-PHP binaries as env var since Composer 2.2.2, and the rename is needed to fix a regression due to a name clash. 

Fixes #10504
2022-02-04 09:23:00 +01:00
Maximilian Bösing 1704466b74
Add abandoned flag to show/outdated commands package lists (#10485)
To synchronize `abandoned` information with JSON APIs and the `composer.json` information of a package, we should return the following types: `bool|non-empty-string`.
This will either state if a package is abandoned and, if there is a replacement declared, what replacement package should be used instead.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
2022-02-03 21:34:54 +01:00
Jordi Boggiano 62d5f4f295
Fix phpstan errors 2022-02-02 22:18:00 +01:00
Markus Staab 6be6ce7d9f
update composer/pcre to 1.0.1 (#10496) 2022-02-02 21:35:37 +01:00
Jordi Boggiano db8ea45295
Fix enum parsing when the syntax is "enum foo:string {}" without space between name and type, fixes #10498 2022-02-02 17:48:45 +01:00
Jordi Boggiano 2da8d886cc
Make code a bit more robust 2022-02-02 17:24:50 +01:00
Jordi Boggiano 45bbe43aac
Fix case where symlink:true still can downgrade to a copy on windows, refs #10482 2022-02-02 16:59:58 +01:00
Jordi Boggiano 7f1808501a
Merge branch '2.2' into main 2022-01-21 17:35:00 +01:00
Jordi Boggiano e8a1e25e9d
Reverting release version changes 2022-01-21 17:27:55 +01:00
Jordi Boggiano 32435a0a60
Release 2.2.5 2022-01-21 17:27:55 +01:00
Jordi Boggiano 8c0b4ff16b
Also retry for HTTP2 stream errors, fixes #10462 2022-01-21 17:09:54 +01:00
Jordi Boggiano bab974575c
Merge branch '2.2' into main 2022-01-21 16:00:50 +01:00
Stephan 3b4afaa9e3
ArrayLoader/ValidatingArrayLoader: handle non-string values for version/version_normalized (#10470)
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2022-01-21 14:57:28 +01:00
David Buchmann 6b8f1409e4
report error if binary is a directory (#10463)
file_exists is true also for directory and symlink. but later in generateUnixyProxyCode we call `file_get_contents` on the binary, which fails with `file_get_contents(): read of 8192 bytes failed with errno=21 Is a directory` if the binary is a directory.
2022-01-21 14:52:39 +01:00
Jordi Boggiano af6013093f
Ignore phar files in artifact repo, fixes #10406 2022-01-21 13:22:12 +01:00
John Stevenson 0228e5b47d
Clean up properly if self-update fails (#10475) 2022-01-21 12:55:42 +01:00
Jordi Boggiano e3d99cac59
Fix phpstan issues, update baseline and pin PHPStan version in 2.2 branch (#10474) 2022-01-21 12:48:16 +01:00
John Stevenson db64534b26
Fixed bin proxies on PHP < 8 to support stream_seek (#10468) 2022-01-21 10:09:58 +01:00
Nicolas Grekas 6a70161c01
Disable "composer/package-versions-deprecated" by default (#10458) 2022-01-17 15:28:07 +01:00
Jordi Boggiano 6de9cacfd8
Remove unnecessary sprintf 2022-01-13 11:34:20 +01:00
Jordi Boggiano 49541ce3fb
Merge branch '2.2' into main 2022-01-08 12:31:26 +01:00
Jordi Boggiano d76485af74
Reverting release version changes 2022-01-08 12:30:43 +01:00
Jordi Boggiano 8a5ad75194
Release 2.2.4 2022-01-08 12:30:42 +01:00
Dane Powell 93d4c8e531
Fix #10366: Improve messaging when GitHub tokens need SSO authorization (#10432) 2022-01-08 12:03:54 +01:00
Jordi Boggiano 13bd2120e9
Merge branch '2.2' into main 2022-01-07 15:04:08 +01:00
Jordi Boggiano 24b62a1002
Add support for sourcing binaries despite the bin proxy being present, take 2 2022-01-07 15:04:02 +01:00
Jordi Boggiano e2ba625a93
Merge branch '2.2' into main 2022-01-07 14:29:59 +01:00
Jordi Boggiano 6dea58c9f3
Add support for sourcing binaries despite the bin proxy being present
Fixes https://github.com/composer/composer/issues/10389#issuecomment-1007372740
2022-01-07 14:28:53 +01:00
Jordi Boggiano 3d6bf8c98d
Merge branch '2.2' into main 2022-01-07 13:59:04 +01:00
Jordi Boggiano 641ad10a9f
Fix partial update where path repos are being auto-unlocked two levels deep not loading all packages properly, fixes #10431 2022-01-07 13:46:58 +01:00
Jordi Boggiano 3844e05ac1
Merge branch '2.2' into main 2022-01-07 12:59:48 +01:00
Jordi Boggiano 64d39a9655
Fix phpstan error 2022-01-07 12:46:13 +01:00
Jordi Boggiano f1568f1f8f
Merge branch '2.2' into main 2022-01-07 09:30:43 +01:00
Jordi Boggiano 0b436de794
Fix last bit phpstan error 2022-01-07 09:29:35 +01:00
Jordi Boggiano 508ac051ec
Revert "Remove getCode usage as it is not type safe apparently, see https://github.com/phpstan/phpstan-src/pull/795"
This reverts commit 84f8fda0c6.

And other issues fixed by PHPStan 1.3.2
2022-01-07 09:26:37 +01:00
Stephan 9360e2c18a
GitLab: detect repository functionality disabled in Driver (#10440) 2022-01-06 15:06:38 +01:00
Jordi Boggiano 5e4a8a882d
Allow ProcessExecutor to receive commands as arrays, refs #6552 (#10435) 2022-01-06 13:56:12 +01:00
Jordi Boggiano 7d1aa65239
Merge branch '2.2' into main 2022-01-05 16:52:18 +01:00
Jordi Boggiano cb41ad1d4b
Ensure process timeouts are checked also for async processes 2022-01-05 16:49:36 +01:00
Jordi Boggiano 3a27cb2e91
Merge branch '2.2' into main 2022-01-05 15:45:18 +01:00
Jordi Boggiano c2cdc3eb71
Deduplicate code 2022-01-05 15:44:46 +01:00
Jordi Boggiano b96c419ee5
Merge pull request #10430 from Seldaek/add_links
Add links to repo to show/outdated commands package lists
2022-01-05 14:55:33 +01:00
Jordi Boggiano ef2b52ee5b
Make the package name bold in plugin activation warnings 2022-01-05 14:43:30 +01:00
Jordi Boggiano f9d61c0665
Add links to repo to fund/licenses/search commands and add links to docs to config command 2022-01-05 14:39:08 +01:00
Jordi Boggiano 06bb3c9179
Add links to repo to show/outdated commands package lists, fixes #9367 2022-01-04 17:34:27 +01:00
Jordi Boggiano 711f436b24
Use finally to restore error handler after command runs 2022-01-04 16:31:45 +01:00
Jordi Boggiano 99fa6116f9
Merge branch '2.2' into main 2022-01-04 16:31:36 +01:00
Jordi Boggiano 404c58a17f
Merge pull request #10428 from Seldaek/deprecations
Deprecations & more php version cleanups
2022-01-04 16:30:55 +01:00
Jordi Boggiano 8473592eda
Revert "Fix support for .jar binaries, fixes #10426"
This reverts commit fa65804c99.
2022-01-04 16:19:29 +01:00
Jordi Boggiano 0be1e5a279
Merge branch '2.2' into main 2022-01-04 14:58:07 +01:00
Jordi Boggiano fa65804c99
Fix support for .jar binaries, fixes #10426 2022-01-04 14:55:56 +01:00
Jordi Boggiano 06e445ce02
Drop PHP <7.2 and HHVM support from autoload_real, individual autoload files are kept as is for BC 2022-01-04 11:55:36 +01:00
Michael Voříšek 4fdc8b8ee1
dirname(__FILE__) no longer needed 2022-01-04 11:22:13 +01:00
Jordi Boggiano 7e50f37b87
Remove some dead code and deprecate JsonFormatter, JsonFile::JSON_* constants, and TlsHelper 2022-01-04 11:15:33 +01:00
Alexander M. Turek 36da81bec2
Remove obsolete Symfony feature detections (#10425) 2022-01-04 10:41:33 +01:00
Niels Vanpachtenbeke 1c928466a9
Remove code blocks for php <7.2 compatibility (#10417) 2022-01-03 17:35:32 +01:00
Jordi Boggiano 0ece276c7c
Get rid of redundant \Exception catch blocks 2022-01-03 16:32:40 +01:00
Jordi Boggiano 4e6d54b731
Fix all 5.3 $this-in-closure usages 2022-01-03 16:32:39 +01:00
Jordi Boggiano 5805a68645
Fix some todos dropping support for older Symfony releases 2022-01-03 14:51:41 +01:00
Jordi Boggiano 7e27a25070
Get rid of RetutnTypeWillChange where possible, fixes #10014 2022-01-01 15:38:47 +01:00
Jordi Boggiano 0b3adc84da
Fix a few phpstan errors and add a php8+ baseline for the rest 2022-01-01 14:54:24 +01:00
Jordi Boggiano e4e0e0d154
Remove deprecations baseline 2022-01-01 14:54:22 +01:00
Jordi Boggiano ed08c40ab5
Fix phar build 2022-01-01 14:54:22 +01:00
Jordi Boggiano 96486d81cb
Fix many PHPStan issues and update baseline 2022-01-01 14:54:21 +01:00
Jordi Boggiano 32dcb93f24
Update extra files for latest polyfill lib 2022-01-01 14:54:21 +01:00
Jordi Boggiano ffd62795bc
Get rid of all the ->at() mock invocations 2022-01-01 14:54:20 +01:00
Jordi Boggiano 095c36ecf8
Fix some PHPStan errors/.. 2022-01-01 14:54:20 +01:00
Jordi Boggiano bf72afec44
Fix Symfony6 compat 2022-01-01 14:54:19 +01:00
Jordi Boggiano d2ede370be
Bump target version, bump PHP and dependency requirements to PHP 7.2+ 2022-01-01 14:54:18 +01:00
John Stevenson 4829a401d8
Fix symlink resolution in shell proxy (#10412) 2021-12-31 21:56:46 +01:00
Jordi Boggiano d965c26c5c
Reverting release version changes 2021-12-31 12:18:54 +01:00
Jordi Boggiano 3c92ba5cdc
Release 2.2.3 2021-12-31 12:18:53 +01:00
Jason Woods efc7a3f75f
fix: Do not optimise away packages due to a requirement by a locked package that will be uninstalled (#10405)
Fixes #10394

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-12-31 11:49:42 +01:00
Jordi Boggiano 75e4d30151
Fix warnings when some code reuses the phpvfscomposer:// stream wrapper to try and access other files, refs #10387 2021-12-31 10:33:54 +01:00
Jordi Boggiano 2cd16b4578
Suppress errors if realpath fails or is missing 2021-12-30 21:52:57 +01:00
Jordi Boggiano 390260c6a6
Resolve binary realpath to make sure symlinking bin proxies works, refs jakzal/phpqa#336 2021-12-30 21:49:20 +01:00
Jordi Boggiano d1d5d75c5f
Fix detection of PHP files to match also broken ones with leading whitespace or whitespace between shebang and <?php, refs jakzal/phpqa#336 2021-12-30 21:23:29 +01:00
Jordi Boggiano 84f8fda0c6
Remove getCode usage as it is not type safe apparently, see https://github.com/phpstan/phpstan-src/pull/795 2021-12-30 21:06:27 +01:00
Jordi Boggiano 09d1330937
Fix is_file() not working on the phpvfscomposer:// file when filtering phpunit backtraces, refs #10387 2021-12-30 20:49:44 +01:00
Jordi Boggiano 164a769dc6
Avoid returning actual fstat information as it induces modern PHPs in error when the returned file size is bigger than the fstat size, refs #10387 2021-12-30 20:40:55 +01:00
Jordi Boggiano a2a8fa4e7e
Always exclude laminas/laminas-zendframework-bridge:src/autoload.php, fixes #10401 2021-12-30 10:44:36 +01:00
Jordi Boggiano 2a731ef798
Add workaround for PHPUnit process isolation issues for PHPUnit <6.5 as well, fixes #10387 2021-12-30 10:42:35 +01:00
Jordi Boggiano 0a85c3fb01
Reverting release version changes 2021-12-29 14:15:28 +01:00
Jordi Boggiano 2c1887d4f2
Release 2.2.2 2021-12-29 14:15:27 +01:00
Jordi Boggiano 4168ee9b69
Reformat plugin warning slightly, fixes #10381 2021-12-29 13:41:54 +01:00
Shyim 70425900e9
Fix symfony error handler warnings, fixes #10397 (#10404) 2021-12-29 13:30:50 +01:00
Jordi Boggiano a8ed352b31
Add docs for the new bin-dir access and bump runtime-api, refs #10402 2021-12-28 22:04:32 +01:00
Jordi Boggiano 6f5baab77b
Make COMPOSER_BIN_DIR env or _composer_bin_dir global available to binaries, fixes #10389 (#10402) 2021-12-28 21:31:52 +01:00
Jordi Boggiano c1c6698799
Fix phpunit workaround syntax 2021-12-23 13:57:18 +01:00
Jordi Boggiano 7d1ca1f56d
Add workaround for PHPUnit process isolation combined with bin proxies, fixes #10387 2021-12-23 12:38:35 +01:00
Jordi Boggiano 406075891d
Reverting release version changes 2021-12-22 22:21:32 +01:00
Jordi Boggiano bbc265e165
Release 2.2.1 2021-12-22 22:21:31 +01:00
Jordi Boggiano e1bf45aa80
Fix issue parsing php files with unterminated comments found inside backticks, fixes #10385 2021-12-22 21:42:19 +01:00
Jordi Boggiano 226689b90c
Fix plugin autoloading including files autoload rules from the root package, fixes #10382 (#10386) 2021-12-22 16:04:34 +01:00
Jordi Boggiano 25835bb5cd
Reverting release version changes 2021-12-22 11:03:28 +01:00
Jordi Boggiano e174a4c432
Release 2.2.0 2021-12-22 11:03:27 +01:00
Jordi Boggiano 613980b039
Update baseline 2021-12-22 11:00:06 +01:00
Jérôme Tamarelle f0060b7f56
Use web URLs for Gitlab support metadata (#10377) 2021-12-22 10:54:48 +01:00
Jordi Boggiano 54123e4093
Fix autoloader compatibility with older releases of laminas/laminas-zendframework-bridge, refs #10349 2021-12-22 10:49:06 +01:00
Jordi Boggiano 71ab70d847
Disable files autoloading for scripts to avoid untrusted code execution at runtime (#10373) 2021-12-20 14:27:34 +01:00
Jordi Boggiano 8f1b3d21db
Add --no-scripts to all commands and disable plugins/scripts when running self-update (#10371)
* Add --no-scripts as global parameter available to all commands, and handle it by default when creating a Composer instance from Command::getComposer

* Disable scripts/plugins for self-update command, fixes #10351
2021-12-20 14:23:35 +01:00
Jordi Boggiano 24eac88321
Switch the default version in path repo packages to dev-main and add a dev-master alias for BC, fixes #10360 (#10372) 2021-12-20 13:42:11 +01:00
Jordi Boggiano 95e41ae61c
Fix phpstan 2021-12-19 16:12:22 +01:00
Jordi Boggiano d81298239b
Fix display of conflicts when a rule has the conflicter out of order, fixes #10355 2021-12-19 16:07:20 +01:00
Jordi Boggiano 0dbc736eb7
Reverting release version changes 2021-12-08 15:17:19 +01:00
Jordi Boggiano 35bba53ebb
Release 2.2.0-RC1 2021-12-08 15:17:19 +01:00
Jordi Boggiano 4e8f3e85e2
Improve error reporting for repo priorities, refs #10339 2021-12-08 14:01:26 +01:00
Jordi Boggiano cc32ebcabd
Search improvements (#10336)
* Search performance improvements, add SEARCH_VENDOR type, fixes #10326, fixes #10324, fixes #10325

* Add extra optimization path for autocompletion of ^foo/* whereas the vendor is fully known, refs #10320
2021-12-08 11:45:18 +01:00
Jason Woods 8c8d9efd87
Filter impossible packages from the pool (#9620)
Adds a new pass to the PoolOptimizer

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-12-08 11:42:36 +01:00
Jordi Boggiano a3e91b5be6
Add allow-plugins config value (#10314)
Fixes #5659

- Automatically switch off plugins by default in July 2022
- reword hash into object in schema

Co-authored-by: Nils Adermann <naderman@naderman.de>
2021-12-07 23:00:48 +01:00
Jordi Boggiano a4a89f1508
Update archive format docs, refs #10087 2021-12-07 15:56:35 +01:00
Jordi Boggiano ca5d5b40ee
Fix platform package description for replacer/provider and packages which are not really loaded in general 2021-12-07 13:24:09 +01:00
Jordi Boggiano e30a6b0b9b
Add support for ignoring the upper bound of platform requirements using "name+" notation 2021-12-07 13:24:08 +01:00
Jordi Boggiano 24ce1eddbd
Add composer/pcre dependency and use it everywhere instead of preg_* 2021-12-07 12:37:19 +01:00
Tizian Schmidlin 4f789a5f6d
Add "use-parent-dir" config to configure prompt when no composer.json is present in current dir (#10307)
Fixes #10299

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-12-04 15:00:28 +01:00
Jordi Boggiano 1cfdaf43f1
Fix new file being leftover if require in new dir fails to resolve requirements 2021-12-04 14:56:32 +01:00
Jordi Boggiano b42a897ebe
Fix var name 2021-12-04 13:41:16 +01:00
Wataru Kurashima 10f8edb816
fix typo (#10331) 2021-12-04 07:48:28 +01:00
Jordi Boggiano 128a2648fb
Optimize name only search with preg_grep, refs #10326 2021-12-03 14:54:17 +01:00
Jordi Boggiano 7c8267f57c
Cache root packages.json, refs #10326 2021-12-03 14:49:41 +01:00
Helmut Hummel 483eac1c2f
Install full binaries on Windows by default (#10327)
A bug was introduced in #10137 that leads
to the situation that by default .bat binaries
are not installed on Windows any more.

Check the correct variable to install .bat
files on Windows by default again.
2021-12-03 11:16:58 +01:00
Stephan f5ffedfe60
Fix VcsDrivers initialization of tags and branches, and VcsRepository swallowing exceptions (#10319)
* Drivers: avoid early initialize of tags and branches

* VcsRepository: do not continue if fetching root information fails because of unexpected exceptions

Also rethrow 5XX exception in addition to select 4XX exceptions
2021-11-30 14:33:38 +01:00
Jordi Boggiano 8a36c88cac
Get rid of $binPath global in bin proxies 2021-11-29 09:39:13 +01:00
Helmut Hummel ace8a1776c
Add composer platform package with exact Composer version (#10313)
Co-authored-by: Lars Strojny <lars.strojny@internations.org>
Co-authored-by: Nils Adermann <naderman@naderman.de>
2021-11-27 14:26:57 +01:00
Shalvah 7a3d2b8157
Better hint for missing extensions (#10283) 2021-11-26 10:39:07 +01:00
Nils Adermann 645e5245dd
Error message grammar fix 2021-11-26 10:09:02 +01:00
Helmut Hummel 0b9e1da4fc
Allow recursively call composerRequire (#10312)
Fixes: #10311
Related: #10065
2021-11-25 20:50:26 +01:00
Jordi Boggiano a6fc1ab663
Fix feedback 2021-11-25 15:18:24 +01:00
Jordi Boggiano 4352f23962
Fix implementation & tweak test 2021-11-25 15:06:00 +01:00
Jordi Boggiano bd4ba36fa9
Prevent auto-unlocked path repo packages from also unlocking their transitive deps when -w/-W is used 2021-11-25 15:05:09 +01:00
Jordi Boggiano d86049565d
Deactivate plugins before recreating a new composer instance and loading new plugins in require/remove commands, fixes #9962 2021-11-25 15:03:23 +01:00
Jordi Boggiano 91548d178b
Add support for setting platform packages to false to disable them (#10308)
Fixes #9664
2021-11-25 14:46:25 +01:00
Jordi Boggiano 2c1ff41f8f
Fix phpstan 2021-11-25 12:37:51 +01:00
Jordi Boggiano 032db5bc01
Fix tests 2021-11-25 12:33:59 +01:00
Jordi Boggiano deaec7c0ac
Report validation error if a package replaces and conflicts against the same name, fixes #9845 2021-11-25 10:21:37 +01:00
Jordi Boggiano c15eba3fe3
Turn naming errors into hard failures in validating array loader 2021-11-25 10:21:37 +01:00
Helmut Hummel f12a5b8214
Expose path to autoload in a global var for binaries (#10137)
Always create proxy files for package binaries,
to avoid not working binaries in case the package
was installed from a path repository and is itself linked

If the binary is a PHP script, a global variable is now exposed,
which holds the path to the vendor/autoload.php file.
This variable can the be used in the binaries to include this file
without guessing where the path to the vendor folder might be.

Additionally it is now checked on binary creation whether
the reference binary has a shebang and if not, generates
a much simple proxy code, because the stream wrapper code,
that is required for PHP <8 to omit the shebang from the output,
can be skipped.

Fixes: #10119

Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-11-25 09:53:03 +01:00
Jordi Boggiano 126f95a8d7
Get rid of gitignore/hgignore handling (fixes #7358), Add support for -export-ignore (fixes #9153) 2021-11-24 22:56:51 +01:00
Jordi Boggiano cc3b53bc2e
Also mark @putenv and @php deprecated/forbidden as script names to avoid clashes 2021-11-24 22:30:57 +01:00
Jordi Boggiano 1b5b5c48bf
Bump plugin api version, fixes #10082 2021-11-24 16:35:58 +01:00
Jordi Boggiano 7e3626362e
Add support for warnings/infos keys to report more complex information to diverse Composer versions 2021-11-24 16:00:57 +01:00
Yehuda Katz ebf4cbdc69
Add COMPOSER_NO_DEV environment variable to set the --no-dev flag (#10262) 2021-11-24 11:32:19 +01:00
Rafael Dohms 78583ab678
Support ignore-platform-reqs in `composer outdated` (#10293)
This allows users to also find libraries that require major platform
changes to unlock updates.
It addresses #10291.
2021-11-23 17:16:58 +01:00
Jordi Boggiano bac7b826f2
Revert "To be reverted: Disable pool optimizer by default, run solver twice and compare outputs if user opts into optimizer"
Enables pool optimizer by default

This reverts commit c06be086a6.
2021-11-23 17:05:10 +01:00
Jordi Boggiano bbc442b0ad
Undo changes to providers, only unlock replacers when unlocking a given name 2021-11-23 16:11:44 +01:00
Jordi Boggiano 3242de2438
Backport tests from #9538 and fix everything 2021-11-23 13:07:19 +01:00
Jordi Boggiano 13b7527fca
Fix unlocking of replacers when a replaced package is unlocked in partial updates 2021-11-23 13:00:28 +01:00
Stephan 63b5cbe000
GitDownloader: add option for single use git clone to avoid --dissociate when cloning from local copy (#10288) 2021-11-17 19:53:10 +01:00
Jordi Boggiano 7fc9000834
Also retry for SSL connection failures, refs #10124 2021-11-17 11:02:43 +01:00
Jordi Boggiano f509c41280
Upgrade PHPStan to 1.0 (#10253)
Co-authored-by: Martin Herndl <martin@herndl.org>
2021-11-14 20:42:24 +01:00
Jordi Boggiano 61b50cb7ec
Remove hack from ComposerRepository, fixes #9297 2021-11-13 13:25:25 +01:00
Jordi Boggiano 65765a148a
Explicitly deprecate misuse of the link setters to enforce the fact they expect maps (#10281) 2021-11-12 21:38:08 +01:00
Nicolas Grekas 0662fa2662
Fix loading files for plugins/scripts (#10279) 2021-11-12 09:44:34 +01:00
Jordi Boggiano 410771af36
Merge pull request #10274 from func0der/add_sorting_to_archiving
Add name sorting to ArchivableFilesFinder.
2021-11-12 09:03:53 +01:00
Jordi Boggiano c06be086a6
To be reverted: Disable pool optimizer by default, run solver twice and compare outputs if user opts into optimizer 2021-11-11 16:30:39 +01:00
Jordi Boggiano ce2a40b259
List identical/compatible removed versions in problem output as if they had not been removed 2021-11-11 16:13:25 +01:00
Yanick Witschi 34183f49f9
Implemented PoolOptimizer 2021-11-11 16:13:24 +01:00
Martin Herndl 7eca450d9b
Add wildcard support to ignore-platform-req, fixes #10045 (#10083) 2021-11-11 15:56:38 +01:00
Stephan 44c5b6cde6
Config: add source option for command to show where a config value is loaded from (#10129) 2021-11-11 15:17:58 +01:00
Stephan 012556daee
VcsRepository: limit type of versionTransportExceptions (#10275) 2021-11-11 12:24:47 +01:00
Martin Herndl 3013674c92
Refactor ignore platform reqs checks (#10079)
Introduces a `PlatformRequirementFilter` with methods that help to decide if a requirement is ignored or not as discussed in #10045 but without changing behaviour.
2021-11-11 12:24:12 +01:00
Jordi Boggiano 68847ed609
Tweak bitbucket driver to uniformize regexes 2021-11-11 12:21:26 +01:00
Jordi Boggiano ba1814f306
Added retry behavior for certain http status and curl error codes (#10162) 2021-11-10 22:12:42 +01:00
Jordi Boggiano cda7863f20
Get rid of the abstract BitbucketDriver class, fixes #9856 2021-11-10 22:08:30 +01:00
Raphael de Almeida 150acc5559
Removed HgBitbucketDriver support (#10248) 2021-11-10 21:58:03 +01:00
Jordi Boggiano ba5b7a5a9f
Add missing docblocks 2021-11-10 21:54:40 +01:00
Nicolas Grekas 8553c6d978
Add loading of files autoload section for plugins and Composer runtime autoloaders (#10065) 2021-11-10 21:37:33 +01:00
func0der 41a0c660b1 [add_sorting_to_archiving] Do not use natural sorting, cause of minimum required versions. 2021-11-10 15:39:50 +01:00
func0der a48afcd790 [add_sorting_to_archiving] Add natural sorting to ArchivableFilesFinder. 2021-11-10 15:23:39 +01:00
Jordi Boggiano b09a39f9c8
Error out on recursive links in validating loader and ignore them in regular loader 2021-11-10 11:10:52 +01:00
Jordi Boggiano bd4d624cc7
Read first from $_SERVER and $_ENV before using getenv (#10218) 2021-11-09 16:31:27 +01:00
Jordi Boggiano 85f3bb070d
Add abandoned flag in search command output 2021-11-09 16:04:21 +01:00
Jordi Boggiano 9e762a4f9a
Bump target to 2.2-dev 2021-11-09 16:04:08 +01:00
Jordi Boggiano 28c34128ee
Fix php proxies to resolve __FILE__ and __DIR__ using realpath on PHP <8, fixes #10261 2021-11-08 15:03:05 +01:00
Jordi Boggiano 3bb78fd1ee
Make new phar filename random to avoid possible concurrency issues, refs #10252 2021-11-08 11:45:07 +01:00
Jordi Boggiano 6a7264fc2d
Trigger autoloading of a few classes before executing self-update command, fixes #10252 2021-11-08 11:45:06 +01:00
Matthias Pigulla 4c9e567c39
Provide different URL options to encourage users to create low-privilege GitHub tokens (#10256) 2021-11-08 10:52:22 +01:00
Jordi Boggiano 9f433aba76
Fix 9999999-dev showing on composer show when no branch alias is defined for the default branch, fixes #10260 2021-11-08 10:43:25 +01:00
Martin Herndl 5b47fa1896
Add back abandoned key in repository search results (#10259) 2021-11-08 10:27:45 +01:00
Markus Staab d7154c2a72
Fix GithubActionError on php 8.1 (#10250) 2021-11-02 14:39:04 +01:00
Markus Staab 6b62f98d3c
GithubActionError: escape more special chars (#10243) 2021-11-02 11:43:34 +01:00
Jordi Boggiano 90087b4fb3
Fix handling of php bin proxies combined with declare() on php <8, fixes #10246 (#10249) 2021-11-02 11:36:31 +01:00
Jordi Boggiano 3f243d37c3
Add temporary metadata for download size tracking 2021-10-29 22:19:38 +02:00
Jordi Boggiano 44b69ba77f
Upgrade php-cs-fixer to 3.x and fix CS 2021-10-27 16:21:45 +02:00
Jordi Boggiano c65d09dff7
Fix @inheritDoc annotations 2021-10-27 16:18:53 +02:00
Martin Herndl 2992e8651a
Add types to `Util` tests (#10228) 2021-10-27 16:18:46 +02:00
Samuel Felipe 3ccb54832b
PHPStan level 6 in src/Composer/Command (#10214) 2021-10-27 14:18:16 +02:00
Jordi Boggiano df6c2ce1db
Simplify php bin proxies further 2021-10-27 11:24:50 +02:00
Jordi Boggiano e1dbd65aff
Fix bin proxies to use output buffering instead of the eval hack, as the __FILE__ and __DIR__ replacement is not safe when done in strings/nowdocs/.. 2021-10-27 11:16:34 +02:00
Joseph Wynn 44a2aa9be4
Log when COMPOSER_AUTH environment variable is malformed, but do not throw an error. Fixes #10208. (#10209)
Co-authored-by: Joseph Wynn <joseph@wildlyinaccurate.com>
2021-10-27 09:40:20 +02:00
Cédric Anne a7686e82f0
Filter candidates requiring an unknown platform package; fixes #10167 (#10184) 2021-10-26 17:24:17 +02:00
Martin Herndl 3645d3042c
Add types to root namespace (#10213) 2021-10-26 12:40:52 +02:00
Martin Herndl f267b01852
Use single docblock for parameter types (#10212) 2021-10-25 21:42:03 +02:00
Martin Herndl bd8b39fe01
Add types to `Package` (#10210) 2021-10-25 13:45:09 +02:00
Jordi Boggiano 0e96f363e1
Remove redundancy in package type 2021-10-25 13:13:01 +02:00
Martin Herndl 13d433fad0
Add types to `Package/Loader` (#10206) 2021-10-25 13:08:05 +02:00
Anatoly Pashin b1a96a3141
PHPStan level 6 in src/Composer/Repository (#10197) 2021-10-25 12:58:31 +02:00
Martin Herndl 3fa7a6cb51
Add types to `Package/Version` (#10199) 2021-10-25 11:09:52 +02:00
Martin Herndl aa4c2ab63c
Add types to `Plugin` (#10194) 2021-10-25 11:02:54 +02:00
Paolo Rossi a921d9b233
Reaching phpstan level 6 in EventDispatcher Exception and Installer folders (#10192) 2021-10-25 10:44:29 +02:00
Martin Herndl fa4d4e20e9
Add types to `Downloader` (#10193) 2021-10-25 10:25:39 +02:00
pistej b99e21259c
phpstan level 6 in src/Composer/Package/Comparer (refs #10159) (#10196) 2021-10-20 22:20:33 +02:00
Martin Herndl db9e9a544e
Add types to `Package/Dumper` (#10198) 2021-10-20 22:19:53 +02:00
pistej dbd0ccaad8
phpstan level 6 in src/Composer/Package/Archiver (refs #10159) (#10195) 2021-10-20 21:54:38 +02:00
Nils Adermann cbc686c16a
Merge pull request #10185 from Seldaek/remove_unknown_rule_type
Remove unknown Rule type
2021-10-19 22:00:10 +02:00
Martin Herndl 995bf5a932
Add types to `Util` namespace, refs #10159 (#10190) 2021-10-19 14:35:37 +02:00
Stephan 261d93aacf
ComposerRepository: handle packages.json with null value for package (#10189) 2021-10-19 13:14:12 +02:00
Jordi Boggiano 37ce8969a4
Use real type hint instead of annotation 2021-10-19 13:11:04 +02:00
Martin Herndl f0cc9aeb01
Remove scalar parameter type declaration (#10186)
`string` can only be used in parameters starting from PHP 7.0.
2021-10-19 13:10:21 +02:00
Paolo Rossi 3add01a40b
PHPStan level 6 in src/Composer/Config (refs #10159) (#10182) 2021-10-18 23:51:43 +02:00
Jordi Boggiano 87f25e6df6
Specify parseAutoloads more narrowly, refs #10179 2021-10-18 23:49:57 +02:00
immeëmosol be25cf1d7a
Reaching phpstan level 6 in Composer/Autoload (refs #10159) (#10179)
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-10-18 23:40:22 +02:00
Jordi Boggiano 57e417b53a
Minor cleanup 2021-10-18 23:10:11 +02:00
Jordi Boggiano 75a8677e8a
Remove unknown Rule type 2021-10-18 23:05:31 +02:00
Paolo Rossi 6e04991489
Reaching phpstan level 6 in Composer/Console (refs #10159) (#10183) 2021-10-18 22:40:50 +02:00
Jordi Boggiano 7e1f4882af
Reorder some code 2021-10-18 22:37:40 +02:00
immeëmosol 50d738eeee
Reaching phpstan level 6 in Composer/DependencyResolver (refs #10159) (#10178) 2021-10-18 22:33:37 +02:00
Jordi Boggiano 04ab74bbef
Avoid checking for hhvm in a loop, refs #10170 2021-10-18 10:51:16 +02:00
Jordi Boggiano a6f1e803b1
Use more BasePackage instead of PackageInterface 2021-10-17 14:43:34 +02:00
Jordi Boggiano b209816056
Type annotations 2021-10-17 14:31:48 +02:00
pistej 98f1465610
Phpstan level 6 in Composer/Plaform and Composer/Script (#10159) (#10170) 2021-10-17 13:52:01 +02:00
Jordi Boggiano f25398f52c
Fix 2021-10-17 10:49:57 +02:00
Jordi Boggiano e137046558
Type annotations 2021-10-17 10:31:09 +02:00
Fabien Villepinte 9fde6ec88b
PHPStan level 6 in src/Composer/Json (#10172) 2021-10-16 22:42:32 +02:00
pistej 04c157bf32
Reaching phpstan level 6 in Composer/SelfUpdate (#10169) 2021-10-16 22:35:31 +02:00
Jordi Boggiano 7d88de7d0b
Fix syntax 2021-10-16 11:17:44 +02:00
Jordi Boggiano 9599eb613b
Type annotations 2021-10-16 11:14:10 +02:00
immeëmosol 6d5f6eb090
Reaching phpstan level 6 in Composer\IO (#10166) 2021-10-16 10:36:02 +02:00
Jordi Boggiano c3c6969cf5
Type annotations 2021-10-16 10:25:12 +02:00
Jordi Boggiano 626370d444
Suggest COMPOSER_DISABLE_NETWORK if a possibly-offline state is detected (#10163)
Co-authored-by: Nils Adermann <naderman@naderman.de>
2021-10-16 09:47:04 +02:00
Jordi Boggiano 97fe881af4
Add some docblocks 2021-10-15 16:36:28 +02:00
Jordi Boggiano 915f3f4fb6
Make sure that if cleanup happens before install completes on zip updates, we do not report bogus errors, fixes #9804 2021-10-15 10:42:44 +02:00
Jordi Boggiano 0868245589
Rename master branch to main 2021-10-14 16:21:47 +02:00
Jordi Boggiano 4a7abd79c9
Fix 5.3 syntax 😒 2021-10-14 15:44:14 +02:00
Jordi Boggiano 759a3a9300
Fix require reverting changes even though dependency resolution succeeded if when something fails afterwards, closes #10118 2021-10-14 15:41:44 +02:00
Jordi Boggiano f776f52474
Hint composer require alternatives if dep resolution fails, fixes #10136 2021-10-14 15:12:29 +02:00
Jordi Boggiano 260ac0011c
Add constants to describe error codes from Installer::run 2021-10-14 15:12:06 +02:00
Jordi Boggiano 79727d35c4
Avoid warning due to invalid cache dir during init, wait for first use, fixes #10125 2021-10-14 10:24:08 +02:00
Jordi Boggiano f587237c55
Fix diagnose output when libz is not present for curl, refs #10153 2021-10-13 22:39:47 +02:00
Jordi Boggiano 2828ce59cf
Merge branch '1.10' 2021-10-13 22:12:54 +02:00
JDev4U 11810e3c2d
Fix help command not working with plugin commands, fixes #10147 (#10150)
- Add 'help' in the list of commands that need plugin command ($mayNeedPluginCommand)
- Remove `'global' !== $commandName` because $mayNeedPluginCommand encure that $commandName is one of `false`, `empty`, `list` or `help` (so never 'global')

Co-authored-by: Duret Joel <joel.duret@neo-soft.fr>
2021-10-13 22:03:31 +02:00
Jordi Boggiano aa4de3b13d
Fix CurlDownloader requesting gzip encoding even though unsupported, fixes #10153 2021-10-13 20:24:28 +02:00
John Stevenson 906442117c Carriage returns are ignored by cmd 2021-10-13 14:54:37 +01:00
Jordi Boggiano d1c8a4d1b4
Lots of typing improvements 2021-10-12 22:47:23 +02:00
Jordi Boggiano 1e3f7cfcba
Fix handling of json error responses 2021-10-12 17:32:59 +02:00
John Stevenson 8f974fe741 Improve Windows escaping 2021-10-10 16:24:49 +01:00
Jordi Boggiano cb1e248258
Fix type annotation 2021-10-05 09:47:20 +02:00
Jordi Boggiano 18e24976c1
Merge branch '1.10' 2021-10-05 09:43:00 +02:00
Jordi Boggiano ca5e2f8d50
Fix escaping issues on Windows which could lead to command injection, fixes GHSA-frqg-7g38-6gcf 2021-10-05 09:39:50 +02:00
Jordi Boggiano b3eebeb3b9
Merge pull request from GHSA-frqg-7g38-6gcf 2021-10-05 09:28:42 +02:00
Jordi Boggiano 532c6e7933
Fix show --all showing only the installed version if the package is installed, fixes #10095 2021-10-02 22:15:34 +02:00
Jordi Boggiano a7963b7fed
Fix ComposerRepository handling of offline state to allow resolution as long as everything is present in the cache, fixes #10116 2021-10-02 21:22:25 +02:00
Stephan edccad4e05
VcsRepository: do not continue when receiving 429 rate limit exception (#10132) 2021-10-02 20:40:49 +02:00
Sergii Dolgushev 90d112d98a
Mask Git credentials in the error message (#10115) 2021-10-02 20:30:21 +02:00
Jordi Boggiano d64d1adf61
Rewrite php file cleaning step to be less regex intensive and support extreme cases better, fixes #10106 (#10107) 2021-10-02 14:39:39 +02:00
Vitaly Baev 7305d50277
Changed GitLab's applications URL (#10104) 2021-09-15 13:16:51 +02:00
Jordi Boggiano d6a8b0252d
Fix phpdoc 2021-09-15 11:31:58 +02:00
Jordi Boggiano 8cd2d0e541
Fix scanning of classmaps in files containing invalid Unicode, fixes #10102 2021-09-15 11:31:43 +02:00
SvenRtbg 5c4e1cedb2
Add ability check for ZipArchive (#10092)
ZipArchive::setExternalAttributesName() is only available when libzip 0.11.2 or higher is present. 
This is not the case with at least SUSE SLES 12, so a simple PHP version check will not work here.
2021-09-13 22:30:02 +02:00
Jordi Boggiano 8657f80ddd
Fix error output to be clearer when running composer.phar without phar extension, fixes #10097 2021-09-13 21:46:28 +02:00
Jordi Boggiano 6179f33c74
Fix docker being seen as WSL when run inside WSL, fixes #10094 2021-09-13 21:11:55 +02:00
Jordi Boggiano 4bcd860b65
Add more type annotations 2021-09-05 17:34:12 +02:00
Jordi Boggiano dd49db6f08
Make sure that names with wildcards which are not preceded by dots are also seen as package names and not version constraints 2021-09-05 09:56:28 +02:00
Jordi Boggiano 6c9aecf4e7
Ignore all symfony deprecations 2021-09-03 21:39:06 +02:00
Alexander Schranz 99c6b450e6
Check for returned link header in GithubDriver 2021-09-02 19:17:17 +02:00
Jordi Boggiano 01d734125c
Add more type info 2021-08-30 17:45:35 +02:00
Jordi Boggiano 0761474599
Add type info to many properties/methods 2021-08-30 14:46:49 +02:00
Jordi Boggiano fc04c86f82
Add type info to Autoload namespace 2021-08-30 13:58:31 +02:00
Jordi Boggiano 61fba697a0
Fix validating array loader handling of invalid target branch datatype 2021-08-30 13:43:33 +02:00
Jordi Boggiano 024f0eda53
Add a bunch of type info to Util namespace 2021-08-29 20:07:50 +02:00
Jordi Boggiano 8559279025
Merge pull request #10076 from aschempp/bugfix/package-type-update
Correctly resolve promises when package type changes
2021-08-29 14:16:01 +02:00
Jordi Boggiano b8e461ea61
Make sure /proc/version read does not fail the process ever, closes #10080 2021-08-29 13:10:22 +02:00
Jordi Boggiano 0158436fb4
Fix list command not showing plugin commands, fixes #10075 2021-08-29 13:03:45 +02:00
Jordi Boggiano 922ba01d07
Merge pull request #10072 from jrfnl/feature/10067-fix-classmap-regression
ClassMapGenerator: stabilize the heredoc/nowdoc stripping
2021-08-29 12:26:20 +02:00
Jordi Boggiano d8054d1d2f
Add more possessive quantifiers, unicode flag and support for more post-heredoc syntax, fix test file syntax being invalid 2021-08-29 12:23:02 +02:00
Andreas Schempp 0bed60e631 Correctly resolve promises when package type changes 2021-08-25 22:35:34 +02:00
Jordi Boggiano 73c109c561
Make sure that names with wildcards which are not preceded by dots are also seen as package names and not version constraints 2021-08-25 21:09:49 +02:00
Jordi Boggiano 6ab1b6a7d2
Regex simplifications 2021-08-23 22:18:03 +02:00
Jordi Boggiano f6c446bdd7
Tweak to allow matching delimiter within the string 2021-08-23 13:14:15 +02:00
Jordi Boggiano c44be998ab
Undo new stripping code and fix regex 2021-08-23 13:14:02 +02:00
powellblyth 5e75017166
Just some comments with 'it's' that should have been 'its' (#10071)
Co-authored-by: Toby Powell-Blyth <tobypowell-blyth@elasticstage.com>
2021-08-22 13:41:18 +02:00
jrfnl 40bd4b03ad
ClassMapGenerator: stabilize the heredoc/nowdoc stripping
I've looked into 10067 and have come to the conclusion that using a single regex to strip the heredoc/nowdocs is always going to run into trouble as:
* Either the matching will be too greedy (issue 10067);
* Or the matching will run into backtrace limits for large heredoc/nowdocs.

We cannot solve both within a single regex.

So, I'm proposing a slightly different solution which should support both and should also improve performance for files containing large heredoc/nowdocs.

The `stripHereNowDocs()` function will find a start marker and remember the offset of the start marker.
It will then find the end marker and strip the contents between the two (replace with `null`).
The function will then recurse onto itself until all heredocs/nowdocs in a file have been removed.
2021-08-21 17:45:43 +02:00
Jordi Boggiano d3c176ec69
PHPStan Level 5 (#10070)
* Bump PHPStan to level 5

* Update seld/phar-utils to latest

* Add phpstan-setup / phpstan scripts
2021-08-21 17:41:52 +02:00
Jordi Boggiano b583310476
Allow ircs protocol for support.irc 2021-08-19 16:03:59 +02:00
Jordi Boggiano 74b231a4bc
Fix lib-openssl detection on FreeBSD, fixes #10046 2021-08-19 15:00:08 +02:00
Jordi Boggiano 9727adf63b
Fix init performance when plugin commands are not needed, fixes #10064 2021-08-19 14:37:50 +02:00
Jordi Boggiano a586a753df
Fix all remaining php8.1 test suite deprecations 2021-08-19 13:00:30 +02:00
Jordi Boggiano b77fce8a4f
More deprecation fixes by using ProcessExecutorMock and a couple of PackageInterface type fixes 2021-08-18 23:35:27 +02:00
Jordi Boggiano 6aa2d15868
Introduce ProcessExecutorMock to fix deprecations and amount of mocking pain 2021-08-18 17:17:56 +02:00
Jordi Boggiano c5a02a2b58
Fix return value of ProcessExecutor::getErrorOutput, closes #10054 2021-08-18 14:55:38 +02:00
Jordi Boggiano 052065028f
Merge pull request #10051 from jrfnl/feature/php-8.1-null-to-non-nullable-fix-1
PHP 8.1: prevent a "null to non-nullable" deprecation notice [1]
2021-08-18 14:36:14 +02:00
Jordi Boggiano 3dcc6c1514
Make return value explicit 2021-08-18 14:32:06 +02:00
Jordi Boggiano cfe718fa43
Fix usage of getRequiredPackage, closes #10052 2021-08-18 14:30:09 +02:00
Jordi Boggiano 8ce0ea300e
Fix pear repo preventing self-update from functioning, fixes #10049 2021-08-18 14:23:08 +02:00
Jordi Boggiano 5c201687e5
Fix 7zip issues on windows when mixing forward and backslashes, fixes #10058 2021-08-18 11:55:51 +02:00
Jordi Boggiano 91a1a471db
Fix path repo bug causing symlinks to be left behind when uninstalling, fixes #10023 2021-08-18 11:25:00 +02:00
Jordi Boggiano d465df434c
Make sure diagnose command can run without proc_open, refs #9253 2021-08-18 10:16:20 +02:00
Jordi Boggiano 60fe67086e
Make sure proc_open is not required for basic installs, refs #9253 2021-08-18 10:15:47 +02:00
Jordi Boggiano d6f4111f35
Fix php 5.3 support 2021-08-17 16:59:00 +02:00
Jordi Boggiano 46f2d9de48
Fix php 5.3 support 2021-08-17 16:53:16 +02:00
Jordi Boggiano ddd7920d2a
Fix corrupt archives in cache from getting the installs stuck forever, and make sure it fails only once, fixes #10028 2021-08-17 16:49:36 +02:00
Jordi Boggiano e49f24e355
Switch phar signatures to sha512 2021-08-17 15:58:27 +02:00
jrfnl 609007b072 PHP 8.1: prevent a "null to non-nullable" deprecation notice
Discovered while running the existing unit tests on PHP 8.1.

The default state of the protected `$distUrl` property is "not set" and the property may not be set when the `Package::setSourceDistReferences()` method gets called.

Fixes a total of 9 deprecation notices along the lines of:
```
Deprecation triggered by Composer\Test\DependencyResolver\PoolBuilderTest::testPoolBuilder:
preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 597)
1 src/Composer/Package/Package.php(597): preg_match('...', NULL)
2 src/Composer/DependencyResolver/PoolBuilder.php(360): Composer\Package\Package->setSourceDistReferences('...')
3 src/Composer/DependencyResolver/PoolBuilder.php(338): Composer\DependencyResolver\PoolBuilder->loadPackage(Object(Composer\DependencyResolver\Request), Object(Composer\Package\CompletePackage))
4 src/Composer/DependencyResolver/PoolBuilder.php(195): Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading(Object(Composer\DependencyResolver\Request), Array)
5 src/Composer/Repository/RepositorySet.php(229): Composer\DependencyResolver\PoolBuilder->buildPool(Array, Object(Composer\DependencyResolver\Request))
6 tests/Composer/Test/DependencyResolver/PoolBuilderTest.php(110): Composer\Repository\RepositorySet->createPool(Object(Composer\DependencyResolver\Request), Object(Composer\IO\NullIO))
...
```

Side-note: I'm wondering why `$this->getDistUrl()` is used instead of using the `$distUrl` property. It is a property within the same class after all. Haven't changed it, but did want to raise the question.

Refs:
* https://www.php.net/manual/en/function.preg-match.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
2021-08-12 02:45:29 +02:00
jrfnl 42c6a0d7c5 ClassMapGenerator: fix the regex
By using a look ahead assertion to match "new line - maybe whitespace - marker", the negative performance impact of the `.*` is significantly mitigated and backtracing will be severely limited.

This fixes the bug as reported in 10037.

The bug was discovered due to a PHP 8.1 "passing null to non-nullable" deprecation notice being thrown, but is not a PHP 8.1 bug.

In actual fact, this issue affected all PHP versions and could lead to incomplete classmaps when the code base contained files with huge heredocs/nowdocs.

The regex change (not completely) incidentally also fixes an issue with markers in a heredoc/nowdoc not being correctly handled. This bug could lead to "classes" being added to the class map which aren't actually classes.

Fixes 10037
2021-08-11 22:26:12 +02:00
Stephan c65bd832d6
Url: fix sanitize for new github tokens (#10048) 2021-08-11 13:24:41 +02:00
Juliette c7d11f361c
PHP 8.1: fix more return type deprecation warnings (#10039)
Follow up on 10008 and the various commits made for that.

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:06:47 +02:00
Juliette f5a0dfeb50
PHP 8.1: fix deprecation warnings about incorrect default values (#10036)
* PHP 8.1/Tests: fix some deprecation warnings

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.

Fixes numerous `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.

Ref: https://www.php.net/manual/en/function.preg-split.php

* PHP 8.1/NoProxyPattern: fix deprecation warning

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.

Fixes some `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.

```
Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest:
preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42)
1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1)
2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...')
3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData()
4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct()
5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance()
...
```

Ref: https://www.php.net/manual/en/function.preg-split.php

* PHP 8.1: fix deprecation warnings / http_build_query()

This fixes all relevant calls to the PHP native `http_build_query()` function.
The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`.

A parameter being optional, however, does not automatically make it nullable.

As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice.
In this case, these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice.

Changing the `null` to an empty string fixes this without BC-break.

Fixes a few deprecation warnings found when running the tests.

Refs:
* https://www.php.net/manual/en/function.http-build-query.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

* PHP 8.1: fix deprecation notices / PharData::__construct()

This fixes all relevant calls to the PHP native `PharData::__construct()` method.

The second parameter of this method is the _optional_ `$flags` parameter which expects an `int` of flags to be passed to the `Phar` parent class `RecursiveDirectoryIterator`.
Fixed by passing the default value for the `$flags` parameter as per the `RecursiveDirectoryIterator::__construct()` method.

The third parameter of the method is the _optional_ `$alias` parameter which expects an `string`.
Fixed by passing an empty string.

Fixes various notices along the lines of:
```
Deprecation triggered by Composer\Test\Package\Archiver\ArchiveManagerTest::testArchiveTar:
PharData::__construct(): Passing null to parameter #2 ($flags) of type int is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 55)
1 src/Composer/Package/Archiver/PharArchiver.php(55): PharData->__construct('...', NULL, NULL, 2)
2 src/Composer/Package/Archiver/ArchiveManager.php(193): Composer\Package\Archiver\PharArchiver->archive('...', '...', '...', Array, false)
3 tests/Composer/Test/Package/Archiver/ArchiveManagerTest.php(65): Composer\Package\Archiver\ArchiveManager->archive(Object(Composer\Package\CompletePackage), '...', '...')
...
```

Refs:
* https://www.php.net/manual/en/phardata.construct.php
* https://www.php.net/manual/en/recursivedirectoryiterator.construct.php

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:05:45 +02:00
Jordi Boggiano 2665f1b282
Fix private property access, fixes #10022 2021-07-28 14:33:47 +02:00
Jordi Boggiano 2fb53232d1
Fix usage on symfony 2.x, fixes #10022 2021-07-28 14:19:19 +02:00
Jordi Boggiano deb4c48bbc
Avoid using an invalid path for InstalledFilesystemRepo in create-project and use an array repo instead, fixes #10020, fixes #10021 2021-07-23 10:09:31 +02:00
Jordi Boggiano 1f4401005c
Allow default_socket_timeout to extend the curl timeout if it is longer than 300s, fixes #10018 2021-07-23 09:51:57 +02:00
GeoSot e07d2a7bef
Respect parent setting, handling exceptions (#10017) 2021-07-22 15:14:15 +02:00
Jordi Boggiano 2f83338d2f
Fix hopefully last php 8.1 deprecation warnings 2021-07-22 13:54:18 +02:00
Jordi Boggiano 24f5e54fbe
Fix only/exclude to avoid matching names as sub-strings of full package names, fixes #10001 2021-07-22 13:47:31 +02:00
Jordi Boggiano 29a52ff463
Register ErrorHandler early to catch deprecation notices while the Application is being initialized 2021-07-22 12:58:14 +02:00
Jordi Boggiano 2be03f0d60
More fixes for php8.1 deprecations 2021-07-22 12:42:01 +02:00
Jordi Boggiano a7efb27338
More php8.1 deprecation fixes, refs #10008 2021-07-22 11:48:30 +02:00
Jordi Boggiano 47cf602f9e
Fix more PHP 8.1 deprecations, refs #10008 2021-07-22 11:30:01 +02:00
Jordi Boggiano 10ae1d7b08
Fix some PHP 8.1 deprecation warnings, fixes #10008 2021-07-21 15:13:24 +02:00
Jordi Boggiano f5a03b950d
Improve error reporting in require command, fixes invalid case of consistency issue, fixes #10006 2021-07-21 14:38:10 +02:00
Ondrej Mirtes 79093d664b Update PHPStan and remove ignore 2021-07-21 10:10:09 +02:00
Ondřej Mirtes 58ced29a2a
Simplify code 2021-07-14 16:36:12 +02:00
Jordi Boggiano be58b36a35
Also look up 7zz on linux/macOS, fixes #9951 2021-07-12 15:50:02 +02:00
Jordi Boggiano b602b19f6d
Fix archive command now that zips are extracted async, refs composer/satis#655 2021-07-12 15:09:59 +02:00
Jordi Boggiano db1d9e75be
Fix support for 7z command fallback on linux/macOS, fixes #9994 2021-07-12 14:49:44 +02:00
Jordi Boggiano bacbd15b6b
Fix open_basedir support regession in bfea0f7d1 2021-07-12 14:34:18 +02:00
Jordi Boggiano 5152eeebdc
Merge pull request #9995 from Seldaek/fix_wsl
Fix UNC/WSL-path issues when running in Windows
2021-07-12 14:07:41 +02:00
Jordi Boggiano 005c55185a
Fix support for writing into UNC paths, and comparing UNC paths correctly in InstalledVersions, fixes #9993 2021-07-12 14:03:00 +02:00
Jordi Boggiano cc81f5bac3
Fix support for UNC paths in normalizePath, refs #9993 2021-07-12 13:36:57 +02:00
Ondřej Mirtes c65890d2d3
DiagnoseCommand - fix PHPDoc (#9991) 2021-07-07 21:52:53 +02:00
Jordi Boggiano 078aaa6968
Make sure the correct name is being output, fixes #9986 2021-06-27 14:45:31 +02:00
Jordi Boggiano a5efbbc94a
Validate schema before writing the file, fixes #9986 2021-06-27 14:45:31 +02:00
Jordi Boggiano 420d9bf21d
Move name validation out of interact, fixes #9986 2021-06-27 14:45:30 +02:00
Jordi Boggiano e87a150f41
Make sure schema issues are always reported correctly, but not in init when Composer is not required, fixes #9986 2021-06-27 14:45:30 +02:00
Jordi Boggiano 6f992a6ea3
Merge pull request #9975 from mitelg/fix-annotation-complete-package-interface
Fix initial values of CompletePackage properties
2021-06-26 23:16:58 +02:00
Jordi Boggiano 5780caf208
Fix link when no composer.json is present, fixes #9966 2021-06-26 23:09:27 +02:00
Michael Telgmann 66fb240e1b
Fix initial values of CompletePackage properties 2021-06-17 08:46:40 +02:00
Jordi Boggiano 9a32bf9709
Bump source version to 2.1.999 2021-06-09 16:44:06 +02:00
Jordi Boggiano bf3713072c
Fix source binaries not being made executable when symlinks cannot be used, fixes #9961 2021-06-09 16:25:16 +02:00
Jordi Boggiano 2d54a27ebc
Fix config support for new bin-compat value, refs #9959 2021-06-09 16:25:16 +02:00
noniagriconomie 65259ac8e0 Add Composer version in about command 2021-06-09 15:13:01 +02:00
Sebastian Blank a9031e40eb
Add "symlink" option for "bin-compat" config (#9959) 2021-06-09 11:33:44 +02:00
Jordi Boggiano 6c1f0cdf24
Handle edge cases too in removeDirectoryPhp to avoid trying to delete symlinks and such, fixes #9955 2021-06-08 21:53:20 +02:00
Jordi Boggiano f61f2c6872
Also free $file just in case 2021-06-08 21:26:41 +02:00
Jordi Boggiano a02802b109
Warn 1.x users when a package is not found that it may be due to our deprecation policy 2021-06-08 21:12:49 +02:00
Jordi Boggiano c668c24599
Fix autoload events not being dispatched when running dump-autoload command, fixes #9954 2021-06-08 15:34:26 +02:00
Jordi Boggiano b01cd459b7
Avoid checking if dir is empty if it does not even exist 2021-06-07 16:41:11 +02:00
Jordi Boggiano 6e851edd70
Add `--dev` to `dump-autoload` command to allow force-dumping dev autoload rules even if dev requirements are not present, fixes #9946 2021-06-07 15:48:37 +02:00
Jordi Boggiano e013b479da
Avoid failing hard if the target empty dir cannot be deleted when extracting archives, fixes #9947 2021-06-07 15:34:03 +02:00
Jordi Boggiano c4f675fe84
Fix virtualbox filesystem issue when installing packages, fixes #9945 2021-06-06 21:11:48 +02:00
Jordi Boggiano 4e4b4f69c9
Revert "Always wait after an unzip completes to try and fix virtualbox issues, refs #9945"
This reverts commit 3556f6efa5.
2021-06-06 21:10:07 +02:00