public-mirrors
/
docker-php-extension-installer
mirror of https://github.com/mlocati/docker-php-extension-installer
1
0
Fork 0
Code

Improving contributors instructions

pull/62/head
Michele Locati 2019-12-17 10:33:20 +01:00
parent 68cd8ce41f
commit 868e5689a8
No known key found for this signature in database
GPG Key ID: 98B7CE2E7234E28B
1 changed files with 32 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
README.md
View File

@ -143,29 +143,39 @@ Some extension has special requirements:
## How to contribute ## How to contribute
- If you want to add support for a new PHP extension: ### Adding support to a new PHP extension?
1. change the `install-php-extensions` script
2. update the `data/supported-extensions` file, adding a new line with the handle of the extension and the list of supported PHP versions
3. if the extension requires ZTS images:
add a new line to the `data/special-requirements` file, with the extension handle followed by a space and `zts`
- If you want to change the list of supported PHP versions for an already supported extension:
1. change the `install-php-extensions` script
2. update the `data/supported-extensions` file, adding the new PHP version to the existing line corresponding to the updated extension
- If you change some code that affects one or more extensions, please add a line with `Test: extension1, extension2` to the message of one of the pull request commits.
Here's an example of a commit message:
```
Improve the GD and ZIP extensions
Test: gd, zip 1. change the `install-php-extensions` script
``` 2. update the `data/supported-extensions` file, adding a new line with the handle of the extension and the list of supported PHP versions
If your pull request contains multiple commits, we'll check the "Test:" message of every commit. 3. if the extension requires ZTS images:
If you want to stop parsing next commits, add `-STOP-` in the "Test:" line, for example: add a new line to the `data/special-requirements` file, with the extension handle followed by a space and `zts`
```
Improve the GD and ZIP extensions
Test: gd, zip, -STOP- ### Changing the supported PHP versions for an already supported PHP extension?
```
1. change the `install-php-extensions` script
2. update the `data/supported-extensions` file, adding the new PHP version to the existing line corresponding to the updated extension
### Improving code for an already supported extension?
If you change some code that affects one or more extensions, please add a line with `Test: extension1, extension2` to the message of one of the pull request commits.
That way, the test jobs will check the extension even if you don't touch the `data/supported-extensions` file.
Here's an example of a commit message:
```
Improve the GD and ZIP extensions
Test: gd, zip
```
If your pull request contains multiple commits, we'll check the "Test:" message of every commit.
If you want to stop parsing next commits, add `-STOP-` in the "Test:" line, for example:
```
Improve the GD and ZIP extensions
Test: gd, zip, -STOP-
```
## Do you want to really say thank you? ## Do you want to really say thank you?