public-mirrors
/
docker-php-extension-installer
mirror of https://github.com/mlocati/docker-php-extension-installer
1
0
Fork 0
Code

Add links to sample pull requests in README.md

pull/65/head
Michele Locati 2019-12-17 11:21:01 +01:00
parent b800b364d2
commit 9d30d8806f
No known key found for this signature in database
GPG Key ID: 98B7CE2E7234E28B
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@ -150,11 +150,15 @@ Some extension has special requirements:
3. if the extension requires ZTS images: 3. if the extension requires ZTS images:
add a new line to the `data/special-requirements` file, with the extension handle followed by a space and `zts` add a new line to the `data/special-requirements` file, with the extension handle followed by a space and `zts`
See [this pull request](https://github.com/mlocati/docker-php-extension-installer/pull/60) for an example.
### Changing the supported PHP versions for an already supported PHP extension? ### Changing the supported PHP versions for an already supported PHP extension?
1. change the `install-php-extensions` script 1. change the `install-php-extensions` script
2. update the `data/supported-extensions` file, adding the new PHP version to the existing line corresponding to the updated extension 2. update the `data/supported-extensions` file, adding the new PHP version to the existing line corresponding to the updated extension
See [this pull request](https://github.com/mlocati/docker-php-extension-installer/pull/62) for an example.
### Improving code for an already supported extension? ### Improving code for an already supported extension?
If you change some code that affects one or more extensions, please add a line with `Test: extension1, extension2` to the message of one of the pull request commits. If you change some code that affects one or more extensions, please add a line with `Test: extension1, extension2` to the message of one of the pull request commits.
@ -177,6 +181,8 @@ Improve the GD and ZIP extensions
Test: gd, zip, -STOP- Test: gd, zip, -STOP-
``` ```
See [this pull request](https://github.com/mlocati/docker-php-extension-installer/pull/43) for an example.
## Do you want to really say thank you? ## Do you want to really say thank you?