public-mirrors
/
innernet
mirror of https://github.com/tonarino/innernet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

server: add comments to get_listener

pull/35/head
Jake McGinty 2021-04-06 13:28:11 +09:00
parent 17f56556ea
commit 2122748727
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/src/main.rs
View File

@ -327,6 +327,12 @@ async fn serve(interface: &str, conf: &ServerConfig) -> Result<(), Error> {
Ok(()) Ok(())
} }
/// This function differs per OS, because different operating systems have
/// opposing characteristics when binding to a specific IP address.
/// On Linux, binding to a specific local IP address does *not* bind it to
/// that IP's interface, allowing for spoofing attacks.
///
/// See https://github.com/tonarino/innernet/issues/26 for more details.
#[cfg(target_os = "linux")] #[cfg(target_os = "linux")]
fn get_listener(addr: SocketAddr, interface: &str) -> Result<TcpListener, Error> { fn get_listener(addr: SocketAddr, interface: &str) -> Result<TcpListener, Error> {
let listener = TcpListener::bind(&addr)?; let listener = TcpListener::bind(&addr)?;
@ -336,6 +342,12 @@ fn get_listener(addr: SocketAddr, interface: &str) -> Result<TcpListener, Error>
Ok(sock.into()) Ok(sock.into())
} }
/// BSD-likes do seem to bind to an interface when binding to an IP,
/// according to the internet, but we may want to explicitly use
/// IP_BOUND_IF in the future regardless. This isn't currently in
/// the socket2 crate however, so we aren't currently using it.
///
/// See https://github.com/tonarino/innernet/issues/26 for more details.
#[cfg(not(target_os = "linux"))] #[cfg(not(target_os = "linux"))]
fn get_listener(addr: SocketAddr, _interface: &str) -> Result<TcpListener, Error> { fn get_listener(addr: SocketAddr, _interface: &str) -> Result<TcpListener, Error> {
let listener = TcpListener::bind(&addr)?; let listener = TcpListener::bind(&addr)?;