From f0de388f1480ac572e48cc8272d524ccc1e4f2ed Mon Sep 17 00:00:00 2001 From: Ryo Kawaguchi Date: Thu, 20 Jun 2024 16:55:55 +0900 Subject: [PATCH] Address review comments --- shared/src/prompts.rs | 4 +++- shared/src/types.rs | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/shared/src/prompts.rs b/shared/src/prompts.rs index 7507d73..830c5a5 100644 --- a/shared/src/prompts.rs +++ b/shared/src/prompts.rs @@ -567,7 +567,9 @@ pub fn ask_endpoint(listen_port: u16) -> Result { publicip::get_any(Preference::Ipv4) } else if Confirm::with_theme(&*THEME) .wait_for_newline(true) - .with_prompt("You do not have a fixed global IP (use the unspecified address)?") + .with_prompt( + "Use an unspecified IP address? (this can occur if you do not have a fixed global IP)", + ) .interact()? { Some(IpAddr::V6(Ipv6Addr::UNSPECIFIED)) diff --git a/shared/src/types.rs b/shared/src/types.rs index c7388b5..d793f6f 100644 --- a/shared/src/types.rs +++ b/shared/src/types.rs @@ -453,6 +453,8 @@ pub struct OverrideEndpointOpts { /// The external endpoint that you'd like the innernet server to broadcast /// to other peers. The IP address may be unspecified, in which case the /// server will try to resolve it based on its most recent connection. + /// The port will still be used even if you decide to use the unspecified + /// IP address. #[clap(short, long)] pub endpoint: Option,