From 45521ea6af6c613c261d5117e0325ace127111d5 Mon Sep 17 00:00:00 2001 From: mertsincan Date: Sun, 31 Mar 2024 05:44:48 +0100 Subject: [PATCH] Theming API: Improve performance --- .../accordiontab/style/AccordionTabStyle.js | 6 +- .../animateonscroll/BaseAnimateOnScroll.js | 5 +- .../style/AnimateOnScrollStyle.js | 6 +- .../style/BadgeDirectiveStyle.js | 2 +- components/lib/base/style/BaseStyle.js | 2 +- .../lib/basecomponent/BaseComponent.vue | 60 ++++++++--------- .../basecomponent/style/BaseComponentStyle.js | 5 +- components/lib/basedirective/BaseDirective.js | 43 +++++++----- components/lib/chart/style/ChartStyle.js | 4 +- components/lib/column/style/ColumnStyle.js | 6 +- .../lib/columngroup/style/ColumnGroupStyle.js | 6 +- components/lib/config/PrimeVue.js | 55 ++++++---------- .../style/DeferredContentStyle.js | 6 +- .../dynamicdialog/style/DynamicDialogStyle.js | 6 +- .../lib/focustrap/style/FocusTrapStyle.js | 6 +- ...putIcoonStyle.d.ts => InputIconStyle.d.ts} | 0 components/lib/portal/style/PortalStyle.js | 6 +- components/lib/ripple/style/RippleStyle.js | 2 +- components/lib/row/style/RowStyle.js | 6 +- .../stepperpanel/style/StepperPanelStyle.js | 6 +- components/lib/styleclass/BaseStyleClass.js | 5 +- .../lib/styleclass/style/StyleClassStyle.js | 6 +- .../lib/tabpanel/style/TabPanelStyle.js | 6 +- components/lib/themes/config/index.js | 65 +++++++++++-------- components/lib/themes/helpers/dt.js | 10 +-- nuxt-vite.config.js | 1 + plugins/app-state.js | 2 + rollup.config.js | 1 + 28 files changed, 193 insertions(+), 141 deletions(-) rename components/lib/inputicon/style/{InputIcoonStyle.d.ts => InputIconStyle.d.ts} (100%) diff --git a/components/lib/accordiontab/style/AccordionTabStyle.js b/components/lib/accordiontab/style/AccordionTabStyle.js index ff8b4c563..b978edc55 100644 --- a/components/lib/accordiontab/style/AccordionTabStyle.js +++ b/components/lib/accordiontab/style/AccordionTabStyle.js @@ -1 +1,5 @@ -export default {}; +import BaseStyle from 'primevue/base/style'; + +export default BaseStyle.extend({ + name: 'accordiontab' +}); diff --git a/components/lib/animateonscroll/BaseAnimateOnScroll.js b/components/lib/animateonscroll/BaseAnimateOnScroll.js index 3f34f4580..55a3bbba9 100644 --- a/components/lib/animateonscroll/BaseAnimateOnScroll.js +++ b/components/lib/animateonscroll/BaseAnimateOnScroll.js @@ -1,5 +1,8 @@ +import AnimateOnScrollStyle from 'primevue/animateonscroll/style'; import BaseDirective from 'primevue/basedirective'; -const BaseAnimateOnScroll = BaseDirective.extend({}); +const BaseAnimateOnScroll = BaseDirective.extend({ + style: AnimateOnScrollStyle +}); export default BaseAnimateOnScroll; diff --git a/components/lib/animateonscroll/style/AnimateOnScrollStyle.js b/components/lib/animateonscroll/style/AnimateOnScrollStyle.js index ff8b4c563..2bb2ef131 100644 --- a/components/lib/animateonscroll/style/AnimateOnScrollStyle.js +++ b/components/lib/animateonscroll/style/AnimateOnScrollStyle.js @@ -1 +1,5 @@ -export default {}; +import BaseStyle from 'primevue/base/style'; + +export default BaseStyle.extend({ + name: 'animateonscroll-directive' +}); diff --git a/components/lib/badgedirective/style/BadgeDirectiveStyle.js b/components/lib/badgedirective/style/BadgeDirectiveStyle.js index a65cc2827..1de903ed8 100644 --- a/components/lib/badgedirective/style/BadgeDirectiveStyle.js +++ b/components/lib/badgedirective/style/BadgeDirectiveStyle.js @@ -5,6 +5,6 @@ const classes = { }; export default BaseStyle.extend({ - name: 'badge', + name: 'badge-directive', classes }); diff --git a/components/lib/base/style/BaseStyle.js b/components/lib/base/style/BaseStyle.js index 0e5cc4770..c62de86c7 100644 --- a/components/lib/base/style/BaseStyle.js +++ b/components/lib/base/style/BaseStyle.js @@ -38,7 +38,7 @@ export default { return this.css ? useStyle(ObjectUtils.minifyCSS(this.css), { name: this.name, ...options }) : {}; }, loadTheme(theme, options = {}) { - return theme ? useStyle(ObjectUtils.minifyCSS(theme), { name: `${this.name}-style`, ...options }) : {}; + return theme ? useStyle(ObjectUtils.minifyCSS(theme), { name: this.name, ...options }) : {}; }, getCommonThemeCSS(params) { return Theme.getCommonCSS(this.name, params); diff --git a/components/lib/basecomponent/BaseComponent.vue b/components/lib/basecomponent/BaseComponent.vue index 1343bcb18..4f3e01603 100644 --- a/components/lib/basecomponent/BaseComponent.vue +++ b/components/lib/basecomponent/BaseComponent.vue @@ -1,6 +1,6 @@