From ee79538fd8da0e9210fcc99fcdeb65a4133b63c2 Mon Sep 17 00:00:00 2001 From: Neil Padfield Date: Fri, 7 Jun 2024 11:58:45 +0100 Subject: [PATCH 1/3] Fix documented default for emptyMessage on several components Fixed the documented default value for the "emptyMessage" property for the Dropdown, Listbox, MultiSelect and TreeSelect components. They were all incorrectly documented as having a default value of "No results found". I changed each one to "No available options". --- doc/common/apidoc/index.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/common/apidoc/index.json b/doc/common/apidoc/index.json index 067441119..4444deb5b 100644 --- a/doc/common/apidoc/index.json +++ b/doc/common/apidoc/index.json @@ -25101,7 +25101,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No results found", + "default": "No available options", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -34532,7 +34532,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No results found", + "default": "No available options", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -38729,7 +38729,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No results found'", + "default": "No available options", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -58396,7 +58396,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No results found", + "default": "No available options", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { From 03b6c34a9372598298a753b23e161e9b6e457031 Mon Sep 17 00:00:00 2001 From: Neil Padfield Date: Fri, 7 Jun 2024 14:42:40 +0100 Subject: [PATCH 2/3] Revert "Fix documented default for emptyMessage on several components" This reverts commit ee79538fd8da0e9210fcc99fcdeb65a4133b63c2. --- doc/common/apidoc/index.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/common/apidoc/index.json b/doc/common/apidoc/index.json index 4444deb5b..067441119 100644 --- a/doc/common/apidoc/index.json +++ b/doc/common/apidoc/index.json @@ -25101,7 +25101,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No available options", + "default": "No results found", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -34532,7 +34532,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No available options", + "default": "No results found", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -38729,7 +38729,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No available options", + "default": "No results found'", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { @@ -58396,7 +58396,7 @@ "optional": true, "readonly": false, "type": "string", - "default": "No available options", + "default": "No results found", "description": "Text to display when there are no options available. Defaults to value from PrimeVue locale configuration." }, { From 7c4f295adb512695621bb29bb61c317e36d221fb Mon Sep 17 00:00:00 2001 From: Neil Padfield Date: Fri, 7 Jun 2024 14:47:40 +0100 Subject: [PATCH 3/3] Fix default values for emptyMessage on several components Fixed the documented default value for the "emptyMessage" property for the Dropdown, Listbox, MultiSelect and TreeSelect components in the components' type definition files. I have changed the values from "No results found" to "No available options". --- components/lib/dropdown/Dropdown.d.ts | 2 +- components/lib/listbox/Listbox.d.ts | 2 +- components/lib/multiselect/MultiSelect.d.ts | 2 +- components/lib/treeselect/TreeSelect.d.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/lib/dropdown/Dropdown.d.ts b/components/lib/dropdown/Dropdown.d.ts index bf77cd77f..07d6aee28 100755 --- a/components/lib/dropdown/Dropdown.d.ts +++ b/components/lib/dropdown/Dropdown.d.ts @@ -484,7 +484,7 @@ export interface DropdownProps { emptyFilterMessage?: string | undefined; /** * Text to display when there are no options available. Defaults to value from PrimeVue locale configuration. - * @defaultValue No results found + * @defaultValue No available options */ emptyMessage?: string | undefined; /** diff --git a/components/lib/listbox/Listbox.d.ts b/components/lib/listbox/Listbox.d.ts index 435f12694..8082a10f2 100755 --- a/components/lib/listbox/Listbox.d.ts +++ b/components/lib/listbox/Listbox.d.ts @@ -333,7 +333,7 @@ export interface ListboxProps { emptyFilterMessage?: string | undefined; /** * Text to display when there are no options available. Defaults to value from PrimeVue locale configuration. - * @defaultValue No results found + * @defaultValue No available options */ emptyMessage?: string | undefined; /** diff --git a/components/lib/multiselect/MultiSelect.d.ts b/components/lib/multiselect/MultiSelect.d.ts index 109c99ec4..f683f444c 100755 --- a/components/lib/multiselect/MultiSelect.d.ts +++ b/components/lib/multiselect/MultiSelect.d.ts @@ -520,7 +520,7 @@ export interface MultiSelectProps { emptyFilterMessage?: string | undefined; /** * Text to display when there are no options available. Defaults to value from PrimeVue locale configuration. - * @defaultValue No results found' + * @defaultValue No available options */ emptyMessage?: string | undefined; /** diff --git a/components/lib/treeselect/TreeSelect.d.ts b/components/lib/treeselect/TreeSelect.d.ts index f0456c019..636cf46c0 100644 --- a/components/lib/treeselect/TreeSelect.d.ts +++ b/components/lib/treeselect/TreeSelect.d.ts @@ -213,7 +213,7 @@ export interface TreeSelectProps { appendTo?: HintedString<'body' | 'self'> | undefined | HTMLElement; /** * Text to display when there are no options available. Defaults to value from PrimeVue locale configuration. - * @defaultValue No results found + * @defaultValue No available options */ emptyMessage?: string | undefined; /**