From 5244372d7268537538b90a30c9e6a820ee0dafd3 Mon Sep 17 00:00:00 2001
From: cagataycivici <cagatay.civici@gmail.com>
Date: Mon, 13 Jan 2020 13:06:08 +0300
Subject: [PATCH] Add type="button"

---
 src/components/carousel/Carousel.vue             |  6 +++---
 src/components/datatable/BodyCell.vue            |  6 +++---
 src/components/datatable/TableBody.vue           |  2 +-
 .../DataViewLayoutOptions.vue                    |  4 ++--
 src/components/dialog/Dialog.vue                 |  2 +-
 src/components/editor/Editor.vue                 | 16 ++++++++--------
 src/components/message/Message.vue               |  2 +-
 src/components/multiselect/MultiSelect.vue       |  2 +-
 src/components/overlaypanel/OverlayPanel.vue     |  2 +-
 src/components/paginator/FirstPageLink.vue       |  2 +-
 src/components/paginator/LastPageLink.vue        |  2 +-
 src/components/paginator/NextPageLink.vue        |  2 +-
 src/components/paginator/PageLinks.vue           |  2 +-
 src/components/paginator/PrevPageLink.vue        |  2 +-
 src/components/sidebar/Sidebar.vue               |  2 +-
 src/components/toast/ToastMessage.vue            |  2 +-
 16 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/src/components/carousel/Carousel.vue b/src/components/carousel/Carousel.vue
index 1f84a61cf..ac2cbc58d 100644
--- a/src/components/carousel/Carousel.vue
+++ b/src/components/carousel/Carousel.vue
@@ -5,7 +5,7 @@
 		</div>
 		<div :class="contentClasses">
 			<div :class="containerClasses">
-				<button :class="['p-carousel-prev p-button', {'p-disabled': backwardIsDisabled}]" :disabled="backwardIsDisabled" @click="navBackward">
+				<button :class="['p-carousel-prev p-button', {'p-disabled': backwardIsDisabled}]" :disabled="backwardIsDisabled" @click="navBackward" type="button">
 					<span :class="['p-carousel-prev-icon pi', {'pi-chevron-left': !isVertical(),'pi-chevron-up': isVertical()}]"></span>
 				</button>
 
@@ -36,13 +36,13 @@
 					</div>
 				</div>
 
-				<button :class="['p-carousel-next p-button', {'p-disabled': forwardIsDisabled}]" :disabled="forwardIsDisabled" @click="navForward">
+				<button :class="['p-carousel-next p-button', {'p-disabled': forwardIsDisabled}]" :disabled="forwardIsDisabled" @click="navForward" type="button">
 					<span :class="['p-carousel-prev-icon pi', {'pi-chevron-right': !isVertical(),'pi-chevron-down': isVertical()}]"></span>
 				</button>
 			</div>
 			<ul :class="dotsContentClasses">
 				<li v-for="(totalDot, i) of totalDots" :key="'p-carousel-dot-' + i" :class="['p-carousel-dot-item', {'p-highlight': d_page === i}]">
-					<button class="p-link" @click="onDotClick($event, i)">
+					<button class="p-link" @click="onDotClick($event, i)" type="button">
 						<span :class="['p-carousel-dot-icon pi', {'pi-circle-on': d_page === i, 'pi-circle-off': !(d_page === i)}]"></span>
 					</button>
 				</li>
diff --git a/src/components/datatable/BodyCell.vue b/src/components/datatable/BodyCell.vue
index fc70191b5..866719879 100644
--- a/src/components/datatable/BodyCell.vue
+++ b/src/components/datatable/BodyCell.vue
@@ -15,13 +15,13 @@
             </button>
         </template>
         <template v-else-if="editMode === 'row' && column.rowEditor">
-            <button class="p-row-editor-init p-link" v-if="!d_editing" @click="onRowEditInit">
+            <button class="p-row-editor-init p-link" v-if="!d_editing" @click="onRowEditInit" type="button">
                 <span class="p-row-editor-init-icon pi pi-fw pi-pencil p-clickable"></span>
             </button>
-            <button class="p-row-editor-save p-link" v-if="d_editing" @click="onRowEditSave">
+            <button class="p-row-editor-save p-link" v-if="d_editing" @click="onRowEditSave" type="button">
                 <span class="p-row-editor-save-icon pi pi-fw pi-check p-clickable"></span>
             </button>
-            <button class="p-row-editor-cancel p-link" v-if="d_editing" @click="onRowEditCancel">
+            <button class="p-row-editor-cancel p-link" v-if="d_editing" @click="onRowEditCancel" type="button">
                 <span class="p-row-editor-cancel-icon pi pi-fw pi-times p-clickable"></span>
             </button>
         </template>
diff --git a/src/components/datatable/TableBody.vue b/src/components/datatable/TableBody.vue
index 3a34ff888..945ab346f 100644
--- a/src/components/datatable/TableBody.vue
+++ b/src/components/datatable/TableBody.vue
@@ -4,7 +4,7 @@
             <template v-for="(rowData, index) of value">
                 <tr class="p-rowgroup-header" v-if="rowGroupMode === 'subheader' && shouldRenderRowGroupHeader(value, rowData, index)" :key="getRowKey(rowData, index) + '_subheader'">
                     <td :colspan="columns.length - 1">
-                        <button class="p-row-toggler p-link" @click="onRowGroupToggle($event, rowData)" v-if="expandableRowGroups">
+                        <button class="p-row-toggler p-link" @click="onRowGroupToggle($event, rowData)" v-if="expandableRowGroups" type="button">
                             <span :class="rowGroupTogglerIcon(rowData)"></span>
                         </button>
                         <DTRowExpansionTemplate :template="templates['groupheader']" :data="rowData" :index="index" />
diff --git a/src/components/dataviewlayoutoptions/DataViewLayoutOptions.vue b/src/components/dataviewlayoutoptions/DataViewLayoutOptions.vue
index dda1514f1..644c4bfc1 100644
--- a/src/components/dataviewlayoutoptions/DataViewLayoutOptions.vue
+++ b/src/components/dataviewlayoutoptions/DataViewLayoutOptions.vue
@@ -1,10 +1,10 @@
 <template>
 	<div class="p-dataview-layout-options p-selectbutton p-buttonset">
-		<button :class="buttonListClass" @click="changeLayout('list')">
+		<button :class="buttonListClass" @click="changeLayout('list')" type="button">
 			<i class="pi pi-bars p-button-icon-left"></i>
 			<span class="p-button-text p-clickable">p-btn</span>
 		</button>
-		<button :class="buttonGridClass" @click="changeLayout('grid')">
+		<button :class="buttonGridClass" @click="changeLayout('grid')" type="button">
 			<i class="pi pi-th-large p-button-icon-left"></i>
 			<span class="p-button-text p-clickable">p-btn</span>
 		</button>
diff --git a/src/components/dialog/Dialog.vue b/src/components/dialog/Dialog.vue
index 80b79757e..81e821795 100644
--- a/src/components/dialog/Dialog.vue
+++ b/src/components/dialog/Dialog.vue
@@ -7,7 +7,7 @@
                         <span :id="ariaLabelledById" class="p-dialog-title" v-if="header" >{{header}}</span>
                     </slot>
                     <div class="p-dialog-titlebar-icons">
-                        <button class="p-dialog-titlebar-icon p-dialog-titlebar-close p-link" @click="close" v-if="closable" :aria-label="ariaCloseLabel">
+                        <button class="p-dialog-titlebar-icon p-dialog-titlebar-close p-link" @click="close" v-if="closable" :aria-label="ariaCloseLabel" type="button">
                             <span class="p-dialog-titlebar-close-icon pi pi-times"></span>
                         </button>
                     </div>
diff --git a/src/components/editor/Editor.vue b/src/components/editor/Editor.vue
index 26b9164d7..8e5c140cd 100644
--- a/src/components/editor/Editor.vue
+++ b/src/components/editor/Editor.vue
@@ -15,17 +15,17 @@
                     </select>
                 </span>
                 <span class="ql-formats">
-                    <button class="ql-bold"></button>
-                    <button class="ql-italic"></button>
-                    <button class="ql-underline"></button>
+                    <button class="ql-bold" type="button"></button>
+                    <button class="ql-italic" type="button"></button>
+                    <button class="ql-underline" type="button"></button>
                 </span>
                 <span class="ql-formats">
                     <select class="ql-color"></select>
                     <select class="ql-background"></select>
                 </span>
                 <span class="ql-formats">
-                    <button class="ql-list" value="ordered"></button>
-                    <button class="ql-list" value="bullet"></button>
+                    <button class="ql-list" value="ordered" type="button"></button>
+                    <button class="ql-list" value="bullet" type="button"></button>
                     <select class="ql-align">
                         <option defaultValue></option>
                         <option value="center"></option>
@@ -34,9 +34,9 @@
                     </select>
                 </span>
                 <span class="ql-formats">
-                    <button class="ql-link"></button>
-                    <button class="ql-image"></button>
-                    <button class="ql-code-block"></button>
+                    <button class="ql-link" type="button"></button>
+                    <button class="ql-image" type="button"></button>
+                    <button class="ql-code-block" type="button"></button>
                 </span>
                 <span class="ql-formats">
                     <button class="ql-clean"></button>
diff --git a/src/components/message/Message.vue b/src/components/message/Message.vue
index 912fbd0d4..211a10b60 100644
--- a/src/components/message/Message.vue
+++ b/src/components/message/Message.vue
@@ -6,7 +6,7 @@
                 <div class="p-messages-text">
                     <slot></slot>
                 </div>
-                <button class="p-messages-close p-link" @click="visible = false" v-if="closable">
+                <button class="p-messages-close p-link" @click="visible = false" v-if="closable" type="button">
                     <i class="p-messages-close-icon pi pi-times"></i>
                 </button>
             </div>
diff --git a/src/components/multiselect/MultiSelect.vue b/src/components/multiselect/MultiSelect.vue
index 779780c2f..522fa3180 100644
--- a/src/components/multiselect/MultiSelect.vue
+++ b/src/components/multiselect/MultiSelect.vue
@@ -29,7 +29,7 @@
                         <input type="text" v-model="filterValue" class="p-multiselect-filter p-component p-inputtext p-component" :placeholder="filterPlaceholder">
                         <span class="p-multiselect-filter-icon pi pi-search"></span>
                     </div>
-                    <button class="p-multiselect-close p-link" @click="onCloseClick">
+                    <button class="p-multiselect-close p-link" @click="onCloseClick" type="button">
                         <span class="p-multiselect-close-icon pi pi-times" />
                     </button>
                 </div>
diff --git a/src/components/overlaypanel/OverlayPanel.vue b/src/components/overlaypanel/OverlayPanel.vue
index 3210bb4bd..b96df127f 100644
--- a/src/components/overlaypanel/OverlayPanel.vue
+++ b/src/components/overlaypanel/OverlayPanel.vue
@@ -4,7 +4,7 @@
             <div class="p-overlaypanel-content">
                 <slot></slot>
             </div>
-            <button class="p-overlaypanel-close p-link" @click="hide" v-if="showCloseIcon" :aria-label="ariaCloseLabel">
+            <button class="p-overlaypanel-close p-link" @click="hide" v-if="showCloseIcon" :aria-label="ariaCloseLabel" type="button">
                 <span class="p-overlaypanel-close-icon pi pi-times"></span>
             </button>
         </div>
diff --git a/src/components/paginator/FirstPageLink.vue b/src/components/paginator/FirstPageLink.vue
index 60b43a4bf..8b457a7da 100644
--- a/src/components/paginator/FirstPageLink.vue
+++ b/src/components/paginator/FirstPageLink.vue
@@ -1,5 +1,5 @@
 <template>
-	<button :class="containerClass" v-on="$listeners">
+	<button :class="containerClass" v-on="$listeners" type="button">
 		<span class="p-paginator-icon pi pi-step-backward"></span>
 	</button>
 </template>
diff --git a/src/components/paginator/LastPageLink.vue b/src/components/paginator/LastPageLink.vue
index 896e3717a..8cc66633e 100644
--- a/src/components/paginator/LastPageLink.vue
+++ b/src/components/paginator/LastPageLink.vue
@@ -1,5 +1,5 @@
 <template>
-	<button :class="containerClass" v-on="$listeners">
+	<button :class="containerClass" v-on="$listeners" type="button">
 		<span class="p-paginator-icon pi pi-step-forward"></span>
 	</button>
 </template>
diff --git a/src/components/paginator/NextPageLink.vue b/src/components/paginator/NextPageLink.vue
index 1fe3a9e42..a00e3594f 100644
--- a/src/components/paginator/NextPageLink.vue
+++ b/src/components/paginator/NextPageLink.vue
@@ -1,5 +1,5 @@
 <template>
-	<button :class="containerClass" v-on="$listeners">
+	<button :class="containerClass" v-on="$listeners" type="button">
 		<span class="p-paginator-icon pi pi-caret-right"></span>
 	</button>
 </template>
diff --git a/src/components/paginator/PageLinks.vue b/src/components/paginator/PageLinks.vue
index 781fe5742..8ca154744 100644
--- a/src/components/paginator/PageLinks.vue
+++ b/src/components/paginator/PageLinks.vue
@@ -1,6 +1,6 @@
 <template>
     <span class="p-paginator-pages">
-        <button v-for="pageLink of value" :key="pageLink" :class="['p-paginator-page p-paginator-element p-link', {'p-highlight': ((pageLink - 1) === page)}]"
+        <button v-for="pageLink of value" :key="pageLink" :class="['p-paginator-page p-paginator-element p-link', {'p-highlight': ((pageLink - 1) === page)}]" type="button"
             @click="onPageLinkClick($event, pageLink)">{{pageLink}}</button>
     </span>
 </template>
diff --git a/src/components/paginator/PrevPageLink.vue b/src/components/paginator/PrevPageLink.vue
index 044e58531..0c219f930 100644
--- a/src/components/paginator/PrevPageLink.vue
+++ b/src/components/paginator/PrevPageLink.vue
@@ -1,5 +1,5 @@
 <template>
-	<button :class="containerClass" v-on="$listeners">
+	<button :class="containerClass" v-on="$listeners" type="button">
 		<span class="p-paginator-icon pi pi-caret-left"></span>
 	</button>
 </template>
diff --git a/src/components/sidebar/Sidebar.vue b/src/components/sidebar/Sidebar.vue
index 3f2917fc3..f97cea89a 100644
--- a/src/components/sidebar/Sidebar.vue
+++ b/src/components/sidebar/Sidebar.vue
@@ -1,7 +1,7 @@
 <template>
     <transition name="p-sidebar" @enter="onEnter" @leave="onLeave">
         <div :class="containerClass" v-if="visible" ref="container" role="complementary" :aria-modal="modal">
-            <button class="p-sidebar-close p-link" @click="hide" :aria-label="ariaCloseLabel" v-if="showCloseIcon">
+            <button class="p-sidebar-close p-link" @click="hide" :aria-label="ariaCloseLabel" v-if="showCloseIcon" type="button">
                 <span class="p-sidebar-close-icon pi pi-times" />
             </button>
             <slot></slot>
diff --git a/src/components/toast/ToastMessage.vue b/src/components/toast/ToastMessage.vue
index a474768b8..b5151ebfb 100644
--- a/src/components/toast/ToastMessage.vue
+++ b/src/components/toast/ToastMessage.vue
@@ -1,7 +1,7 @@
 <template>
     <div :class="containerClass">
         <div class="p-toast-item" role="alert" aria-live="assertive" aria-atomic="true">
-            <button class="p-toast-icon-close p-link" @click="onCloseClick" v-if="message.closable !== false">
+            <button class="p-toast-icon-close p-link" @click="onCloseClick" v-if="message.closable !== false" type="button">
                 <span class="p-toast-icon-close-icon pi pi-times"></span>
             </button>
             <span :class="iconClass"></span>