Merge pull request #5486 from i7slegend/fix/5412-twice-render

Fix #5412 - Twice render if attribute id not defined

components/lib/accordion/Accordion.vue

@@ -73,16 +73,16 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeIndex(newValue) {
             this.d_activeIndex = newValue;
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         isAccordionTab(child) {
             return child.type.name === 'AccordionTab';

components/lib/autocomplete/AutoComplete.vue

@@ -201,8 +201,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         suggestions() {
             if (this.searching) {
@@ -215,7 +218,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.autoUpdateModel();
     },
     updated() {

components/lib/calendar/Calendar.vue

@@ -560,8 +560,11 @@ export default {
         };
     },
     watch: {
-        id: function (newValue) {
+        id: {
-            this.d_id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.d_id = newValue || UniqueComponentId();
+            }
         },
         modelValue(newValue) {
             this.updateCurrentMetaData();
@@ -611,7 +614,6 @@ export default {
         this.updateCurrentMetaData();
     },
     mounted() {
-        this.d_id = this.d_id || UniqueComponentId();
         this.createResponsiveStyle();
         this.bindMatchMediaListener();
 

components/lib/cascadeselect/CascadeSelect.vue

@@ -110,15 +110,17 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         options() {
             this.autoUpdateModel();
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.autoUpdateModel();
     },
     beforeUnmount() {

components/lib/chips/Chips.vue

@@ -76,13 +76,13 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         onWrapperClick() {
             this.$refs.input.focus();

components/lib/contextmenu/ContextMenu.vue

@@ -64,8 +64,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeItemPath(newPath) {
             if (ObjectUtils.isNotEmpty(newPath)) {
@@ -78,8 +81,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.global) {
             this.bindDocumentContextMenuListener();
         }

components/lib/datatable/ColumnFilter.vue

@@ -286,8 +286,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     overlay: null,
@@ -305,8 +308,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.filters && this.filters[this.field]) {
             let fieldFilters = this.filters[this.field];
 

components/lib/dialog/Dialog.vue

@@ -88,8 +88,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     documentKeydownListener: null,
@@ -124,8 +127,6 @@ export default {
         this.mask = null;
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.breakpoints) {
             this.createStyle();
         }

components/lib/dock/DockSub.vue

@@ -106,13 +106,13 @@ export default {
         };
     },
     watch: {
-        menuId(newValue) {
+        menuId: {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler(newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         getItemId(index) {
             return `${this.id}_${index}`;

components/lib/dropdown/Dropdown.vue

@@ -218,8 +218,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         modelValue() {
             this.isModelValueChanged = true;
@@ -229,7 +232,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.autoUpdateModel();
         this.bindLabelClickListener();
     },

components/lib/fieldset/Fieldset.vue

@@ -54,16 +54,16 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         collapsed(newValue) {
             this.d_collapsed = newValue;
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         toggle(event) {
             this.d_collapsed = !this.d_collapsed;

components/lib/galleria/GalleriaContent.vue

@@ -76,15 +76,18 @@ export default {
     emits: ['activeitem-change', 'mask-hide'],
     data() {
         return {
-            id: this.$attrs.id || UniqueComponentId(),
+            id: this.$attrs.id,
             activeIndex: this.$attrs.activeIndex,
             numVisible: this.$attrs.numVisible,
             slideShowActive: false
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         '$attrs.value': function (newVal) {
             if (newVal && newVal.length < this.numVisible) {
@@ -101,9 +104,6 @@ export default {
             newVal ? this.startSlideShow() : this.stopSlideShow();
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     updated() {
         this.$emit('activeitem-change', this.activeIndex);
     },

components/lib/listbox/Listbox.vue

@@ -149,15 +149,17 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         options() {
             this.autoUpdateModel();
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.autoUpdateModel();
     },
     methods: {

components/lib/megamenu/MegaMenu.vue

@@ -86,8 +86,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeItem(newItem) {
             if (ObjectUtils.isNotEmpty(newItem)) {
@@ -100,7 +103,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.bindMatchMediaListener();
     },
     beforeUnmount() {

components/lib/menu/Menu.vue

@@ -72,8 +72,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     target: null,
@@ -83,8 +86,6 @@ export default {
     container: null,
     list: null,
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (!this.popup) {
             this.bindResizeListener();
             this.bindOutsideClickListener();

components/lib/menubar/Menubar.vue

@@ -79,8 +79,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeItemPath(newPath) {
             if (ObjectUtils.isNotEmpty(newPath)) {
@@ -96,7 +99,6 @@ export default {
     container: null,
     menubar: null,
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.bindMatchMediaListener();
     },
     beforeUnmount() {

components/lib/multiselect/MultiSelect.vue

@@ -238,15 +238,17 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         options() {
             this.autoUpdateModel();
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.autoUpdateModel();
     },
     beforeUnmount() {

components/lib/orderlist/OrderList.vue

@@ -105,8 +105,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     beforeUnmount() {
@@ -119,8 +122,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.responsive) {
             this.createStyle();
         }

components/lib/panel/Panel.vue

@@ -58,16 +58,16 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         collapsed(newValue) {
             this.d_collapsed = newValue;
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         toggle(event) {
             this.d_collapsed = !this.d_collapsed;

components/lib/panelmenu/PanelMenu.vue

@@ -73,13 +73,13 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         getItemProp(item, name) {
             return item ? ObjectUtils.getItemValue(item[name]) : undefined;

components/lib/password/Password.vue

@@ -77,8 +77,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     mediumCheckRegExp: null,
@@ -87,7 +90,6 @@ export default {
     scrollHandler: null,
     overlay: null,
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.infoText = this.promptText;
         this.mediumCheckRegExp = new RegExp(this.mediumRegex);
         this.strongCheckRegExp = new RegExp(this.strongRegex);

components/lib/picklist/PickList.vue

@@ -221,8 +221,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         selection(newValue) {
             this.d_selection = newValue;
@@ -244,8 +247,6 @@ export default {
         this.destroyMedia();
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.responsive) {
             this.createStyle();
             this.initMedia();

components/lib/rating/Rating.vue

@@ -68,13 +68,13 @@ export default {
         };
     },
     watch: {
-        '$attrs.name': function (newValue) {
+        '$attrs.name': {
-            this.name = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.name = newValue || UniqueComponentId();
+            }
         }
     },
-    mounted() {
-        this.name = this.name || UniqueComponentId();
-    },
     methods: {
         getPTOptions(key, value) {
             return this.ptm(key, {

components/lib/scrollpanel/ScrollPanel.vue

@@ -69,13 +69,14 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.$el.offsetParent) {
             this.initialize();
         }

components/lib/speeddial/SpeedDial.vue

@@ -78,16 +78,17 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         visible(newValue) {
             this.d_visible = newValue;
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         if (this.type !== 'linear') {
             const button = DomHandler.findSingle(this.container, '[data-pc-name="button"]');
             const firstItem = DomHandler.findSingle(this.list, '[data-pc-section="menuitem"]');

components/lib/splitbutton/SplitButton.vue

@@ -78,13 +78,14 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
-
         this.$watch('$refs.menu.visible', (newValue) => {
             this.isExpanded = newValue;
         });

components/lib/stepper/Stepper.vue

@@ -154,16 +154,16 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeStep(newValue) {
             this.d_activeStep = newValue;
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     methods: {
         isStep(child) {
             return child.type.name === 'StepperPanel';

components/lib/tabview/TabView.vue

@@ -113,8 +113,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeIndex(newValue) {
             this.d_activeIndex = newValue;
@@ -123,7 +126,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.updateInkBar();
         this.scrollable && this.updateButtonState();
     },

components/lib/tieredmenu/TieredMenu.vue

@@ -71,8 +71,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         activeItemPath(newPath) {
             if (!this.popup) {
@@ -86,9 +89,6 @@ export default {
             }
         }
     },
-    mounted() {
-        this.id = this.id || UniqueComponentId();
-    },
     beforeUnmount() {
         this.unbindOutsideClickListener();
         this.unbindResizeListener();

components/lib/treeselect/TreeSelect.vue

@@ -128,8 +128,11 @@ export default {
         };
     },
     watch: {
-        '$attrs.id': function (newValue) {
+        '$attrs.id': {
-            this.id = newValue || UniqueComponentId();
+            immediate: true,
+            handler: function (newValue) {
+                this.id = newValue || UniqueComponentId();
+            }
         },
         modelValue: {
             handler: function () {
@@ -166,7 +169,6 @@ export default {
         }
     },
     mounted() {
-        this.id = this.id || UniqueComponentId();
         this.updateTreeState();
     },
     methods: {