From 5b37215d759c76e1af47608663faf0d5cd3fe076 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=A5=E6=B5=A9?=
 <37316281+yanhao98@users.noreply.github.com>
Date: Fri, 13 Dec 2024 00:05:17 +0800
Subject: [PATCH] fix(DynamicDialog): delay instance removal until after hide
 animation

Before this fix, the dialog instance was removed immediately on hide,
which could cause issues with the closing animation. Now the instance
is properly removed after the animation completes in the after-hide event.
---
 packages/primevue/src/dynamicdialog/DynamicDialog.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/primevue/src/dynamicdialog/DynamicDialog.vue b/packages/primevue/src/dynamicdialog/DynamicDialog.vue
index 18b26c8fe..dc3af3a7e 100644
--- a/packages/primevue/src/dynamicdialog/DynamicDialog.vue
+++ b/packages/primevue/src/dynamicdialog/DynamicDialog.vue
@@ -1,6 +1,6 @@
 <template>
     <template v-for="(instance, key) in instanceMap" :key="key">
-        <DDialog v-model:visible="instance.visible" :_instance="instance" v-bind="instance.options.props" @hide="onDialogHide(instance)" @after-hide="onDialogAfterHide">
+        <DDialog v-model:visible="instance.visible" :_instance="instance" v-bind="instance.options.props" @hide="onDialogHide(instance)" @after-hide="onDialogAfterHide(instance)">
             <template v-if="instance.options.templates && instance.options.templates.header" #header>
                 <component v-for="(header, index) in getTemplateItems(instance.options.templates.header)" :is="header" :key="index + '_header'" v-bind="instance.options.emits"></component>
             </template>
@@ -61,11 +61,11 @@ export default {
     methods: {
         onDialogHide(instance) {
             !this.currentInstance && instance.options.onClose && instance.options.onClose({ type: 'dialog-close' });
-            delete this.instanceMap[instance.key];
         },
-        onDialogAfterHide() {
+        onDialogAfterHide(instance) {
             this.currentInstance && delete this.currentInstance;
             this.currentInstance = null;
+            delete this.instanceMap[instance.key];
         },
         getTemplateItems(template) {
             return Array.isArray(template) ? template : [template];