From 6b84e29b963c27289336d6788dd2ff5c58f79e9d Mon Sep 17 00:00:00 2001
From: Cagatay Civici <cagatay.civici@gmail.com>
Date: Thu, 9 May 2024 21:49:49 +0300
Subject: [PATCH] Tokens for Chip

---
 components/lib/chip/style/ChipStyle.js   | 33 ++++++++++++------------
 components/lib/themes/aura/chip/index.js | 20 ++++++++++++++
 components/lib/themes/lara/chip/index.js | 20 ++++++++++++++
 3 files changed, 57 insertions(+), 16 deletions(-)

diff --git a/components/lib/chip/style/ChipStyle.js b/components/lib/chip/style/ChipStyle.js
index 50d95d3de..1b344b19b 100644
--- a/components/lib/chip/style/ChipStyle.js
+++ b/components/lib/chip/style/ChipStyle.js
@@ -6,37 +6,38 @@ const theme = ({ dt }) => `
     align-items: center;
     background: ${dt('chip.background')};
     color: ${dt('chip.color')};
-    border-radius: 16px;
-    padding: 0.5rem 0.75rem;
-}
-
-.p-chip-icon {
-    margin-right: 0.5rem;
+    border-radius: ${dt('chip.border.radius')};
+    padding: ${dt('chip.padding.y')} ${dt('chip.padding.x')};
+    gap: ${dt('chip.gap')};
 }
 
 .p-chip-image {
     border-radius: 50%;
-    width: 2rem;
-    height: 2rem;
-    margin-left: -0.5rem;
-    margin-right: 0.5rem;
+    width: ${dt('chip.image.width')};
+    height: ${dt('chip.image.height')};
+    margin-left: calc(-1 * ${dt('chip.padding.y')});
 }
 
 .p-chip:has(.p-chip-remove-icon) {
-    padding-right: 0.5rem;
+    padding-right: ${dt('chip.padding.y')};
+}
+
+.p-chip:has(.p-chip-image) {
+    padding-top: calc(${dt('chip.padding.y')} / 2);
+    padding-bottom: calc(${dt('chip.padding.y')} / 2);
 }
 
 .p-chip-remove-icon {
     cursor: pointer;
-    margin-left: 0.375rem;
-    border-radius: 6px;
-    transition: outline-color ${dt('transition.duration')};
+    border-radius: ${dt('chip.remove.icon.border.radius')};
+    transition: outline-color ${dt('transition.duration')}, box-shadow-color ${dt('transition.duration')};
     outline-color: transparent;
 }
 
 .p-chip-remove-icon:focus-visible {
-    outline: ${dt('focus.ring.width')} ${dt('focus.ring.style')} ${dt('focus.ring.color')};
-    outline-offset: ${dt('focus.ring.offset')};
+    box-shadow: ${dt('chip.remove.icon.focus.ring.shadow')};
+    outline: ${dt('chip.remove.icon.focus.ring.width')} ${dt('chip.remove.icon.focus.ring.style')} ${dt('chip.remove.icon.focus.ring.color')};
+    outline-offset: ${dt('chip.remove.icon.focus.ring.offset')};
 }
 `;
 
diff --git a/components/lib/themes/aura/chip/index.js b/components/lib/themes/aura/chip/index.js
index dc105c981..cc3090312 100644
--- a/components/lib/themes/aura/chip/index.js
+++ b/components/lib/themes/aura/chip/index.js
@@ -1,4 +1,24 @@
 export default {
+    root: {
+        borderRadius: '16px',
+        paddingX: '0.75rem',
+        paddingY: '0.5rem',
+        gap: '0.5rem'
+    },
+    image: {
+        width: '2rem',
+        height: '2rem'
+    },
+    removeIcon: {
+        borderRadius: '{content.border.radius}',
+        focusRing: {
+            width: '{focus.ring.width}',
+            style: '{focus.ring.style}',
+            color: '{focus.ring.color}',
+            offset: '{focus.ring.offset}',
+            shadow: '{form.field.focus.ring.shadow}'
+        }
+    },
     colorScheme: {
         light: {
             root: {
diff --git a/components/lib/themes/lara/chip/index.js b/components/lib/themes/lara/chip/index.js
index dc105c981..a1c179449 100644
--- a/components/lib/themes/lara/chip/index.js
+++ b/components/lib/themes/lara/chip/index.js
@@ -1,4 +1,24 @@
 export default {
+    root: {
+        borderRadius: '16px',
+        paddingX: '0.875rem',
+        paddingY: '0.625rem',
+        gap: '0.5rem'
+    },
+    image: {
+        width: '2rem',
+        height: '2rem'
+    },
+    removeIcon: {
+        borderRadius: '{content.border.radius}',
+        focusRing: {
+            width: '{focus.ring.width}',
+            style: '{focus.ring.style}',
+            color: '{focus.ring.color}',
+            offset: '{focus.ring.offset}',
+            shadow: '{focus.ring.shadow}'
+        }
+    },
     colorScheme: {
         light: {
             root: {