From 7e3f17c4a32f61c8fc5cce5ba28e4f8843603542 Mon Sep 17 00:00:00 2001 From: thomaswan Date: Wed, 15 Sep 2021 19:21:33 +0800 Subject: [PATCH 1/3] SpeedDial hideOnClickOutside not working this.bindDocumentClickListener() is called in beforeMount without case checking. update code to check props hideOnClickOutside before bind listener. --- src/components/speeddial/SpeedDial.vue | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/components/speeddial/SpeedDial.vue b/src/components/speeddial/SpeedDial.vue index 92362272d..55ac48eb0 100644 --- a/src/components/speeddial/SpeedDial.vue +++ b/src/components/speeddial/SpeedDial.vue @@ -103,14 +103,12 @@ export default { this.list.style.setProperty('--item-diff-y', `${hDiff / 2}px`); } } - + }, + beforeMount() { if (this.hideOnClickOutside) { this.bindDocumentClickListener(); } }, - beforeMount() { - this.bindDocumentClickListener(); - }, methods: { onItemClick(e, item) { if (item.command) { From 887b635a92d004c3c734a534e07e07ae9e15900e Mon Sep 17 00:00:00 2001 From: thomaswan Date: Wed, 15 Sep 2021 19:41:13 +0800 Subject: [PATCH 2/3] Update SpeedDial.vue --- src/components/speeddial/SpeedDial.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/speeddial/SpeedDial.vue b/src/components/speeddial/SpeedDial.vue index 55ac48eb0..1b4034c79 100644 --- a/src/components/speeddial/SpeedDial.vue +++ b/src/components/speeddial/SpeedDial.vue @@ -103,12 +103,13 @@ export default { this.list.style.setProperty('--item-diff-y', `${hDiff / 2}px`); } } - }, - beforeMount() { if (this.hideOnClickOutside) { this.bindDocumentClickListener(); } }, + beforeMount() { + this.unbindDocumentClickListener(); + }, methods: { onItemClick(e, item) { if (item.command) { From 8e0e80d04e30d3087c1ef923b83d5d7d51488bda Mon Sep 17 00:00:00 2001 From: thomaswan Date: Wed, 15 Sep 2021 19:42:47 +0800 Subject: [PATCH 3/3] Update SpeedDial.vue --- src/components/speeddial/SpeedDial.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/speeddial/SpeedDial.vue b/src/components/speeddial/SpeedDial.vue index 1b4034c79..33d58578a 100644 --- a/src/components/speeddial/SpeedDial.vue +++ b/src/components/speeddial/SpeedDial.vue @@ -103,6 +103,7 @@ export default { this.list.style.setProperty('--item-diff-y', `${hDiff / 2}px`); } } + if (this.hideOnClickOutside) { this.bindDocumentClickListener(); }