From 3d3d65c2b49097d1a4924d6d31558639eeb80936 Mon Sep 17 00:00:00 2001
From: mertsincan <sincan.mert@gmail.com>
Date: Wed, 24 Jan 2024 12:30:47 +0000
Subject: [PATCH 1/2] Refactor #5141

---
 components/lib/dropdown/BaseDropdown.vue       |  2 +-
 components/lib/dropdown/Dropdown.d.ts          |  8 ++++----
 components/lib/dropdown/Dropdown.vue           |  4 ++--
 components/lib/dropdown/style/DropdownStyle.js |  2 +-
 doc/dropdown/{TickDoc.vue => CheckmarkDoc.vue} | 10 +++++-----
 pages/dropdown/index.vue                       |  8 ++++----
 6 files changed, 17 insertions(+), 17 deletions(-)
 rename doc/dropdown/{TickDoc.vue => CheckmarkDoc.vue} (80%)

diff --git a/components/lib/dropdown/BaseDropdown.vue b/components/lib/dropdown/BaseDropdown.vue
index 3d3681f39..5e2a541b0 100644
--- a/components/lib/dropdown/BaseDropdown.vue
+++ b/components/lib/dropdown/BaseDropdown.vue
@@ -134,7 +134,7 @@ export default {
             type: Boolean,
             default: true
         },
-        showTick: {
+        checkmark: {
             type: Boolean,
             default: false
         },
diff --git a/components/lib/dropdown/Dropdown.d.ts b/components/lib/dropdown/Dropdown.d.ts
index 19140bb16..1f1fba8cb 100755
--- a/components/lib/dropdown/Dropdown.d.ts
+++ b/components/lib/dropdown/Dropdown.d.ts
@@ -152,9 +152,9 @@ export interface DropdownPassThroughOptions<T = any> {
      */
     itemLabel?: DropdownPassThroughOptionType<T>;
     /**
-     * Used to pass attributes to the tick icon's DOM element.
+     * Used to pass attributes to the check icon's DOM element.
      */
-    tickIcon?: DropdownPassThroughOptionType<T>;
+    checkIcon?: DropdownPassThroughOptionType<T>;
     /**
      * Used to pass attributes to the bank icon's DOM element.
      */
@@ -440,10 +440,10 @@ export interface DropdownProps {
      */
     highlightOnSelect?: boolean | undefined;
     /**
-     *  Whether the selected option will be shown with a tick.
+     *  Whether the selected option will be shown with a check mark.
      *  @defaultValue false
      */
-    showTick?: boolean | undefined;
+    checkmark?: boolean | undefined;
     /**
      * Text to be displayed in hidden accessible field when filtering returns any results. Defaults to value from PrimeVue locale configuration.
      * @defaultValue '{0} results are available'
diff --git a/components/lib/dropdown/Dropdown.vue b/components/lib/dropdown/Dropdown.vue
index 9088d1c14..719ba3679 100755
--- a/components/lib/dropdown/Dropdown.vue
+++ b/components/lib/dropdown/Dropdown.vue
@@ -129,8 +129,8 @@
                                             :data-p-disabled="isOptionDisabled(option)"
                                             v-bind="getPTItemOptions(option, getItemOptions, i, 'item')"
                                         >
-                                            <template v-if="showTick">
-                                                <CheckIcon v-if="isSelected(option)" :class="cx('tickIcon')" v-bind="ptm('tickIcon')" />
+                                            <template v-if="checkmark">
+                                                <CheckIcon v-if="isSelected(option)" :class="cx('checkIcon')" v-bind="ptm('checkIcon')" />
                                                 <BlankIcon v-else :class="cx('blankIcon')" v-bind="ptm('blankIcon')" />
                                             </template>
                                             <slot name="option" :option="option" :index="getOptionIndex(i, getItemOptions)">
diff --git a/components/lib/dropdown/style/DropdownStyle.js b/components/lib/dropdown/style/DropdownStyle.js
index 60da6d0d4..ddcbb1504 100644
--- a/components/lib/dropdown/style/DropdownStyle.js
+++ b/components/lib/dropdown/style/DropdownStyle.js
@@ -146,7 +146,7 @@ const classes = {
         }
     ],
     itemLabel: 'p-dropdown-item-label',
-    tickIcon: 'p-dropdown-tick-icon',
+    checkIcon: 'p-dropdown-check-icon',
     blankIcon: 'p-dropdown-blank-icon',
     emptyMessage: 'p-dropdown-empty-message'
 };
diff --git a/doc/dropdown/TickDoc.vue b/doc/dropdown/CheckmarkDoc.vue
similarity index 80%
rename from doc/dropdown/TickDoc.vue
rename to doc/dropdown/CheckmarkDoc.vue
index e35e594d7..324a21128 100644
--- a/doc/dropdown/TickDoc.vue
+++ b/doc/dropdown/CheckmarkDoc.vue
@@ -1,9 +1,9 @@
 <template>
     <DocSectionText v-bind="$attrs">
-        <p>An alternative way to highlight the selected option is displaying a tick instead.</p>
+        <p>An alternative way to highlight the selected option is displaying a checkmark instead.</p>
     </DocSectionText>
     <div class="card flex justify-content-center">
-        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" showTick :highlightOnSelect="false" class="w-full md:w-14rem" />
+        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" checkmark :highlightOnSelect="false" class="w-full md:w-14rem" />
     </div>
     <DocSectionCode :code="code" />
 </template>
@@ -22,12 +22,12 @@ export default {
             ],
             code: {
                 basic: `
-<Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" showTick :highlightOnSelect="false" class="w-full md:w-14rem" />
+<Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" checkmark :highlightOnSelect="false" class="w-full md:w-14rem" />
 `,
                 options: `
 <template>
     <div class="card flex justify-content-center">
-        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" showTick :highlightOnSelect="false" class="w-full md:w-14rem" />
+        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" checkmark :highlightOnSelect="false" class="w-full md:w-14rem" />
     </div>
 </template>
 
@@ -51,7 +51,7 @@ export default {
                 composition: `
 <template>
     <div class="card flex justify-content-center">
-        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" showTick :highlightOnSelect="false" class="w-full md:w-14rem" />
+        <Dropdown v-model="selectedCity" :options="cities" optionLabel="name" placeholder="Select a City" checkmark :highlightOnSelect="false" class="w-full md:w-14rem" />
     </div>
 </template>
 
diff --git a/pages/dropdown/index.vue b/pages/dropdown/index.vue
index fcf76c9d2..e0a2c2dc6 100755
--- a/pages/dropdown/index.vue
+++ b/pages/dropdown/index.vue
@@ -13,6 +13,7 @@
 <script>
 import AccessibilityDoc from '@/doc/dropdown/AccessibilityDoc.vue';
 import BasicDoc from '@/doc/dropdown/BasicDoc.vue';
+import CheckmarkDoc from '@/doc/dropdown/CheckmarkDoc.vue';
 import ClearIconDoc from '@/doc/dropdown/ClearIconDoc.vue';
 import DisabledDoc from '@/doc/dropdown/DisabledDoc.vue';
 import EditableDoc from '@/doc/dropdown/EditableDoc.vue';
@@ -24,7 +25,6 @@ import InvalidDoc from '@/doc/dropdown/InvalidDoc.vue';
 import LazyVirtualScrollDoc from '@/doc/dropdown/LazyVirtualScrollDoc.vue';
 import LoadingStateDoc from '@/doc/dropdown/LoadingStateDoc.vue';
 import TemplateDoc from '@/doc/dropdown/TemplateDoc.vue';
-import TickDoc from '@/doc/dropdown/TickDoc.vue';
 import VirtualScrollDoc from '@/doc/dropdown/VirtualScrollDoc.vue';
 import PTComponent from '@/doc/dropdown/pt/index.vue';
 import ThemingDoc from '@/doc/dropdown/theming/index.vue';
@@ -44,9 +44,9 @@ export default {
                     component: BasicDoc
                 },
                 {
-                    id: 'tick',
-                    label: 'Tick',
-                    component: TickDoc
+                    id: 'checkmark',
+                    label: 'Checkmark',
+                    component: CheckmarkDoc
                 },
                 {
                     id: 'editable',

From 2a07cd713098531f86f618d56851489f2ae51d4f Mon Sep 17 00:00:00 2001
From: mertsincan <sincan.mert@gmail.com>
Date: Wed, 24 Jan 2024 12:31:25 +0000
Subject: [PATCH 2/2] Update AppConfigurator.vue

---
 layouts/AppConfigurator.vue | 2 --
 1 file changed, 2 deletions(-)

diff --git a/layouts/AppConfigurator.vue b/layouts/AppConfigurator.vue
index 141282233..1710d0c54 100755
--- a/layouts/AppConfigurator.vue
+++ b/layouts/AppConfigurator.vue
@@ -454,8 +454,6 @@ export default {
             this.primaryFocusRing = value;
             let root = document.documentElement;
 
-            console.log('x');
-
             if (value) {
                 if (this.$appState.darkTheme) root.style.setProperty('--p-focus-ring-color', 'var(--primary-500)');
                 else root.style.setProperty('--p-focus-ring-color', 'var(--primary-500)');