From bc29c589f42a6654f2f3914e6443d3f72cb047c7 Mon Sep 17 00:00:00 2001 From: tugcekucukoglu Date: Mon, 13 May 2024 12:39:13 +0300 Subject: [PATCH 1/3] SpeedDial hydration fixes --- components/lib/speeddial/SpeedDial.vue | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/components/lib/speeddial/SpeedDial.vue b/components/lib/speeddial/SpeedDial.vue index 2ac7381c7..f194ba0c0 100644 --- a/components/lib/speeddial/SpeedDial.vue +++ b/components/lib/speeddial/SpeedDial.vue @@ -72,6 +72,9 @@ import Tooltip from 'primevue/tooltip'; import { DomHandler, UniqueComponentId } from 'primevue/utils'; import BaseSpeedDial from './BaseSpeedDial.vue'; +// Set fix value for SSR. +const Math_PI = 3.14159265358979; + export default { name: 'SpeedDial', extends: BaseSpeedDial, @@ -362,7 +365,7 @@ export default { const radius = this.radius || length * 20; if (type === 'circle') { - const step = (2 * Math.PI) / length; + const step = (2 * Math_PI) / length; return { left: `calc(${radius * Math.cos(step * index)}px + ${$dt('item.diff.x', '0px').variable})`, @@ -370,7 +373,7 @@ export default { }; } else if (type === 'semi-circle') { const direction = this.direction; - const step = Math.PI / (length - 1); + const step = Math_PI / (length - 1); const x = `calc(${radius * Math.cos(step * index)}px + ${$dt('item.diff.x', '0px').variable})`; const y = `calc(${radius * Math.sin(step * index)}px + ${$dt('item.diff.y', '0px').variable})`; @@ -385,7 +388,7 @@ export default { } } else if (type === 'quarter-circle') { const direction = this.direction; - const step = Math.PI / (2 * (length - 1)); + const step = Math_PI / (2 * (length - 1)); const x = `calc(${radius * Math.cos(step * index)}px + ${$dt('item.diff.x', '0px').variable})`; const y = `calc(${radius * Math.sin(step * index)}px + ${$dt('item.diff.y', '0px').variable})`; From 5e9fe6c22e83efc596071ebaf9b8e5945715926d Mon Sep 17 00:00:00 2001 From: tugcekucukoglu Date: Mon, 13 May 2024 12:46:55 +0300 Subject: [PATCH 2/3] TreeTable column header cell content added --- components/lib/treetable/HeaderCell.vue | 16 +++++++++------- components/lib/treetable/style/TreeTableStyle.js | 1 + 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/components/lib/treetable/HeaderCell.vue b/components/lib/treetable/HeaderCell.vue index 8918be6a5..a53ff4f4d 100644 --- a/components/lib/treetable/HeaderCell.vue +++ b/components/lib/treetable/HeaderCell.vue @@ -13,13 +13,15 @@ :data-p-highlight="isColumnSorted()" :data-p-frozen-column="columnProp('frozen')" > - - - {{ columnProp('header') }} - - - - {{ getMultiSortMetaIndex() + 1 }} +
+ + + {{ columnProp('header') }} + + + + {{ getMultiSortMetaIndex() + 1 }} +
diff --git a/components/lib/treetable/style/TreeTableStyle.js b/components/lib/treetable/style/TreeTableStyle.js index 1288fdc43..0b7b79061 100644 --- a/components/lib/treetable/style/TreeTableStyle.js +++ b/components/lib/treetable/style/TreeTableStyle.js @@ -462,6 +462,7 @@ const classes = { } ], columnResizer: 'p-treetable-column-resizer', + columnHeaderContent: 'p-treetable-column-header-content', columnTitle: 'p-treetable-column-title', sortIcon: 'p-treetable-sort-icon', sortBadge: 'p-treetable-sort-badge', From db09d00a4357602280a5d1f515c4e5d31759088f Mon Sep 17 00:00:00 2001 From: tugcekucukoglu Date: Mon, 13 May 2024 13:08:24 +0300 Subject: [PATCH 3/3] Use Badge as inner component in Tables --- components/lib/column/Column.d.ts | 7 ++++--- components/lib/datatable/HeaderCell.vue | 4 +++- components/lib/datatable/style/DataTableStyle.d.ts | 2 +- components/lib/datatable/style/DataTableStyle.js | 6 ++---- components/lib/treetable/HeaderCell.vue | 4 +++- components/lib/treetable/style/TreeTableStyle.d.ts | 2 +- components/lib/treetable/style/TreeTableStyle.js | 6 ++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/components/lib/column/Column.d.ts b/components/lib/column/Column.d.ts index 18b17eb1c..95fafbc5a 100755 --- a/components/lib/column/Column.d.ts +++ b/components/lib/column/Column.d.ts @@ -9,6 +9,7 @@ * */ import { VNode } from 'vue'; +import { BadgePassThroughOptions } from '../badge'; import { ComponentHooks } from '../basecomponent'; import { ButtonPassThroughOptions } from '../button'; import { CheckboxPassThroughOptionType } from '../checkbox'; @@ -154,11 +155,11 @@ export interface ColumnPassThroughOptions { */ sortIcon?: ColumnPassThroughOptionType; /** - * Used to pass attributes to the sort badge's DOM element. + * Used to pass attributes to the Badge component. */ - sortBadge?: ColumnPassThroughOptionType; + pcSortBadge?: BadgePassThroughOptions; /** - * Used to pass attributes to the header checkbox's DOM element. + * Used to pass attributes to the Checkbox component. */ pcHeaderCheckbox?: CheckboxPassThroughOptionType; /** diff --git a/components/lib/datatable/HeaderCell.vue b/components/lib/datatable/HeaderCell.vue index c8d01b84d..9f5b0019f 100644 --- a/components/lib/datatable/HeaderCell.vue +++ b/components/lib/datatable/HeaderCell.vue @@ -29,7 +29,7 @@ - {{ getBadgeValue() }} +