From 0704975c15550e8f76746a85ed07ca2a14fc4a2d Mon Sep 17 00:00:00 2001
From: mertsincan <sincan.mert@gmail.com>
Date: Tue, 31 Aug 2021 09:46:25 +0300
Subject: [PATCH 1/2] Fixed #1446 and #1486 - Improve Tabview component

---
 src/components/tabview/TabView.vue | 117 +++++++++++++++++++++++++----
 1 file changed, 104 insertions(+), 13 deletions(-)

diff --git a/src/components/tabview/TabView.vue b/src/components/tabview/TabView.vue
index b9a743a9d..662c1dcec 100755
--- a/src/components/tabview/TabView.vue
+++ b/src/components/tabview/TabView.vue
@@ -1,14 +1,24 @@
 <template>
-    <div class="p-tabview p-component">
-        <ul ref="nav" class="p-tabview-nav" role="tablist">
-            <li role="presentation" v-for="(tab, i) of tabs" :key="getKey(tab,i)" :class="[{'p-highlight': (d_activeIndex === i), 'p-disabled': isTabDisabled(tab)}]">
-                <a role="tab" class="p-tabview-nav-link" @click="onTabClick($event, i)" @keydown="onTabKeydown($event, i)" :tabindex="isTabDisabled(tab) ? null : '0'" :aria-selected="d_activeIndex === i" v-ripple>
-                    <span class="p-tabview-title" v-if="tab.props && tab.props.header">{{tab.props.header}}</span>
-                    <component :is="tab.children.header" v-if="tab.children && tab.children.header"></component>
-                </a>
-            </li>
-            <li ref="inkbar" class="p-tabview-ink-bar"></li>
-        </ul>
+    <div :class="contentClasses">
+        <div class="p-tabview-nav-container">
+            <button v-if="scrollable" :class="prevButtonClasses" :disabled="backwardIsDisabled" @click="navBackward" type="button" v-ripple>
+				<span class="pi pi-chevron-left"></span>
+			</button>
+            <div ref="content" class="p-tabview-nav-content" @scroll="onScroll">
+                <ul ref="nav" class="p-tabview-nav" role="tablist">
+                    <li role="presentation" v-for="(tab, i) of tabs" :key="getKey(tab,i)" :class="[{'p-highlight': (d_activeIndex === i), 'p-disabled': isTabDisabled(tab)}]">
+                        <a role="tab" class="p-tabview-nav-link" @click="onTabClick($event, i)" @keydown="onTabKeydown($event, i)" :tabindex="isTabDisabled(tab) ? null : '0'" :aria-selected="d_activeIndex === i" v-ripple>
+                            <span class="p-tabview-title" v-if="tab.props && tab.props.header">{{tab.props.header}}</span>
+                            <component :is="tab.children.header" v-if="tab.children && tab.children.header"></component>
+                        </a>
+                    </li>
+                    <li ref="inkbar" class="p-tabview-ink-bar"></li>
+                </ul>
+            </div>
+            <button v-if="scrollable" :class="nextButtonClasses" :disabled="forwardIsDisabled" @click="navForward" type="button" v-ripple>
+				<span class="pi pi-chevron-right"></span>
+			</button>
+        </div>
         <div class="p-tabview-panels">
             <template v-for="(tab, i) of tabs" :key="getKey(tab,i)">
                 <div  class="p-tabview-panel" role="tabpanel" v-if="lazy ? (d_activeIndex === i) : true" v-show="lazy ? true: (d_activeIndex === i)">
@@ -34,16 +44,24 @@ export default {
         lazy: {
             type: Boolean,
             default: false
+        },
+        scrollable: {
+            type: Boolean,
+            default: false
         }
     },
     data() {
         return {
-            d_activeIndex: this.activeIndex
+            d_activeIndex: this.activeIndex,
+            backwardIsDisabled: true,
+            forwardIsDisabled: false
         }
     },
     watch: {
         activeIndex(newValue) {
             this.d_activeIndex = newValue;
+
+            this.updateScrollBar(newValue);
         }
     },
     updated() {
@@ -62,6 +80,8 @@ export default {
                     originalEvent: event,
                     index: i
                 });
+
+                this.updateScrollBar(i);
             }
 
             this.$emit('tab-click', {
@@ -79,6 +99,18 @@ export default {
             this.$refs.inkbar.style.width = DomHandler.getWidth(tabHeader) + 'px';
             this.$refs.inkbar.style.left =  DomHandler.getOffset(tabHeader).left - DomHandler.getOffset(this.$refs.nav).left + 'px';
         },
+        updateScrollBar(index) {
+            let tabHeader = this.$refs.nav.children[index];
+            tabHeader.scrollIntoView(false);
+        },
+        updateButtonState() {
+            const content = this.$refs.content;
+            const { scrollLeft, scrollWidth } = content;
+            const width = DomHandler.getWidth(content);
+
+            this.backwardIsDisabled = scrollLeft === 0;
+            this.forwardIsDisabled = scrollLeft === scrollWidth - width;
+        },
         getKey(tab, i) {
             return (tab.props && tab.props.header) ? tab.props.header : i;
         },
@@ -87,9 +119,37 @@ export default {
         },
         isTabPanel(child) {
             return child.type.name === 'TabPanel'
+        },
+        onScroll(event) {
+            this.scrollable && this.updateButtonState();
+
+            event.preventDefault();
+        },
+        navBackward() {
+            const content = this.$refs.content;
+            const width = DomHandler.getWidth(content);
+            const pos = content.scrollLeft - width;
+            content.scrollLeft = pos <= 0 ? 0 : pos;
+        },
+        navForward() {
+            const content = this.$refs.content;
+            const width = DomHandler.getWidth(content);
+            const pos = content.scrollLeft + width;
+            const lastPos = content.scrollWidth - width;
+
+            content.scrollLeft = pos >= lastPos ? lastPos : pos;
         }
     },
     computed: {
+        contentClasses() {
+			return ['p-tabview p-component', {'p-tabview-scrollable': this.scrollable}];
+		},
+        prevButtonClasses() {
+            return ['p-tabview-nav-prev p-tabview-nav-btn p-link', {'p-disabled': this.backwardIsDisabled}]
+        },
+        nextButtonClasses() {
+            return ['p-tabview-nav-next p-tabview-nav-btn p-link', {'p-disabled': this.forwardIsDisabled}]
+        },
         tabs() {
             const tabs = []
             this.$slots.default().forEach(child => {
@@ -106,7 +166,7 @@ export default {
                 }
             )
             return tabs;
-        },
+        }
     },
     directives: {
         'ripple': Ripple
@@ -115,12 +175,23 @@ export default {
 </script>
 
 <style>
+.p-tabview-nav-container {
+    position: relative;
+}
+
+.p-tabview-nav-content {
+    overflow-x: auto;
+    overflow-y: hidden;
+    scroll-behavior: smooth;
+    scrollbar-width: none;
+}
+
 .p-tabview-nav {
     display: flex;
     margin: 0;
     padding: 0;
     list-style-type: none;
-    flex-wrap: wrap;
+    flex: 1 1 auto;
 }
 
 .p-tabview-nav-link {
@@ -144,5 +215,25 @@ export default {
 
 .p-tabview-title {
     line-height: 1;
+    white-space: nowrap;
+}
+
+.p-tabview-nav-btn {
+    position: absolute;
+    top: 0;
+    z-index: 2;
+    height: 100%;
+}
+
+.p-tabview-nav-prev {
+    left: 0;
+}
+
+.p-tabview-nav-next {
+    right: 0;
+}
+
+.p-tabview-nav-content::-webkit-scrollbar {
+    display: none;
 }
 </style>

From 7744691246186fc787784a90a4da61dbaf779bd5 Mon Sep 17 00:00:00 2001
From: mertsincan <sincan.mert@gmail.com>
Date: Tue, 31 Aug 2021 09:47:07 +0300
Subject: [PATCH 2/2] Update doc and d.ts file of Tabview

---
 api-generator/components/tabview.js |  6 ++++++
 src/components/tabview/TabView.d.ts |  1 +
 src/views/tabview/TabViewDoc.vue    | 20 +++++++++++++-------
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/api-generator/components/tabview.js b/api-generator/components/tabview.js
index b04ca2267..996ca9cb2 100644
--- a/api-generator/components/tabview.js
+++ b/api-generator/components/tabview.js
@@ -10,6 +10,12 @@ const TabViewProps = [
         type: "boolean",
         default: "false",
         description: "When enabled, hidden tabs are not rendered at all. Defaults to false that hides tabs with css."
+    },
+    {
+        name: "scrollable",
+        type: "boolean",
+        default: "false",
+        description: "When specified, enables horizontal scrolling."
     }
 ];
 
diff --git a/src/components/tabview/TabView.d.ts b/src/components/tabview/TabView.d.ts
index afc8ad7e6..33135a9c1 100755
--- a/src/components/tabview/TabView.d.ts
+++ b/src/components/tabview/TabView.d.ts
@@ -3,6 +3,7 @@ import { VNode } from 'vue';
 interface TabViewProps {
     activeIndex?: number;
     lazy?: boolean;
+    scrollable?: boolean;
 }
 
 declare class TabView {
diff --git a/src/views/tabview/TabViewDoc.vue b/src/views/tabview/TabViewDoc.vue
index fa40bde38..6bb874b06 100755
--- a/src/views/tabview/TabViewDoc.vue
+++ b/src/views/tabview/TabViewDoc.vue
@@ -225,6 +225,12 @@ export default {
                         <td>boolean</td>
                         <td>false</td>
                         <td>When enabled, hidden tabs are not rendered at all. Defaults to false that hides tabs with css.</td>
+                    </tr>
+                    <tr>
+                        <td>scrollable</td>
+                        <td>boolean</td>
+                        <td>false</td>
+                        <td>When specified, enables horizontal scrolling.</td>
                     </tr>
 				</tbody>
 			</table>
@@ -413,15 +419,15 @@ export default {
             active: 0,
             tabs: [
                 {
-                    title: 'Header I', 
+                    title: 'Header I',
                     content: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
                 },
                 {
-                    title: 'Header II', 
+                    title: 'Header II',
                     content: "Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Consectetur, adipisci velit, sed quia non numquam eius modi."
                 },
                 {
-                    title: 'Header III', 
+                    title: 'Header III',
                     content: "At vero eos et accusamus et iusto odio dignissimos ducimus qui blanditiis praesentium voluptatum deleniti atque corrupti quos dolores et quas molestias excepturi sint occaecati cupiditate non provident, similique sunt in culpa qui officia deserunt mollitia animi, id est laborum et dolorum fuga. Et harum quidem rerum facilis est et expedita distinctio. Nam libero tempore, cum soluta nobis est eligendi optio cumque nihil impedit quo minus."
                 }
             ]
@@ -557,15 +563,15 @@ export default {
         const active = ref(0);
         const tabs = ref([
             {
-                title: 'Header I', 
+                title: 'Header I',
                 content: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
             },
             {
-                title: 'Header II', 
+                title: 'Header II',
                 content: "Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Consectetur, adipisci velit, sed quia non numquam eius modi."
             },
             {
-                title: 'Header III', 
+                title: 'Header III',
                 content: "At vero eos et accusamus et iusto odio dignissimos ducimus qui blanditiis praesentium voluptatum deleniti atque corrupti quos dolores et quas molestias excepturi sint occaecati cupiditate non provident, similique sunt in culpa qui officia deserunt mollitia animi, id est laborum et dolorum fuga. Et harum quidem rerum facilis est et expedita distinctio. Nam libero tempore, cum soluta nobis est eligendi optio cumque nihil impedit quo minus."
             }
         ]);
@@ -596,4 +602,4 @@ export default {
         }
     }
 }
-</script>
\ No newline at end of file
+</script>