From 5c461c9aece78ed7bf6a20559959f4c28acebbc4 Mon Sep 17 00:00:00 2001
From: ANTONA09 <akshay.antony@nyulangone.org>
Date: Fri, 19 Jul 2024 14:32:35 +0530
Subject: [PATCH 1/2] fix: #6084, SELECT: hide clear button when options is
 empty in Dropdown

---
 packages/primevue/src/select/Select.vue | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/primevue/src/select/Select.vue b/packages/primevue/src/select/Select.vue
index bc7033bde..ffab1eaca 100755
--- a/packages/primevue/src/select/Select.vue
+++ b/packages/primevue/src/select/Select.vue
@@ -48,7 +48,7 @@
         >
             <slot name="value" :value="modelValue" :placeholder="placeholder">{{ label === 'p-emptylabel' ? '&nbsp;' : label || 'empty' }}</slot>
         </span>
-        <slot v-if="showClear && modelValue != null" name="clearicon" :class="cx('clearIcon')" :clearCallback="onClearClick">
+        <slot v-if="isClearIconVisible()" name="clearicon" :class="cx('clearIcon')" :clearCallback="onClearClick">
             <component :is="clearIcon ? 'i' : 'TimesIcon'" ref="clearIcon" :class="[cx('clearIcon'), clearIcon]" @click="onClearClick" v-bind="ptm('clearIcon')" data-pc-section="clearicon" />
         </slot>
         <div :class="cx('dropdown')" v-bind="ptm('dropdown')">
@@ -191,7 +191,7 @@
 
 <script>
 import { absolutePosition, addStyle, findSingle, focus, getFirstFocusableElement, getFocusableElements, getLastFocusableElement, getOuterWidth, isAndroid, isTouchDevice, isVisible, relativePosition } from '@primeuix/utils/dom';
-import { equals, findLastIndex, isNotEmpty, isPrintableCharacter, resolveFieldData } from '@primeuix/utils/object';
+import { equals, findLastIndex, isEmpty, isNotEmpty, isPrintableCharacter, resolveFieldData } from '@primeuix/utils/object';
 import { ZIndex } from '@primeuix/utils/zindex';
 import { FilterService } from '@primevue/core/api';
 import { ConnectedOverlayScrollHandler, UniqueComponentId } from '@primevue/core/utils';
@@ -432,6 +432,9 @@ export default {
 
             this.clicked = false;
         },
+        isClearIconVisible() {
+            return this.showClear && this.modelValue != null && !isEmpty(this.options);
+        },
         onEditableInput(event) {
             const value = event.target.value;
 

From 79537911b313f09d513b639f75ce84fbeadf5d53 Mon Sep 17 00:00:00 2001
From: ANTONA09 <akshay.antony@nyulangone.org>
Date: Fri, 19 Jul 2024 14:35:37 +0530
Subject: [PATCH 2/2] fix: #6084, SELECT: hide clear button when options is
 empty in Dropdown

---
 packages/primevue/src/select/Select.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/primevue/src/select/Select.vue b/packages/primevue/src/select/Select.vue
index ffab1eaca..bf7eebbad 100755
--- a/packages/primevue/src/select/Select.vue
+++ b/packages/primevue/src/select/Select.vue
@@ -191,7 +191,7 @@
 
 <script>
 import { absolutePosition, addStyle, findSingle, focus, getFirstFocusableElement, getFocusableElements, getLastFocusableElement, getOuterWidth, isAndroid, isTouchDevice, isVisible, relativePosition } from '@primeuix/utils/dom';
-import { equals, findLastIndex, isEmpty, isNotEmpty, isPrintableCharacter, resolveFieldData } from '@primeuix/utils/object';
+import { equals, findLastIndex, isNotEmpty, isPrintableCharacter, resolveFieldData } from '@primeuix/utils/object';
 import { ZIndex } from '@primeuix/utils/zindex';
 import { FilterService } from '@primevue/core/api';
 import { ConnectedOverlayScrollHandler, UniqueComponentId } from '@primevue/core/utils';
@@ -433,7 +433,7 @@ export default {
             this.clicked = false;
         },
         isClearIconVisible() {
-            return this.showClear && this.modelValue != null && !isEmpty(this.options);
+            return this.showClear && this.modelValue != null && isNotEmpty(this.options);
         },
         onEditableInput(event) {
             const value = event.target.value;