From c55e6fa54d520cf0cfba2b21a97dcf5c03345ac2 Mon Sep 17 00:00:00 2001 From: Cagatay Civici Date: Tue, 18 Feb 2025 14:48:31 +0300 Subject: [PATCH 01/17] Replaced light-dark for compatibility --- .../assets/styles/layout/_designer.scss | 42 +++++++++---------- .../styles/layout/variables/main/_dark.scss | 11 +++-- .../styles/layout/variables/main/_light.scss | 3 ++ 3 files changed, 31 insertions(+), 25 deletions(-) diff --git a/apps/showcase/assets/styles/layout/_designer.scss b/apps/showcase/assets/styles/layout/_designer.scss index 85280939f..6afa3f53e 100644 --- a/apps/showcase/assets/styles/layout/_designer.scss +++ b/apps/showcase/assets/styles/layout/_designer.scss @@ -25,15 +25,15 @@ } &.p-drawer { - background: light-dark(var(--p-surface-0), var(--p-surface-900)); - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); - color: light-dark(#09090b, #ffffff); + background: var(--overlay-background); + border-color: var(--border-color); + color: var(--high-contrast-text-color); box-shadow: 0 20px 25px -5px rgba(0, 0, 0, 0.1), 0 8px 10px -6px rgba(0, 0, 0, 0.1); } .p-fieldset { background: transparent; - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); + border-color: var(--border-color); border-radius: 4px; color: inherit; padding: 0 1.125rem 1.125rem 1.125rem; @@ -84,15 +84,15 @@ .p-tablist-tab-list { background: transparent; border-style: solid; - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); + border-color: var(--border-color); border-width: 0 0 1px 0; } .p-tab { background: transparent; border-width: 0 0 1px 0; - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); - color: light-dark(var(--p-surface-500), var(--p-surface-400)); + border-color: var(--border-color); + color: var(--text-secondary-color); padding: 1rem 1.125rem; font-weight: 600; transition: none; @@ -102,19 +102,19 @@ .p-tab:not(.p-tab-active):not(.p-disabled):hover { background: transparent; border-color: transparent; - color: light-dark(var(--p-surface-700), var(--p-surface-0)); + color: var(--high-contrast-text-color); } .p-tab-active { background: transparent; border-color: transparent; - color: light-dark(#09090b, #ffffff); + color: var(--high-contrast-text-color); } .p-tablist-active-bar { inset-block-end: -1px; height: 1px; - background: light-dark(#09090b, #ffffff); + background: var(--high-contrast-text-color); transition: 250ms cubic-bezier(0.35, 0, 0.25, 1); } @@ -128,12 +128,12 @@ .p-accordion { .p-accordionpanel { border-width: 0 0 1px 0; - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); + border-color: var(--border-color); } .p-accordionheader { padding: 1.125rem; - color: light-dark(var(--p-surface-500), var(--p-surface-400)); + color: var(--text-secondary-color); background: transparent; border-width: 0; border-color: unset; @@ -159,13 +159,13 @@ } .p-accordionheader-toggle-icon { - color: light-dark(var(--p-surface-500), var(--p-surface-400)); + color: var(--text-secondary-color); } .p-accordionpanel:not(.p-accordionpanel-active):not(.p-disabled)>.p-accordionheader:hover, .p-accordionpanel:not(.p-disabled).p-accordionpanel-active>.p-accordionheader { background: transparent; - color: light-dark(var(--p-surface-700), var(--p-surface-0)); + color: var(--text-color); } .p-accordionpanel:not(.p-accordionpanel-active):not(.p-disabled) .p-accordionheader:hover .p-accordionheader-toggle-icon, @@ -175,7 +175,7 @@ .p-accordioncontent-content { border-width: 0; - border-color: light-dark(var(--p-surface-200), var(--p-surface-700)); + border-color: var(--border-color); background-color: transparent; color: inherit; padding: 0 1.125rem 1.125rem 1.125rem; @@ -184,21 +184,21 @@ .p-fileupload-choose-button { padding: 0.5rem 0.75rem; - background: light-dark(#09090b, #ffffff); - border-color: light-dark(#09090b, #ffffff); - color: light-dark(#ffffff, #000000); + background: var(--designer-primary-color); + border-color: var(--designer-primary-color); + color: var(--designer-primary-contrast-color); cursor: pointer; font-weight: medium; border-radius: 4px; transition: background 0.2s; &:hover { - background: light-dark(#27272a, #f3f4f6); - border-color: light-dark(#27272a, #f3f4f6); + background: var(--designer-primary--emphasis-color); + border-color: var(--designer-primary--emphasis-color); } &:focus-visible { - outline: 1px solid light-dark(#09090b, #ffffff); + outline: 1px solid var(--designer-primary-color); outline-offset: 2px; box-shadow: none; } diff --git a/apps/showcase/assets/styles/layout/variables/main/_dark.scss b/apps/showcase/assets/styles/layout/variables/main/_dark.scss index 1e85ae81c..415fcb1fc 100644 --- a/apps/showcase/assets/styles/layout/variables/main/_dark.scss +++ b/apps/showcase/assets/styles/layout/variables/main/_dark.scss @@ -1,14 +1,14 @@ :root[class="p-dark"] { - --primary-text-color:var(--p-primary-400); + --primary-text-color: var(--p-primary-400); --primary-color: var(--p-primary-color); - --primary-contrast-color:var(--p-primary-contrast-color); + --primary-contrast-color: var(--p-primary-contrast-color); --primary-hover-color: var(--p-primary-hover-color); --text-color: var(--p-surface-0); --text-secondary-color: var(--p-surface-400); --glow-image: url(https://www.primefaces.org/cdn/primevue/images/layout/pattern.png), radial-gradient(50% 50% at center -25px, var(--p-primary-color) 0%, #000000 100%); --glow-blend: hard-light, color-dodge; - --topbar-sticky-background:rgba(0,0,0,.3); - --mobile-menu-background: rgba(0,0,0,.3); + --topbar-sticky-background: rgba(0, 0, 0, .3); + --mobile-menu-background: rgba(0, 0, 0, .3); --card-border: 1px solid transparent; --card-background: var(--p-surface-900); --border-color: var(--p-surface-700); @@ -25,4 +25,7 @@ --code-button-text-color: var(--p-surface-300); --docsearch-mask-background: var(--p-mask-background); --logo-color: var(--text-secondary-color); + --designer-primary-color: #ffffff; + --designer-primary-emphasis-color: #f3f4f6; + --designer-primary-contrast-color: #000000; } \ No newline at end of file diff --git a/apps/showcase/assets/styles/layout/variables/main/_light.scss b/apps/showcase/assets/styles/layout/variables/main/_light.scss index a2d43e5d5..56ef61701 100644 --- a/apps/showcase/assets/styles/layout/variables/main/_light.scss +++ b/apps/showcase/assets/styles/layout/variables/main/_light.scss @@ -25,4 +25,7 @@ --code-button-text-color: var(--p-surface-300); --docsearch-mask-background: var(--p-mask-background); --logo-color: var(--text-secondary-color); + --designer-primary-color: #09090b; + --designer-primary-emphasis-color: #27272a; + --designer-primary-contrast-color: #ffffff; } \ No newline at end of file From 747465806d3465ba5720a99a975db4c7a6fc9f4a Mon Sep 17 00:00:00 2001 From: Cagatay Civici Date: Tue, 18 Feb 2025 14:53:26 +0300 Subject: [PATCH 02/17] Cosmetics for pencil icon --- .../components/layout/designer/dashboard/DesignDashboard.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/showcase/components/layout/designer/dashboard/DesignDashboard.vue b/apps/showcase/components/layout/designer/dashboard/DesignDashboard.vue index c2232b302..db8ebccb1 100644 --- a/apps/showcase/components/layout/designer/dashboard/DesignDashboard.vue +++ b/apps/showcase/components/layout/designer/dashboard/DesignDashboard.vue @@ -57,8 +57,8 @@
- - + +
{{ formatTimestamp(theme.t_last_updated) }}
From 8413c0e1f1a7d83a3d6cc63f878b5f279bda7ee3 Mon Sep 17 00:00:00 2001 From: Cagatay Civici Date: Tue, 18 Feb 2025 14:56:07 +0300 Subject: [PATCH 03/17] Fixed size for designer icons --- apps/showcase/assets/styles/layout/_designer.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/apps/showcase/assets/styles/layout/_designer.scss b/apps/showcase/assets/styles/layout/_designer.scss index 6afa3f53e..273d3f150 100644 --- a/apps/showcase/assets/styles/layout/_designer.scss +++ b/apps/showcase/assets/styles/layout/_designer.scss @@ -13,6 +13,13 @@ cursor: pointer; } + .p-icon, + .pi { + font-size: 14px !important; + width: 14px !important; + height: 14px !important; + } + [type='color']::-webkit-color-swatch { border-radius: 4px; width: 24px; From 4f812f10fa7abaad7a38105c3f4b125ac1ae1b86 Mon Sep 17 00:00:00 2001 From: Cagatay Civici Date: Tue, 18 Feb 2025 14:59:15 +0300 Subject: [PATCH 04/17] Reset font settings on creation of new theme --- .../components/layout/designer/create/DesignCreateTheme.vue | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/showcase/components/layout/designer/create/DesignCreateTheme.vue b/apps/showcase/components/layout/designer/create/DesignCreateTheme.vue index 14050d56d..b7c1f4eda 100644 --- a/apps/showcase/components/layout/designer/create/DesignCreateTheme.vue +++ b/apps/showcase/components/layout/designer/create/DesignCreateTheme.vue @@ -199,6 +199,9 @@ export default { font_family: 'Inter var' } }; + this.designerService.applyFont('Inter var'); + document.documentElement.style.fontSize = '14px'; + this.designerService.replaceColorPalette(); usePreset(preset); this.designerService.refreshACTokens(); From a0bd06611fa0f134cbe452a3dd3534ffa7ca43aa Mon Sep 17 00:00:00 2001 From: Cagatay Civici Date: Tue, 18 Feb 2025 16:17:13 +0300 Subject: [PATCH 05/17] Update focus visuals --- .../assets/styles/layout/_designer.scss | 33 ++++++++++++++++++- .../styles/layout/variables/main/_dark.scss | 1 + .../styles/layout/variables/main/_light.scss | 1 + .../designer/editor/DesignTokenField.vue | 4 +-- 4 files changed, 36 insertions(+), 3 deletions(-) diff --git a/apps/showcase/assets/styles/layout/_designer.scss b/apps/showcase/assets/styles/layout/_designer.scss index 273d3f150..cadced68c 100644 --- a/apps/showcase/assets/styles/layout/_designer.scss +++ b/apps/showcase/assets/styles/layout/_designer.scss @@ -13,6 +13,16 @@ cursor: pointer; } + input:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: 0px; + } + + button:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: 2px; + } + .p-icon, .pi { font-size: 14px !important; @@ -63,7 +73,11 @@ background: transparent; border: 0 none; border-radius: 4px; - outline-color: transparent; + + &:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: -1px; + } } .p-fieldset-toggle-icon { @@ -104,6 +118,11 @@ font-weight: 600; transition: none; margin: 0 0 -1px 0; + + &:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: -1px; + } } .p-tab:not(.p-tab-active):not(.p-disabled):hover { @@ -130,6 +149,13 @@ color: inherit; padding: 0.875rem 0 1.125rem 0; } + + .p-tabpanel { + &:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: 0; + } + } } .p-accordion { @@ -147,6 +173,11 @@ font-weight: 600; border-radius: 4px; transition: none; + + &:focus-visible { + outline: 1px solid var(--designer-focus-outline-color); + outline-offset: -1px; + } } .p-accordionpanel:first-child>.p-accordionheader { diff --git a/apps/showcase/assets/styles/layout/variables/main/_dark.scss b/apps/showcase/assets/styles/layout/variables/main/_dark.scss index 415fcb1fc..82207f76f 100644 --- a/apps/showcase/assets/styles/layout/variables/main/_dark.scss +++ b/apps/showcase/assets/styles/layout/variables/main/_dark.scss @@ -28,4 +28,5 @@ --designer-primary-color: #ffffff; --designer-primary-emphasis-color: #f3f4f6; --designer-primary-contrast-color: #000000; + --designer-focus-outline-color: #ffffff; } \ No newline at end of file diff --git a/apps/showcase/assets/styles/layout/variables/main/_light.scss b/apps/showcase/assets/styles/layout/variables/main/_light.scss index 56ef61701..0f57f0ac3 100644 --- a/apps/showcase/assets/styles/layout/variables/main/_light.scss +++ b/apps/showcase/assets/styles/layout/variables/main/_light.scss @@ -28,4 +28,5 @@ --designer-primary-color: #09090b; --designer-primary-emphasis-color: #27272a; --designer-primary-contrast-color: #ffffff; + --designer-focus-outline-color: #09090b; } \ No newline at end of file diff --git a/apps/showcase/components/layout/designer/editor/DesignTokenField.vue b/apps/showcase/components/layout/designer/editor/DesignTokenField.vue index 4585a33e7..841fc2e3b 100644 --- a/apps/showcase/components/layout/designer/editor/DesignTokenField.vue +++ b/apps/showcase/components/layout/designer/editor/DesignTokenField.vue @@ -2,7 +2,7 @@
-
@@ -47,8 +47,8 @@