From f0b4bd2e3f6ebe015a6dcf19a02f4456b0202d9c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tu=C4=9F=C3=A7e=20K=C3=BC=C3=A7=C3=BCko=C4=9Flu?=
 <tugcekucukoglu.860@gmail.com>
Date: Tue, 18 Apr 2023 15:09:35 +0300
Subject: [PATCH] Fixed #3871 - Deprecated indicator slot

---
 components/lib/cascadeselect/CascadeSelect.d.ts |  1 +
 components/lib/cascadeselect/CascadeSelect.vue  | 17 +++++++----------
 components/lib/dropdown/Dropdown.d.ts           |  1 +
 components/lib/dropdown/Dropdown.vue            | 17 +++++++----------
 components/lib/multiselect/MultiSelect.vue      | 17 +++++++----------
 5 files changed, 23 insertions(+), 30 deletions(-)

diff --git a/components/lib/cascadeselect/CascadeSelect.d.ts b/components/lib/cascadeselect/CascadeSelect.d.ts
index e3ef5b5dc..e55163b0a 100644
--- a/components/lib/cascadeselect/CascadeSelect.d.ts
+++ b/components/lib/cascadeselect/CascadeSelect.d.ts
@@ -212,6 +212,7 @@ export interface CascadeSelectSlots {
     }): VNode[];
     /**
      * Custom indicator template.
+     * @deprecated since v3.27.0. Use 'dropdownicon or loadingicon' slots.
      */
     indicator(): VNode[];
     /**
diff --git a/components/lib/cascadeselect/CascadeSelect.vue b/components/lib/cascadeselect/CascadeSelect.vue
index 1fa49128c..fcbee62c4 100644
--- a/components/lib/cascadeselect/CascadeSelect.vue
+++ b/components/lib/cascadeselect/CascadeSelect.vue
@@ -30,16 +30,13 @@
             </slot>
         </span>
         <div class="p-cascadeselect-trigger" role="button" tabindex="-1" aria-hidden="true">
-            <slot v-if="$slots.indicator" name="indicator"></slot>
-            <template v-else>
-                <slot v-if="loading" name="loadingicon" class="p-cascadeselect-trigger-icon">
-                    <span v-if="loadingIcon" :class="['p-cascadeselect-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
-                    <SpinnerIcon v-else class="p-cascadeselect-trigger-icon" spin aria-hidden="true" />
-                </slot>
-                <slot v-else name="dropdownicon" class="p-cascadeselect-trigger-icon">
-                    <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-cascadeselect-trigger-icon', dropdownIcon]" aria-hidden="true" />
-                </slot>
-            </template>
+            <slot v-if="loading" name="loadingicon" class="p-cascadeselect-trigger-icon">
+                <span v-if="loadingIcon" :class="['p-cascadeselect-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
+                <SpinnerIcon v-else class="p-cascadeselect-trigger-icon" spin aria-hidden="true" />
+            </slot>
+            <slot v-else name="dropdownicon" class="p-cascadeselect-trigger-icon">
+                <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-cascadeselect-trigger-icon', dropdownIcon]" aria-hidden="true" />
+            </slot>
         </div>
         <span role="status" aria-live="polite" class="p-hidden-accessible">
             {{ searchResultMessageText }}
diff --git a/components/lib/dropdown/Dropdown.d.ts b/components/lib/dropdown/Dropdown.d.ts
index 66158e6be..948067249 100755
--- a/components/lib/dropdown/Dropdown.d.ts
+++ b/components/lib/dropdown/Dropdown.d.ts
@@ -273,6 +273,7 @@ export interface DropdownSlots {
     }): VNode[];
     /**
      * Custom indicator template.
+     * @deprecated since v3.27.0. Use 'dropdownicon or loadingicon' slots.
      */
     indicator(): VNode[];
     /**
diff --git a/components/lib/dropdown/Dropdown.vue b/components/lib/dropdown/Dropdown.vue
index b51afdc32..142bd4c4e 100755
--- a/components/lib/dropdown/Dropdown.vue
+++ b/components/lib/dropdown/Dropdown.vue
@@ -51,16 +51,13 @@
             <component :is="clearIcon ? 'i' : 'TimesIcon'" :class="['p-dropdown-clear-icon', clearIcon]" @click="onClearClick" v-bind="clearIconProps" />
         </slot>
         <div class="p-dropdown-trigger">
-            <slot v-if="$slots.indicator" name="indicator"></slot>
-            <template v-else>
-                <slot v-if="loading" name="loadingicon" class="p-dropdown-trigger-icon">
-                    <span v-if="loadingIcon" :class="['p-dropdown-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
-                    <SpinnerIcon v-else class="p-dropdown-trigger-icon" spin aria-hidden="true" />
-                </slot>
-                <slot v-else name="dropdownicon" class="p-dropdown-trigger-icon">
-                    <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-dropdown-trigger-icon', dropdownIcon]" aria-hidden="true" />
-                </slot>
-            </template>
+            <slot v-if="loading" name="loadingicon" class="p-dropdown-trigger-icon">
+                <span v-if="loadingIcon" :class="['p-dropdown-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
+                <SpinnerIcon v-else class="p-dropdown-trigger-icon" spin aria-hidden="true" />
+            </slot>
+            <slot v-else name="dropdownicon" class="p-dropdown-trigger-icon">
+                <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-dropdown-trigger-icon', dropdownIcon]" aria-hidden="true" />
+            </slot>
         </div>
         <Portal :appendTo="appendTo">
             <transition name="p-connected-overlay" @enter="onOverlayEnter" @after-enter="onOverlayAfterEnter" @leave="onOverlayLeave" @after-leave="onOverlayAfterLeave">
diff --git a/components/lib/multiselect/MultiSelect.vue b/components/lib/multiselect/MultiSelect.vue
index 9b42a6a02..b761b9649 100755
--- a/components/lib/multiselect/MultiSelect.vue
+++ b/components/lib/multiselect/MultiSelect.vue
@@ -44,16 +44,13 @@
             </div>
         </div>
         <div class="p-multiselect-trigger">
-            <slot v-if="$slots.indicator" name="indicator"></slot>
-            <template v-else>
-                <slot v-if="loading" name="loadingicon" class="p-multiselect-trigger-icon">
-                    <span v-if="loadingIcon" :class="['p-multiselect-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
-                    <SpinnerIcon v-else class="p-multiselect-trigger-icon" spin aria-hidden="true" />
-                </slot>
-                <slot v-else name="dropdownicon" class="p-multiselect-trigger-icon">
-                    <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-multiselect-trigger-icon', dropdownIcon]" aria-hidden="true" />
-                </slot>
-            </template>
+            <slot v-if="loading" name="loadingicon" class="p-multiselect-trigger-icon">
+                <span v-if="loadingIcon" :class="['p-multiselect-trigger-icon pi-spin', loadingIcon]" aria-hidden="true" />
+                <SpinnerIcon v-else class="p-multiselect-trigger-icon" spin aria-hidden="true" />
+            </slot>
+            <slot v-else name="dropdownicon" class="p-multiselect-trigger-icon">
+                <component :is="dropdownIcon ? 'span' : 'ChevronDownIcon'" :class="['p-multiselect-trigger-icon', dropdownIcon]" aria-hidden="true" />
+            </slot>
         </div>
         <Portal :appendTo="appendTo">
             <transition name="p-connected-overlay" @enter="onOverlayEnter" @after-enter="onOverlayAfterEnter" @leave="onOverlayLeave" @after-leave="onOverlayAfterLeave">