1
0
Fork 0
Commit Graph

7475 Commits (a5fdc00de1d9040aaa1ad8e65391716167b3dd11)

Author SHA1 Message Date
Yanick Witschi 34183f49f9
Implemented PoolOptimizer 2021-11-11 16:13:24 +01:00
Martin Herndl 7eca450d9b
Add wildcard support to ignore-platform-req, fixes #10045 (#10083) 2021-11-11 15:56:38 +01:00
Stephan 44c5b6cde6
Config: add source option for command to show where a config value is loaded from (#10129) 2021-11-11 15:17:58 +01:00
Stephan 012556daee
VcsRepository: limit type of versionTransportExceptions (#10275) 2021-11-11 12:24:47 +01:00
Martin Herndl 3013674c92
Refactor ignore platform reqs checks (#10079)
Introduces a `PlatformRequirementFilter` with methods that help to decide if a requirement is ignored or not as discussed in #10045 but without changing behaviour.
2021-11-11 12:24:12 +01:00
Jordi Boggiano 68847ed609
Tweak bitbucket driver to uniformize regexes 2021-11-11 12:21:26 +01:00
Jordi Boggiano ba1814f306
Added retry behavior for certain http status and curl error codes (#10162) 2021-11-10 22:12:42 +01:00
Jordi Boggiano cda7863f20
Get rid of the abstract BitbucketDriver class, fixes #9856 2021-11-10 22:08:30 +01:00
Raphael de Almeida 150acc5559
Removed HgBitbucketDriver support (#10248) 2021-11-10 21:58:03 +01:00
Jordi Boggiano ba5b7a5a9f
Add missing docblocks 2021-11-10 21:54:40 +01:00
Nicolas Grekas 8553c6d978
Add loading of files autoload section for plugins and Composer runtime autoloaders (#10065) 2021-11-10 21:37:33 +01:00
func0der 41a0c660b1 [add_sorting_to_archiving] Do not use natural sorting, cause of minimum required versions. 2021-11-10 15:39:50 +01:00
func0der a48afcd790 [add_sorting_to_archiving] Add natural sorting to ArchivableFilesFinder. 2021-11-10 15:23:39 +01:00
Jordi Boggiano b09a39f9c8
Error out on recursive links in validating loader and ignore them in regular loader 2021-11-10 11:10:52 +01:00
Jordi Boggiano bd4d624cc7
Read first from $_SERVER and $_ENV before using getenv (#10218) 2021-11-09 16:31:27 +01:00
Jordi Boggiano 85f3bb070d
Add abandoned flag in search command output 2021-11-09 16:04:21 +01:00
Jordi Boggiano 9e762a4f9a
Bump target to 2.2-dev 2021-11-09 16:04:08 +01:00
Jordi Boggiano 28c34128ee
Fix php proxies to resolve __FILE__ and __DIR__ using realpath on PHP <8, fixes #10261 2021-11-08 15:03:05 +01:00
Jordi Boggiano 3bb78fd1ee
Make new phar filename random to avoid possible concurrency issues, refs #10252 2021-11-08 11:45:07 +01:00
Jordi Boggiano 6a7264fc2d
Trigger autoloading of a few classes before executing self-update command, fixes #10252 2021-11-08 11:45:06 +01:00
Matthias Pigulla 4c9e567c39
Provide different URL options to encourage users to create low-privilege GitHub tokens (#10256) 2021-11-08 10:52:22 +01:00
Jordi Boggiano 9f433aba76
Fix 9999999-dev showing on composer show when no branch alias is defined for the default branch, fixes #10260 2021-11-08 10:43:25 +01:00
Martin Herndl 5b47fa1896
Add back abandoned key in repository search results (#10259) 2021-11-08 10:27:45 +01:00
Markus Staab d7154c2a72
Fix GithubActionError on php 8.1 (#10250) 2021-11-02 14:39:04 +01:00
Markus Staab 6b62f98d3c
GithubActionError: escape more special chars (#10243) 2021-11-02 11:43:34 +01:00
Jordi Boggiano 90087b4fb3
Fix handling of php bin proxies combined with declare() on php <8, fixes #10246 (#10249) 2021-11-02 11:36:31 +01:00
Jordi Boggiano 3f243d37c3
Add temporary metadata for download size tracking 2021-10-29 22:19:38 +02:00
Jordi Boggiano 44b69ba77f
Upgrade php-cs-fixer to 3.x and fix CS 2021-10-27 16:21:45 +02:00
Jordi Boggiano c65d09dff7
Fix @inheritDoc annotations 2021-10-27 16:18:53 +02:00
Martin Herndl 2992e8651a
Add types to `Util` tests (#10228) 2021-10-27 16:18:46 +02:00
Samuel Felipe 3ccb54832b
PHPStan level 6 in src/Composer/Command (#10214) 2021-10-27 14:18:16 +02:00
Jordi Boggiano df6c2ce1db
Simplify php bin proxies further 2021-10-27 11:24:50 +02:00
Jordi Boggiano e1dbd65aff
Fix bin proxies to use output buffering instead of the eval hack, as the __FILE__ and __DIR__ replacement is not safe when done in strings/nowdocs/.. 2021-10-27 11:16:34 +02:00
Joseph Wynn 44a2aa9be4
Log when COMPOSER_AUTH environment variable is malformed, but do not throw an error. Fixes #10208. (#10209)
Co-authored-by: Joseph Wynn <joseph@wildlyinaccurate.com>
2021-10-27 09:40:20 +02:00
Cédric Anne a7686e82f0
Filter candidates requiring an unknown platform package; fixes #10167 (#10184) 2021-10-26 17:24:17 +02:00
Martin Herndl 3645d3042c
Add types to root namespace (#10213) 2021-10-26 12:40:52 +02:00
Martin Herndl f267b01852
Use single docblock for parameter types (#10212) 2021-10-25 21:42:03 +02:00
Martin Herndl bd8b39fe01
Add types to `Package` (#10210) 2021-10-25 13:45:09 +02:00
Jordi Boggiano 0e96f363e1
Remove redundancy in package type 2021-10-25 13:13:01 +02:00
Martin Herndl 13d433fad0
Add types to `Package/Loader` (#10206) 2021-10-25 13:08:05 +02:00
Anatoly Pashin b1a96a3141
PHPStan level 6 in src/Composer/Repository (#10197) 2021-10-25 12:58:31 +02:00
Martin Herndl 3fa7a6cb51
Add types to `Package/Version` (#10199) 2021-10-25 11:09:52 +02:00
Martin Herndl aa4c2ab63c
Add types to `Plugin` (#10194) 2021-10-25 11:02:54 +02:00
Paolo Rossi a921d9b233
Reaching phpstan level 6 in EventDispatcher Exception and Installer folders (#10192) 2021-10-25 10:44:29 +02:00
Martin Herndl fa4d4e20e9
Add types to `Downloader` (#10193) 2021-10-25 10:25:39 +02:00
pistej b99e21259c
phpstan level 6 in src/Composer/Package/Comparer (refs #10159) (#10196) 2021-10-20 22:20:33 +02:00
Martin Herndl db9e9a544e
Add types to `Package/Dumper` (#10198) 2021-10-20 22:19:53 +02:00
pistej dbd0ccaad8
phpstan level 6 in src/Composer/Package/Archiver (refs #10159) (#10195) 2021-10-20 21:54:38 +02:00
Nils Adermann cbc686c16a
Merge pull request #10185 from Seldaek/remove_unknown_rule_type
Remove unknown Rule type
2021-10-19 22:00:10 +02:00
Martin Herndl 995bf5a932
Add types to `Util` namespace, refs #10159 (#10190) 2021-10-19 14:35:37 +02:00
Stephan 261d93aacf
ComposerRepository: handle packages.json with null value for package (#10189) 2021-10-19 13:14:12 +02:00
Jordi Boggiano 37ce8969a4
Use real type hint instead of annotation 2021-10-19 13:11:04 +02:00
Martin Herndl f0cc9aeb01
Remove scalar parameter type declaration (#10186)
`string` can only be used in parameters starting from PHP 7.0.
2021-10-19 13:10:21 +02:00
Paolo Rossi 3add01a40b
PHPStan level 6 in src/Composer/Config (refs #10159) (#10182) 2021-10-18 23:51:43 +02:00
Jordi Boggiano 87f25e6df6
Specify parseAutoloads more narrowly, refs #10179 2021-10-18 23:49:57 +02:00
immeëmosol be25cf1d7a
Reaching phpstan level 6 in Composer/Autoload (refs #10159) (#10179)
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-10-18 23:40:22 +02:00
Jordi Boggiano 57e417b53a
Minor cleanup 2021-10-18 23:10:11 +02:00
Jordi Boggiano 75a8677e8a
Remove unknown Rule type 2021-10-18 23:05:31 +02:00
Paolo Rossi 6e04991489
Reaching phpstan level 6 in Composer/Console (refs #10159) (#10183) 2021-10-18 22:40:50 +02:00
Jordi Boggiano 7e1f4882af
Reorder some code 2021-10-18 22:37:40 +02:00
immeëmosol 50d738eeee
Reaching phpstan level 6 in Composer/DependencyResolver (refs #10159) (#10178) 2021-10-18 22:33:37 +02:00
Jordi Boggiano 04ab74bbef
Avoid checking for hhvm in a loop, refs #10170 2021-10-18 10:51:16 +02:00
Jordi Boggiano a6f1e803b1
Use more BasePackage instead of PackageInterface 2021-10-17 14:43:34 +02:00
Jordi Boggiano b209816056
Type annotations 2021-10-17 14:31:48 +02:00
pistej 98f1465610
Phpstan level 6 in Composer/Plaform and Composer/Script (#10159) (#10170) 2021-10-17 13:52:01 +02:00
Jordi Boggiano f25398f52c
Fix 2021-10-17 10:49:57 +02:00
Jordi Boggiano e137046558
Type annotations 2021-10-17 10:31:09 +02:00
Fabien Villepinte 9fde6ec88b
PHPStan level 6 in src/Composer/Json (#10172) 2021-10-16 22:42:32 +02:00
pistej 04c157bf32
Reaching phpstan level 6 in Composer/SelfUpdate (#10169) 2021-10-16 22:35:31 +02:00
Jordi Boggiano 7d88de7d0b
Fix syntax 2021-10-16 11:17:44 +02:00
Jordi Boggiano 9599eb613b
Type annotations 2021-10-16 11:14:10 +02:00
immeëmosol 6d5f6eb090
Reaching phpstan level 6 in Composer\IO (#10166) 2021-10-16 10:36:02 +02:00
Jordi Boggiano c3c6969cf5
Type annotations 2021-10-16 10:25:12 +02:00
Jordi Boggiano 626370d444
Suggest COMPOSER_DISABLE_NETWORK if a possibly-offline state is detected (#10163)
Co-authored-by: Nils Adermann <naderman@naderman.de>
2021-10-16 09:47:04 +02:00
Jordi Boggiano 97fe881af4
Add some docblocks 2021-10-15 16:36:28 +02:00
Jordi Boggiano 915f3f4fb6
Make sure that if cleanup happens before install completes on zip updates, we do not report bogus errors, fixes #9804 2021-10-15 10:42:44 +02:00
Jordi Boggiano 0868245589
Rename master branch to main 2021-10-14 16:21:47 +02:00
Jordi Boggiano 4a7abd79c9
Fix 5.3 syntax 😒 2021-10-14 15:44:14 +02:00
Jordi Boggiano 759a3a9300
Fix require reverting changes even though dependency resolution succeeded if when something fails afterwards, closes #10118 2021-10-14 15:41:44 +02:00
Jordi Boggiano f776f52474
Hint composer require alternatives if dep resolution fails, fixes #10136 2021-10-14 15:12:29 +02:00
Jordi Boggiano 260ac0011c
Add constants to describe error codes from Installer::run 2021-10-14 15:12:06 +02:00
Jordi Boggiano 79727d35c4
Avoid warning due to invalid cache dir during init, wait for first use, fixes #10125 2021-10-14 10:24:08 +02:00
Jordi Boggiano f587237c55
Fix diagnose output when libz is not present for curl, refs #10153 2021-10-13 22:39:47 +02:00
Jordi Boggiano 2828ce59cf
Merge branch '1.10' 2021-10-13 22:12:54 +02:00
JDev4U 11810e3c2d
Fix help command not working with plugin commands, fixes #10147 (#10150)
- Add 'help' in the list of commands that need plugin command ($mayNeedPluginCommand)
- Remove `'global' !== $commandName` because $mayNeedPluginCommand encure that $commandName is one of `false`, `empty`, `list` or `help` (so never 'global')

Co-authored-by: Duret Joel <joel.duret@neo-soft.fr>
2021-10-13 22:03:31 +02:00
Jordi Boggiano aa4de3b13d
Fix CurlDownloader requesting gzip encoding even though unsupported, fixes #10153 2021-10-13 20:24:28 +02:00
John Stevenson 906442117c Carriage returns are ignored by cmd 2021-10-13 14:54:37 +01:00
Jordi Boggiano d1c8a4d1b4
Lots of typing improvements 2021-10-12 22:47:23 +02:00
Jordi Boggiano 1e3f7cfcba
Fix handling of json error responses 2021-10-12 17:32:59 +02:00
John Stevenson 8f974fe741 Improve Windows escaping 2021-10-10 16:24:49 +01:00
Jordi Boggiano cb1e248258
Fix type annotation 2021-10-05 09:47:20 +02:00
Jordi Boggiano 18e24976c1
Merge branch '1.10' 2021-10-05 09:43:00 +02:00
Jordi Boggiano ca5e2f8d50
Fix escaping issues on Windows which could lead to command injection, fixes GHSA-frqg-7g38-6gcf 2021-10-05 09:39:50 +02:00
Jordi Boggiano b3eebeb3b9
Merge pull request from GHSA-frqg-7g38-6gcf 2021-10-05 09:28:42 +02:00
Jordi Boggiano 532c6e7933
Fix show --all showing only the installed version if the package is installed, fixes #10095 2021-10-02 22:15:34 +02:00
Jordi Boggiano a7963b7fed
Fix ComposerRepository handling of offline state to allow resolution as long as everything is present in the cache, fixes #10116 2021-10-02 21:22:25 +02:00
Stephan edccad4e05
VcsRepository: do not continue when receiving 429 rate limit exception (#10132) 2021-10-02 20:40:49 +02:00
Sergii Dolgushev 90d112d98a
Mask Git credentials in the error message (#10115) 2021-10-02 20:30:21 +02:00
Jordi Boggiano d64d1adf61
Rewrite php file cleaning step to be less regex intensive and support extreme cases better, fixes #10106 (#10107) 2021-10-02 14:39:39 +02:00
Vitaly Baev 7305d50277
Changed GitLab's applications URL (#10104) 2021-09-15 13:16:51 +02:00
Jordi Boggiano d6a8b0252d
Fix phpdoc 2021-09-15 11:31:58 +02:00
Jordi Boggiano 8cd2d0e541
Fix scanning of classmaps in files containing invalid Unicode, fixes #10102 2021-09-15 11:31:43 +02:00
SvenRtbg 5c4e1cedb2
Add ability check for ZipArchive (#10092)
ZipArchive::setExternalAttributesName() is only available when libzip 0.11.2 or higher is present. 
This is not the case with at least SUSE SLES 12, so a simple PHP version check will not work here.
2021-09-13 22:30:02 +02:00
Jordi Boggiano 8657f80ddd
Fix error output to be clearer when running composer.phar without phar extension, fixes #10097 2021-09-13 21:46:28 +02:00
Jordi Boggiano 6179f33c74
Fix docker being seen as WSL when run inside WSL, fixes #10094 2021-09-13 21:11:55 +02:00
Jordi Boggiano 4bcd860b65
Add more type annotations 2021-09-05 17:34:12 +02:00
Jordi Boggiano dd49db6f08
Make sure that names with wildcards which are not preceded by dots are also seen as package names and not version constraints 2021-09-05 09:56:28 +02:00
Jordi Boggiano 6c9aecf4e7
Ignore all symfony deprecations 2021-09-03 21:39:06 +02:00
Alexander Schranz 99c6b450e6
Check for returned link header in GithubDriver 2021-09-02 19:17:17 +02:00
Jordi Boggiano 01d734125c
Add more type info 2021-08-30 17:45:35 +02:00
Jordi Boggiano 0761474599
Add type info to many properties/methods 2021-08-30 14:46:49 +02:00
Jordi Boggiano fc04c86f82
Add type info to Autoload namespace 2021-08-30 13:58:31 +02:00
Jordi Boggiano 61fba697a0
Fix validating array loader handling of invalid target branch datatype 2021-08-30 13:43:33 +02:00
Jordi Boggiano 024f0eda53
Add a bunch of type info to Util namespace 2021-08-29 20:07:50 +02:00
Jordi Boggiano 8559279025
Merge pull request #10076 from aschempp/bugfix/package-type-update
Correctly resolve promises when package type changes
2021-08-29 14:16:01 +02:00
Jordi Boggiano b8e461ea61
Make sure /proc/version read does not fail the process ever, closes #10080 2021-08-29 13:10:22 +02:00
Jordi Boggiano 0158436fb4
Fix list command not showing plugin commands, fixes #10075 2021-08-29 13:03:45 +02:00
Jordi Boggiano 922ba01d07
Merge pull request #10072 from jrfnl/feature/10067-fix-classmap-regression
ClassMapGenerator: stabilize the heredoc/nowdoc stripping
2021-08-29 12:26:20 +02:00
Jordi Boggiano d8054d1d2f
Add more possessive quantifiers, unicode flag and support for more post-heredoc syntax, fix test file syntax being invalid 2021-08-29 12:23:02 +02:00
Andreas Schempp 0bed60e631 Correctly resolve promises when package type changes 2021-08-25 22:35:34 +02:00
Jordi Boggiano 73c109c561
Make sure that names with wildcards which are not preceded by dots are also seen as package names and not version constraints 2021-08-25 21:09:49 +02:00
Jordi Boggiano 6ab1b6a7d2
Regex simplifications 2021-08-23 22:18:03 +02:00
Jordi Boggiano f6c446bdd7
Tweak to allow matching delimiter within the string 2021-08-23 13:14:15 +02:00
Jordi Boggiano c44be998ab
Undo new stripping code and fix regex 2021-08-23 13:14:02 +02:00
powellblyth 5e75017166
Just some comments with 'it's' that should have been 'its' (#10071)
Co-authored-by: Toby Powell-Blyth <tobypowell-blyth@elasticstage.com>
2021-08-22 13:41:18 +02:00
jrfnl 40bd4b03ad
ClassMapGenerator: stabilize the heredoc/nowdoc stripping
I've looked into 10067 and have come to the conclusion that using a single regex to strip the heredoc/nowdocs is always going to run into trouble as:
* Either the matching will be too greedy (issue 10067);
* Or the matching will run into backtrace limits for large heredoc/nowdocs.

We cannot solve both within a single regex.

So, I'm proposing a slightly different solution which should support both and should also improve performance for files containing large heredoc/nowdocs.

The `stripHereNowDocs()` function will find a start marker and remember the offset of the start marker.
It will then find the end marker and strip the contents between the two (replace with `null`).
The function will then recurse onto itself until all heredocs/nowdocs in a file have been removed.
2021-08-21 17:45:43 +02:00
Jordi Boggiano d3c176ec69
PHPStan Level 5 (#10070)
* Bump PHPStan to level 5

* Update seld/phar-utils to latest

* Add phpstan-setup / phpstan scripts
2021-08-21 17:41:52 +02:00
Jordi Boggiano b583310476
Allow ircs protocol for support.irc 2021-08-19 16:03:59 +02:00
Jordi Boggiano 74b231a4bc
Fix lib-openssl detection on FreeBSD, fixes #10046 2021-08-19 15:00:08 +02:00
Jordi Boggiano 9727adf63b
Fix init performance when plugin commands are not needed, fixes #10064 2021-08-19 14:37:50 +02:00
Jordi Boggiano a586a753df
Fix all remaining php8.1 test suite deprecations 2021-08-19 13:00:30 +02:00
Jordi Boggiano b77fce8a4f
More deprecation fixes by using ProcessExecutorMock and a couple of PackageInterface type fixes 2021-08-18 23:35:27 +02:00
Jordi Boggiano 6aa2d15868
Introduce ProcessExecutorMock to fix deprecations and amount of mocking pain 2021-08-18 17:17:56 +02:00
Jordi Boggiano c5a02a2b58
Fix return value of ProcessExecutor::getErrorOutput, closes #10054 2021-08-18 14:55:38 +02:00
Jordi Boggiano 052065028f
Merge pull request #10051 from jrfnl/feature/php-8.1-null-to-non-nullable-fix-1
PHP 8.1: prevent a "null to non-nullable" deprecation notice [1]
2021-08-18 14:36:14 +02:00
Jordi Boggiano 3dcc6c1514
Make return value explicit 2021-08-18 14:32:06 +02:00
Jordi Boggiano cfe718fa43
Fix usage of getRequiredPackage, closes #10052 2021-08-18 14:30:09 +02:00
Jordi Boggiano 8ce0ea300e
Fix pear repo preventing self-update from functioning, fixes #10049 2021-08-18 14:23:08 +02:00
Jordi Boggiano 5c201687e5
Fix 7zip issues on windows when mixing forward and backslashes, fixes #10058 2021-08-18 11:55:51 +02:00
Jordi Boggiano 91a1a471db
Fix path repo bug causing symlinks to be left behind when uninstalling, fixes #10023 2021-08-18 11:25:00 +02:00
Jordi Boggiano d465df434c
Make sure diagnose command can run without proc_open, refs #9253 2021-08-18 10:16:20 +02:00
Jordi Boggiano 60fe67086e
Make sure proc_open is not required for basic installs, refs #9253 2021-08-18 10:15:47 +02:00
Jordi Boggiano d6f4111f35
Fix php 5.3 support 2021-08-17 16:59:00 +02:00
Jordi Boggiano 46f2d9de48
Fix php 5.3 support 2021-08-17 16:53:16 +02:00
Jordi Boggiano ddd7920d2a
Fix corrupt archives in cache from getting the installs stuck forever, and make sure it fails only once, fixes #10028 2021-08-17 16:49:36 +02:00
Jordi Boggiano e49f24e355
Switch phar signatures to sha512 2021-08-17 15:58:27 +02:00
jrfnl 609007b072 PHP 8.1: prevent a "null to non-nullable" deprecation notice
Discovered while running the existing unit tests on PHP 8.1.

The default state of the protected `$distUrl` property is "not set" and the property may not be set when the `Package::setSourceDistReferences()` method gets called.

Fixes a total of 9 deprecation notices along the lines of:
```
Deprecation triggered by Composer\Test\DependencyResolver\PoolBuilderTest::testPoolBuilder:
preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 597)
1 src/Composer/Package/Package.php(597): preg_match('...', NULL)
2 src/Composer/DependencyResolver/PoolBuilder.php(360): Composer\Package\Package->setSourceDistReferences('...')
3 src/Composer/DependencyResolver/PoolBuilder.php(338): Composer\DependencyResolver\PoolBuilder->loadPackage(Object(Composer\DependencyResolver\Request), Object(Composer\Package\CompletePackage))
4 src/Composer/DependencyResolver/PoolBuilder.php(195): Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading(Object(Composer\DependencyResolver\Request), Array)
5 src/Composer/Repository/RepositorySet.php(229): Composer\DependencyResolver\PoolBuilder->buildPool(Array, Object(Composer\DependencyResolver\Request))
6 tests/Composer/Test/DependencyResolver/PoolBuilderTest.php(110): Composer\Repository\RepositorySet->createPool(Object(Composer\DependencyResolver\Request), Object(Composer\IO\NullIO))
...
```

Side-note: I'm wondering why `$this->getDistUrl()` is used instead of using the `$distUrl` property. It is a property within the same class after all. Haven't changed it, but did want to raise the question.

Refs:
* https://www.php.net/manual/en/function.preg-match.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
2021-08-12 02:45:29 +02:00
jrfnl 42c6a0d7c5 ClassMapGenerator: fix the regex
By using a look ahead assertion to match "new line - maybe whitespace - marker", the negative performance impact of the `.*` is significantly mitigated and backtracing will be severely limited.

This fixes the bug as reported in 10037.

The bug was discovered due to a PHP 8.1 "passing null to non-nullable" deprecation notice being thrown, but is not a PHP 8.1 bug.

In actual fact, this issue affected all PHP versions and could lead to incomplete classmaps when the code base contained files with huge heredocs/nowdocs.

The regex change (not completely) incidentally also fixes an issue with markers in a heredoc/nowdoc not being correctly handled. This bug could lead to "classes" being added to the class map which aren't actually classes.

Fixes 10037
2021-08-11 22:26:12 +02:00
Stephan c65bd832d6
Url: fix sanitize for new github tokens (#10048) 2021-08-11 13:24:41 +02:00
Juliette c7d11f361c
PHP 8.1: fix more return type deprecation warnings (#10039)
Follow up on 10008 and the various commits made for that.

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:06:47 +02:00
Juliette f5a0dfeb50
PHP 8.1: fix deprecation warnings about incorrect default values (#10036)
* PHP 8.1/Tests: fix some deprecation warnings

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.

Fixes numerous `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.

Ref: https://www.php.net/manual/en/function.preg-split.php

* PHP 8.1/NoProxyPattern: fix deprecation warning

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.

Fixes some `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.

```
Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest:
preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42)
1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1)
2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...')
3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData()
4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct()
5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance()
...
```

Ref: https://www.php.net/manual/en/function.preg-split.php

* PHP 8.1: fix deprecation warnings / http_build_query()

This fixes all relevant calls to the PHP native `http_build_query()` function.
The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`.

A parameter being optional, however, does not automatically make it nullable.

As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice.
In this case, these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice.

Changing the `null` to an empty string fixes this without BC-break.

Fixes a few deprecation warnings found when running the tests.

Refs:
* https://www.php.net/manual/en/function.http-build-query.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

* PHP 8.1: fix deprecation notices / PharData::__construct()

This fixes all relevant calls to the PHP native `PharData::__construct()` method.

The second parameter of this method is the _optional_ `$flags` parameter which expects an `int` of flags to be passed to the `Phar` parent class `RecursiveDirectoryIterator`.
Fixed by passing the default value for the `$flags` parameter as per the `RecursiveDirectoryIterator::__construct()` method.

The third parameter of the method is the _optional_ `$alias` parameter which expects an `string`.
Fixed by passing an empty string.

Fixes various notices along the lines of:
```
Deprecation triggered by Composer\Test\Package\Archiver\ArchiveManagerTest::testArchiveTar:
PharData::__construct(): Passing null to parameter #2 ($flags) of type int is deprecated

Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 55)
1 src/Composer/Package/Archiver/PharArchiver.php(55): PharData->__construct('...', NULL, NULL, 2)
2 src/Composer/Package/Archiver/ArchiveManager.php(193): Composer\Package\Archiver\PharArchiver->archive('...', '...', '...', Array, false)
3 tests/Composer/Test/Package/Archiver/ArchiveManagerTest.php(65): Composer\Package\Archiver\ArchiveManager->archive(Object(Composer\Package\CompletePackage), '...', '...')
...
```

Refs:
* https://www.php.net/manual/en/phardata.construct.php
* https://www.php.net/manual/en/recursivedirectoryiterator.construct.php

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:05:45 +02:00
Jordi Boggiano 2665f1b282
Fix private property access, fixes #10022 2021-07-28 14:33:47 +02:00
Jordi Boggiano 2fb53232d1
Fix usage on symfony 2.x, fixes #10022 2021-07-28 14:19:19 +02:00
Jordi Boggiano deb4c48bbc
Avoid using an invalid path for InstalledFilesystemRepo in create-project and use an array repo instead, fixes #10020, fixes #10021 2021-07-23 10:09:31 +02:00
Jordi Boggiano 1f4401005c
Allow default_socket_timeout to extend the curl timeout if it is longer than 300s, fixes #10018 2021-07-23 09:51:57 +02:00
GeoSot e07d2a7bef
Respect parent setting, handling exceptions (#10017) 2021-07-22 15:14:15 +02:00
Jordi Boggiano 2f83338d2f
Fix hopefully last php 8.1 deprecation warnings 2021-07-22 13:54:18 +02:00
Jordi Boggiano 24f5e54fbe
Fix only/exclude to avoid matching names as sub-strings of full package names, fixes #10001 2021-07-22 13:47:31 +02:00
Jordi Boggiano 29a52ff463
Register ErrorHandler early to catch deprecation notices while the Application is being initialized 2021-07-22 12:58:14 +02:00
Jordi Boggiano 2be03f0d60
More fixes for php8.1 deprecations 2021-07-22 12:42:01 +02:00
Jordi Boggiano a7efb27338
More php8.1 deprecation fixes, refs #10008 2021-07-22 11:48:30 +02:00
Jordi Boggiano 47cf602f9e
Fix more PHP 8.1 deprecations, refs #10008 2021-07-22 11:30:01 +02:00
Jordi Boggiano 10ae1d7b08
Fix some PHP 8.1 deprecation warnings, fixes #10008 2021-07-21 15:13:24 +02:00
Jordi Boggiano f5a03b950d
Improve error reporting in require command, fixes invalid case of consistency issue, fixes #10006 2021-07-21 14:38:10 +02:00
Ondrej Mirtes 79093d664b Update PHPStan and remove ignore 2021-07-21 10:10:09 +02:00
Ondřej Mirtes 58ced29a2a
Simplify code 2021-07-14 16:36:12 +02:00
Jordi Boggiano be58b36a35
Also look up 7zz on linux/macOS, fixes #9951 2021-07-12 15:50:02 +02:00
Jordi Boggiano b602b19f6d
Fix archive command now that zips are extracted async, refs composer/satis#655 2021-07-12 15:09:59 +02:00
Jordi Boggiano db1d9e75be
Fix support for 7z command fallback on linux/macOS, fixes #9994 2021-07-12 14:49:44 +02:00
Jordi Boggiano bacbd15b6b
Fix open_basedir support regession in bfea0f7d1 2021-07-12 14:34:18 +02:00
Jordi Boggiano 5152eeebdc
Merge pull request #9995 from Seldaek/fix_wsl
Fix UNC/WSL-path issues when running in Windows
2021-07-12 14:07:41 +02:00
Jordi Boggiano 005c55185a
Fix support for writing into UNC paths, and comparing UNC paths correctly in InstalledVersions, fixes #9993 2021-07-12 14:03:00 +02:00
Jordi Boggiano cc81f5bac3
Fix support for UNC paths in normalizePath, refs #9993 2021-07-12 13:36:57 +02:00
Ondřej Mirtes c65890d2d3
DiagnoseCommand - fix PHPDoc (#9991) 2021-07-07 21:52:53 +02:00
Jordi Boggiano 078aaa6968
Make sure the correct name is being output, fixes #9986 2021-06-27 14:45:31 +02:00
Jordi Boggiano a5efbbc94a
Validate schema before writing the file, fixes #9986 2021-06-27 14:45:31 +02:00
Jordi Boggiano 420d9bf21d
Move name validation out of interact, fixes #9986 2021-06-27 14:45:30 +02:00
Jordi Boggiano e87a150f41
Make sure schema issues are always reported correctly, but not in init when Composer is not required, fixes #9986 2021-06-27 14:45:30 +02:00
Jordi Boggiano 6f992a6ea3
Merge pull request #9975 from mitelg/fix-annotation-complete-package-interface
Fix initial values of CompletePackage properties
2021-06-26 23:16:58 +02:00
Jordi Boggiano 5780caf208
Fix link when no composer.json is present, fixes #9966 2021-06-26 23:09:27 +02:00
Michael Telgmann 66fb240e1b
Fix initial values of CompletePackage properties 2021-06-17 08:46:40 +02:00
Jordi Boggiano 9a32bf9709
Bump source version to 2.1.999 2021-06-09 16:44:06 +02:00
Jordi Boggiano bf3713072c
Fix source binaries not being made executable when symlinks cannot be used, fixes #9961 2021-06-09 16:25:16 +02:00
Jordi Boggiano 2d54a27ebc
Fix config support for new bin-compat value, refs #9959 2021-06-09 16:25:16 +02:00
noniagriconomie 65259ac8e0 Add Composer version in about command 2021-06-09 15:13:01 +02:00
Sebastian Blank a9031e40eb
Add "symlink" option for "bin-compat" config (#9959) 2021-06-09 11:33:44 +02:00
Jordi Boggiano 6c1f0cdf24
Handle edge cases too in removeDirectoryPhp to avoid trying to delete symlinks and such, fixes #9955 2021-06-08 21:53:20 +02:00
Jordi Boggiano f61f2c6872
Also free $file just in case 2021-06-08 21:26:41 +02:00
Jordi Boggiano a02802b109
Warn 1.x users when a package is not found that it may be due to our deprecation policy 2021-06-08 21:12:49 +02:00
Jordi Boggiano c668c24599
Fix autoload events not being dispatched when running dump-autoload command, fixes #9954 2021-06-08 15:34:26 +02:00
Jordi Boggiano b01cd459b7
Avoid checking if dir is empty if it does not even exist 2021-06-07 16:41:11 +02:00
Jordi Boggiano 6e851edd70
Add `--dev` to `dump-autoload` command to allow force-dumping dev autoload rules even if dev requirements are not present, fixes #9946 2021-06-07 15:48:37 +02:00
Jordi Boggiano e013b479da
Avoid failing hard if the target empty dir cannot be deleted when extracting archives, fixes #9947 2021-06-07 15:34:03 +02:00
Jordi Boggiano c4f675fe84
Fix virtualbox filesystem issue when installing packages, fixes #9945 2021-06-06 21:11:48 +02:00
Jordi Boggiano 4e4b4f69c9
Revert "Always wait after an unzip completes to try and fix virtualbox issues, refs #9945"
This reverts commit 3556f6efa5.
2021-06-06 21:10:07 +02:00
Jordi Boggiano dd17f5f615
Add missing use 2021-06-05 20:47:56 +02:00
Jordi Boggiano 3556f6efa5
Always wait after an unzip completes to try and fix virtualbox issues, refs #9945 2021-06-05 20:45:37 +02:00
Jordi Boggiano c1f0eee154
Revert "Attempt fixing virtualbox issues, refs #9945"
This reverts commit 7a7e0cc031.
2021-06-05 20:42:31 +02:00
Jordi Boggiano e087a4ab5e
Fix usage of InstalledVersions when loaded from composer/composer installed as a dependency and runtime Composer is v1, fixes #9937 2021-06-05 17:11:23 +02:00
Jordi Boggiano 7a7e0cc031
Attempt fixing virtualbox issues, refs #9945 2021-06-05 16:40:18 +02:00
Jordi Boggiano b45c8dea0a
Cleanups 2021-06-05 16:21:46 +02:00
Jordi Boggiano cbb1504910
Also do the change in ReinstallCommand 2021-06-05 16:21:46 +02:00
Nicolas Grekas eac069bf36
Fix --no-scripts disabling events for plugins 2021-06-05 16:09:04 +02:00
Jordi Boggiano 288e19153d
Alternative fix for #9941 to avoid code duplication 2021-06-05 16:04:24 +02:00
Jordi Boggiano cbd1e3c2af
Fix undefined index access when using "@php <absolute path>" in script handler, fixes #9943 2021-06-05 12:51:23 +02:00
Jordi Boggiano d45e3a98e4
Merge pull request #9938 from adlacruzes/fix_custom_json_schema
Fix JsonFile when using custom json schema with no "name" and "descri…
2021-06-04 08:10:46 +02:00
Jordi Boggiano 1bfec451e2
Make sure the LAX_SCHEMA handling disables required/additionalProperties as it used to do but strict schema requires properties only for the composer schema 2021-06-04 08:05:42 +02:00
Jordi Boggiano 5a28f677da
Fix outdated legend and only show legend when there is output to be shown, fixes #9939 2021-06-04 07:55:40 +02:00
Jordi Boggiano d77ff0f729
Workaround for PCRE regression 2021-06-04 07:17:57 +02:00
adlacruzes 7366b8e362 Fix JsonFile when using custom json schema with no "name" and "description" properties 2021-06-03 20:15:35 +02:00
Jordi Boggiano d5ce7a7385
Fix autoload generation for dev dependencies when --no-scripts is used, fixes #9934 2021-06-03 17:03:42 +02:00
Jordi Boggiano 1b34495daa
Some phpstan level 4 fixes 2021-06-03 11:29:00 +02:00
Jordi Boggiano 4c9e75c6e5
Fix CS 2021-06-03 10:38:38 +02:00
Jordi Boggiano 10e634890e
Good morning 😴 2021-06-03 10:30:09 +02:00
Jordi Boggiano 91dd175f74
Fix env var handling when variables_order includes E and symfony/console 3.3.15+ is used, fixes #9930 2021-06-03 10:17:54 +02:00
Jordi Boggiano 61c7762680
Merge pull request #9932 from jrfnl/php-8.1/9931-fix-deprecation-notice
PHP 8.1 | Fix "Implicit conversion from non-compatible float" deprecation notice
2021-06-03 09:11:02 +02:00
jrfnl 3db2304fc6 PHP 8.1 | Fix "Implicit conversion from non-compatible float" deprecation notice
As reported in 9931.

Unfortunately I gave not been able to track down the input which is causing the notices to be thrown, which is why I haven't added a test case to the unit tests. Would be great if someone would known the exact input to use for those.

The issue (and fix) can be verified by using the "quick preview" option and choosing `git.master` with this code sample: https://3v4l.org/1fr2g
2021-06-03 06:08:51 +02:00
Jordi Boggiano aeb2c8d6e3
Make sure InstalledVersions ships to project with docblocks 2021-06-02 15:21:35 +02:00
Jordi Boggiano 8bf0ddf905
Clean up ZipDownloader, always do async first if possible then fallback to non-async 2021-06-02 15:13:19 +02:00
Jordi Boggiano 28c7d0ea5d
Avoid creating new processes to remove directories which we know are empty, which speeds things up a lot on windows 2021-06-02 13:47:04 +02:00
Jordi Boggiano d864c5743a
Add 7-zip presence check to diagnose command 2021-06-02 13:39:26 +02:00
Nicolas Grekas bec76367db
Speedup extracting on Windows 2021-06-02 11:54:18 +02:00
Nils Adermann 1ca6397442
Merge pull request #9765 from Seldaek/always_sync_symlinked_path_pkgs
Always mark symlinked path packages for update even during partial updates to make sure they always reflect the current state on disk
2021-06-02 11:50:15 +02:00
Nils Adermann 189936dd59
Merge pull request #9928 from Seldaek/replace_conflict
Add better error reporting for cases where a package conflicts with a replace and not directly a package
2021-06-02 11:35:48 +02:00
Jordi Boggiano 1f37d1c1d5
Add better error reporting for cases where a package conflicts with a replace and not directly a package, fixes #9834 2021-06-02 10:08:13 +02:00
Jordi Boggiano 35bfa453cc
Merge pull request #9925 from Seldaek/dist_placeholders
Add support for mirror-style placeholders for the dist url
2021-06-02 10:05:25 +02:00
Jordi Boggiano b751156e1c
Prevent cache gc from happening during test suite runs, and add output so it is clear why it is blocking for a bit 2021-06-02 10:00:01 +02:00
Jordi Boggiano 93a5b27631
Add prettyVersion to URL placeholders 2021-06-01 16:59:35 +02:00
Jordi Boggiano a23f8a3d6c
Add gitlab-protocol to config command and schema 2021-06-01 16:05:53 +02:00
Jordi Boggiano 90d72ca686
Tweak validate command output to be slightly more readable, less colorful 2021-06-01 14:03:19 +02:00
Jordi Boggiano 2eaf81c813
Fix a few issues in lock file validation
- handle packages present but in wrong version
- handle provide/replace correctly
- do not validate if lock file is missing

refs #9899
2021-06-01 14:02:51 +02:00
Jordi Boggiano 69dc607408
Merge remote-tracking branch 'PrinsFrank/detect-missing-packages-on-validate' 2021-05-31 17:29:40 +02:00
Nils Adermann 1dc39bda75
Merge pull request #9915 from Seldaek/reinstall
Add a reinstall command
2021-05-31 17:22:32 +02:00
Jordi Boggiano 4dbdae3ada
Sort uninstalls in reverse order from installs 2021-05-31 17:18:47 +02:00
Jordi Boggiano 5737a34e53
Sort package installs using Transaction 2021-05-31 17:09:19 +02:00
Jordi Boggiano c257395a6d
Add support for mirror-style placeholders for the dist url, fixes #9661 2021-05-31 16:46:49 +02:00
Abi أب 759897e7e8
Update cache dir on macOS to follow OS guidelines (now $HOME/Library/Caches/Composer) (#9898)
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-05-27 23:07:23 +02:00
Brad Jones dd625669e8
Introduce gitlab-protocol option to force the gitlab repos to use https or git protocol (#9401) 2021-05-27 23:05:53 +02:00
Jordi Boggiano c8de960018
Throw when repo consistency is in question 2021-05-26 14:01:04 +02:00
Jordi Boggiano 0dce0f80f1
Also hint for errors when the root package does not match the constraint 2021-05-25 23:05:44 +02:00
Nils Adermann 21c70c2606
Merge pull request #9902 from Seldaek/cyclic-deps
Detect and output a better hint for cyclic dependencies
2021-05-25 22:58:50 +02:00
Jordi Boggiano cbef7b9172
Detect and output a better hint for dependencies on the root package, fixes #9837 2021-05-25 22:47:53 +02:00
Jordi Boggiano 387e504437
Undeprecated dump-autoload --no-dev even though it is mostly not needed anymore, refs #9714 2021-05-25 22:39:55 +02:00
Jordi Boggiano 500efbe233
Add a reinstall command, fixes #3112 2021-05-25 22:30:15 +02:00
Jordi Boggiano 084fff2014
Merge remote-tracking branch 'guilliamxavier/lax-schema' 2021-05-24 22:27:48 +02:00
Jordi Boggiano 6ac5b46607
Add legend for outdated and show --latest commands, fixes #9716 2021-05-24 22:19:07 +02:00
Jordi Boggiano 7888d3fb97
Align result descriptions to make search output more readable, fixes #9455 2021-05-24 21:44:56 +02:00
Jordi Boggiano 44e6591573
Improve error reporting for exts overridden by platform config, fixes #9876 2021-05-24 16:57:33 +02:00
Guilliam Xavier 2d21dd675a Invert strict/lax schema validation 2021-05-24 11:51:04 +02:00
Guilliam Xavier 9e2cb30dfb Revert "Merge remote-tracking branch 'BoShurik/schema'"
This reverts commit 89c3045e2b, reversing
changes made to 991985792d.
2021-05-24 11:46:08 +02:00