42c6a0d7c5
ClassMapGenerator: fix the regex
...
By using a look ahead assertion to match "new line - maybe whitespace - marker", the negative performance impact of the `.*` is significantly mitigated and backtracing will be severely limited.
This fixes the bug as reported in 10037.
The bug was discovered due to a PHP 8.1 "passing null to non-nullable" deprecation notice being thrown, but is not a PHP 8.1 bug.
In actual fact, this issue affected all PHP versions and could lead to incomplete classmaps when the code base contained files with huge heredocs/nowdocs.
The regex change (not completely) incidentally also fixes an issue with markers in a heredoc/nowdoc not being correctly handled. This bug could lead to "classes" being added to the class map which aren't actually classes.
Fixes 10037
2021-08-11 22:26:12 +02:00
c65bd832d6
Url: fix sanitize for new github tokens ( #10048 )
2021-08-11 13:24:41 +02:00
c7d11f361c
PHP 8.1: fix more return type deprecation warnings ( #10039 )
...
Follow up on 10008 and the various commits made for that.
Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:06:47 +02:00
f5a0dfeb50
PHP 8.1: fix deprecation warnings about incorrect default values ( #10036 )
...
* PHP 8.1/Tests: fix some deprecation warnings
The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.
Fixes numerous `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.
Ref: https://www.php.net/manual/en/function.preg-split.php
* PHP 8.1/NoProxyPattern: fix deprecation warning
The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`.
Fixes some `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite.
```
Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest:
preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated
Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42)
1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1)
2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...')
3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData()
4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct()
5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance()
...
```
Ref: https://www.php.net/manual/en/function.preg-split.php
* PHP 8.1: fix deprecation warnings / http_build_query()
This fixes all relevant calls to the PHP native `http_build_query()` function.
The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`.
A parameter being optional, however, does not automatically make it nullable.
As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice.
In this case, these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice.
Changing the `null` to an empty string fixes this without BC-break.
Fixes a few deprecation warnings found when running the tests.
Refs:
* https://www.php.net/manual/en/function.http-build-query.php
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
* PHP 8.1: fix deprecation notices / PharData::__construct()
This fixes all relevant calls to the PHP native `PharData::__construct()` method.
The second parameter of this method is the _optional_ `$flags` parameter which expects an `int` of flags to be passed to the `Phar` parent class `RecursiveDirectoryIterator`.
Fixed by passing the default value for the `$flags` parameter as per the `RecursiveDirectoryIterator::__construct()` method.
The third parameter of the method is the _optional_ `$alias` parameter which expects an `string`.
Fixed by passing an empty string.
Fixes various notices along the lines of:
```
Deprecation triggered by Composer\Test\Package\Archiver\ArchiveManagerTest::testArchiveTar:
PharData::__construct(): Passing null to parameter #2 ($flags) of type int is deprecated
Stack trace:
0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 55)
1 src/Composer/Package/Archiver/PharArchiver.php(55): PharData->__construct('...', NULL, NULL, 2)
2 src/Composer/Package/Archiver/ArchiveManager.php(193): Composer\Package\Archiver\PharArchiver->archive('...', '...', '...', Array, false)
3 tests/Composer/Test/Package/Archiver/ArchiveManagerTest.php(65): Composer\Package\Archiver\ArchiveManager->archive(Object(Composer\Package\CompletePackage), '...', '...')
...
```
Refs:
* https://www.php.net/manual/en/phardata.construct.php
* https://www.php.net/manual/en/recursivedirectoryiterator.construct.php
Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
2021-08-11 13:05:45 +02:00
2665f1b282
Fix private property access, fixes #10022
2021-07-28 14:33:47 +02:00
2fb53232d1
Fix usage on symfony 2.x, fixes #10022
2021-07-28 14:19:19 +02:00
deb4c48bbc
Avoid using an invalid path for InstalledFilesystemRepo in create-project and use an array repo instead, fixes #10020 , fixes #10021
2021-07-23 10:09:31 +02:00
1f4401005c
Allow default_socket_timeout to extend the curl timeout if it is longer than 300s, fixes #10018
2021-07-23 09:51:57 +02:00
e07d2a7bef
Respect parent setting, handling exceptions ( #10017 )
2021-07-22 15:14:15 +02:00
2f83338d2f
Fix hopefully last php 8.1 deprecation warnings
2021-07-22 13:54:18 +02:00
24f5e54fbe
Fix only/exclude to avoid matching names as sub-strings of full package names, fixes #10001
2021-07-22 13:47:31 +02:00
29a52ff463
Register ErrorHandler early to catch deprecation notices while the Application is being initialized
2021-07-22 12:58:14 +02:00
2be03f0d60
More fixes for php8.1 deprecations
2021-07-22 12:42:01 +02:00
a7efb27338
More php8.1 deprecation fixes, refs #10008
2021-07-22 11:48:30 +02:00
47cf602f9e
Fix more PHP 8.1 deprecations, refs #10008
2021-07-22 11:30:01 +02:00
10ae1d7b08
Fix some PHP 8.1 deprecation warnings, fixes #10008
2021-07-21 15:13:24 +02:00
f5a03b950d
Improve error reporting in require command, fixes invalid case of consistency issue, fixes #10006
2021-07-21 14:38:10 +02:00
79093d664b
Update PHPStan and remove ignore
2021-07-21 10:10:09 +02:00
58ced29a2a
Simplify code
2021-07-14 16:36:12 +02:00
be58b36a35
Also look up 7zz on linux/macOS, fixes #9951
2021-07-12 15:50:02 +02:00
b602b19f6d
Fix archive command now that zips are extracted async, refs composer/satis#655
2021-07-12 15:09:59 +02:00
db1d9e75be
Fix support for 7z command fallback on linux/macOS, fixes #9994
2021-07-12 14:49:44 +02:00
bacbd15b6b
Fix open_basedir support regession in bfea0f7d1
2021-07-12 14:34:18 +02:00
5152eeebdc
Merge pull request #9995 from Seldaek/fix_wsl
...
Fix UNC/WSL-path issues when running in Windows
2021-07-12 14:07:41 +02:00
005c55185a
Fix support for writing into UNC paths, and comparing UNC paths correctly in InstalledVersions, fixes #9993
2021-07-12 14:03:00 +02:00
cc81f5bac3
Fix support for UNC paths in normalizePath, refs #9993
2021-07-12 13:36:57 +02:00
c65890d2d3
DiagnoseCommand - fix PHPDoc ( #9991 )
2021-07-07 21:52:53 +02:00
078aaa6968
Make sure the correct name is being output, fixes #9986
2021-06-27 14:45:31 +02:00
a5efbbc94a
Validate schema before writing the file, fixes #9986
2021-06-27 14:45:31 +02:00
420d9bf21d
Move name validation out of interact, fixes #9986
2021-06-27 14:45:30 +02:00
e87a150f41
Make sure schema issues are always reported correctly, but not in init when Composer is not required, fixes #9986
2021-06-27 14:45:30 +02:00
6f992a6ea3
Merge pull request #9975 from mitelg/fix-annotation-complete-package-interface
...
Fix initial values of CompletePackage properties
2021-06-26 23:16:58 +02:00
5780caf208
Fix link when no composer.json is present, fixes #9966
2021-06-26 23:09:27 +02:00
66fb240e1b
Fix initial values of CompletePackage properties
2021-06-17 08:46:40 +02:00
9a32bf9709
Bump source version to 2.1.999
2021-06-09 16:44:06 +02:00
bf3713072c
Fix source binaries not being made executable when symlinks cannot be used, fixes #9961
2021-06-09 16:25:16 +02:00
2d54a27ebc
Fix config support for new bin-compat value, refs #9959
2021-06-09 16:25:16 +02:00
65259ac8e0
Add Composer version in about command
2021-06-09 15:13:01 +02:00
a9031e40eb
Add "symlink" option for "bin-compat" config ( #9959 )
2021-06-09 11:33:44 +02:00
6c1f0cdf24
Handle edge cases too in removeDirectoryPhp to avoid trying to delete symlinks and such, fixes #9955
2021-06-08 21:53:20 +02:00
f61f2c6872
Also free $file just in case
2021-06-08 21:26:41 +02:00
a02802b109
Warn 1.x users when a package is not found that it may be due to our deprecation policy
2021-06-08 21:12:49 +02:00
c668c24599
Fix autoload events not being dispatched when running dump-autoload command, fixes #9954
2021-06-08 15:34:26 +02:00
b01cd459b7
Avoid checking if dir is empty if it does not even exist
2021-06-07 16:41:11 +02:00
6e851edd70
Add `--dev` to `dump-autoload` command to allow force-dumping dev autoload rules even if dev requirements are not present, fixes #9946
2021-06-07 15:48:37 +02:00
e013b479da
Avoid failing hard if the target empty dir cannot be deleted when extracting archives, fixes #9947
2021-06-07 15:34:03 +02:00
c4f675fe84
Fix virtualbox filesystem issue when installing packages, fixes #9945
2021-06-06 21:11:48 +02:00
4e4b4f69c9
Revert "Always wait after an unzip completes to try and fix virtualbox issues, refs #9945"
...
This reverts commit 3556f6efa5
2021-06-06 21:10:07 +02:00
dd17f5f615
Add missing use
2021-06-05 20:47:56 +02:00
3556f6efa5
Always wait after an unzip completes to try and fix virtualbox issues, refs #9945
2021-06-05 20:45:37 +02:00
c1f0eee154
Revert "Attempt fixing virtualbox issues, refs #9945"
...
This reverts commit 7a7e0cc031
2021-06-05 20:42:31 +02:00
e087a4ab5e
Fix usage of InstalledVersions when loaded from composer/composer installed as a dependency and runtime Composer is v1, fixes #9937
2021-06-05 17:11:23 +02:00
7a7e0cc031
Attempt fixing virtualbox issues, refs #9945
2021-06-05 16:40:18 +02:00
b45c8dea0a
Cleanups
2021-06-05 16:21:46 +02:00
cbb1504910
Also do the change in ReinstallCommand
2021-06-05 16:21:46 +02:00
eac069bf36
Fix --no-scripts disabling events for plugins
2021-06-05 16:09:04 +02:00
288e19153d
Alternative fix for #9941 to avoid code duplication
2021-06-05 16:04:24 +02:00
cbd1e3c2af
Fix undefined index access when using "@php <absolute path>" in script handler, fixes #9943
2021-06-05 12:51:23 +02:00
d45e3a98e4
Merge pull request #9938 from adlacruzes/fix_custom_json_schema
...
Fix JsonFile when using custom json schema with no "name" and "descri…
2021-06-04 08:10:46 +02:00
1bfec451e2
Make sure the LAX_SCHEMA handling disables required/additionalProperties as it used to do but strict schema requires properties only for the composer schema
2021-06-04 08:05:42 +02:00
5a28f677da
Fix outdated legend and only show legend when there is output to be shown, fixes #9939
2021-06-04 07:55:40 +02:00
d77ff0f729
Workaround for PCRE regression
2021-06-04 07:17:57 +02:00
7366b8e362
Fix JsonFile when using custom json schema with no "name" and "description" properties
2021-06-03 20:15:35 +02:00
d5ce7a7385
Fix autoload generation for dev dependencies when --no-scripts is used, fixes #9934
2021-06-03 17:03:42 +02:00
1b34495daa
Some phpstan level 4 fixes
2021-06-03 11:29:00 +02:00
4c9e75c6e5
Fix CS
2021-06-03 10:38:38 +02:00
10e634890e
Good morning 😴
2021-06-03 10:30:09 +02:00
91dd175f74
Fix env var handling when variables_order includes E and symfony/console 3.3.15+ is used, fixes #9930
2021-06-03 10:17:54 +02:00
61c7762680
Merge pull request #9932 from jrfnl/php-8.1/9931-fix-deprecation-notice
...
PHP 8.1 | Fix "Implicit conversion from non-compatible float" deprecation notice
2021-06-03 09:11:02 +02:00
3db2304fc6
PHP 8.1 | Fix "Implicit conversion from non-compatible float" deprecation notice
...
As reported in 9931.
Unfortunately I gave not been able to track down the input which is causing the notices to be thrown, which is why I haven't added a test case to the unit tests. Would be great if someone would known the exact input to use for those.
The issue (and fix) can be verified by using the "quick preview" option and choosing `git.master` with this code sample: https://3v4l.org/1fr2g
2021-06-03 06:08:51 +02:00
aeb2c8d6e3
Make sure InstalledVersions ships to project with docblocks
2021-06-02 15:21:35 +02:00
8bf0ddf905
Clean up ZipDownloader, always do async first if possible then fallback to non-async
2021-06-02 15:13:19 +02:00
28c7d0ea5d
Avoid creating new processes to remove directories which we know are empty, which speeds things up a lot on windows
2021-06-02 13:47:04 +02:00
d864c5743a
Add 7-zip presence check to diagnose command
2021-06-02 13:39:26 +02:00
bec76367db
Speedup extracting on Windows
2021-06-02 11:54:18 +02:00
1ca6397442
Merge pull request #9765 from Seldaek/always_sync_symlinked_path_pkgs
...
Always mark symlinked path packages for update even during partial updates to make sure they always reflect the current state on disk
2021-06-02 11:50:15 +02:00
189936dd59
Merge pull request #9928 from Seldaek/replace_conflict
...
Add better error reporting for cases where a package conflicts with a replace and not directly a package
2021-06-02 11:35:48 +02:00
1f37d1c1d5
Add better error reporting for cases where a package conflicts with a replace and not directly a package, fixes #9834
2021-06-02 10:08:13 +02:00
35bfa453cc
Merge pull request #9925 from Seldaek/dist_placeholders
...
Add support for mirror-style placeholders for the dist url
2021-06-02 10:05:25 +02:00
b751156e1c
Prevent cache gc from happening during test suite runs, and add output so it is clear why it is blocking for a bit
2021-06-02 10:00:01 +02:00
93a5b27631
Add prettyVersion to URL placeholders
2021-06-01 16:59:35 +02:00
a23f8a3d6c
Add gitlab-protocol to config command and schema
2021-06-01 16:05:53 +02:00
90d72ca686
Tweak validate command output to be slightly more readable, less colorful
2021-06-01 14:03:19 +02:00
2eaf81c813
Fix a few issues in lock file validation
...
- handle packages present but in wrong version
- handle provide/replace correctly
- do not validate if lock file is missing
refs #9899
2021-06-01 14:02:51 +02:00
69dc607408
Merge remote-tracking branch 'PrinsFrank/detect-missing-packages-on-validate'
2021-05-31 17:29:40 +02:00
1dc39bda75
Merge pull request #9915 from Seldaek/reinstall
...
Add a reinstall command
2021-05-31 17:22:32 +02:00
4dbdae3ada
Sort uninstalls in reverse order from installs
2021-05-31 17:18:47 +02:00
5737a34e53
Sort package installs using Transaction
2021-05-31 17:09:19 +02:00
c257395a6d
Add support for mirror-style placeholders for the dist url, fixes #9661
2021-05-31 16:46:49 +02:00
759897e7e8
Update cache dir on macOS to follow OS guidelines (now $HOME/Library/Caches/Composer) ( #9898 )
...
Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
2021-05-27 23:07:23 +02:00
dd625669e8
Introduce gitlab-protocol option to force the gitlab repos to use https or git protocol ( #9401 )
2021-05-27 23:05:53 +02:00
c8de960018
Throw when repo consistency is in question
2021-05-26 14:01:04 +02:00
0dce0f80f1
Also hint for errors when the root package does not match the constraint
2021-05-25 23:05:44 +02:00
21c70c2606
Merge pull request #9902 from Seldaek/cyclic-deps
...
Detect and output a better hint for cyclic dependencies
2021-05-25 22:58:50 +02:00
cbef7b9172
Detect and output a better hint for dependencies on the root package, fixes #9837
2021-05-25 22:47:53 +02:00
387e504437
Undeprecated dump-autoload --no-dev even though it is mostly not needed anymore, refs #9714
2021-05-25 22:39:55 +02:00
500efbe233
Add a reinstall command, fixes #3112
2021-05-25 22:30:15 +02:00
084fff2014
Merge remote-tracking branch 'guilliamxavier/lax-schema'
2021-05-24 22:27:48 +02:00
6ac5b46607
Add legend for outdated and show --latest commands, fixes #9716
2021-05-24 22:19:07 +02:00
7888d3fb97
Align result descriptions to make search output more readable, fixes #9455
2021-05-24 21:44:56 +02:00
44e6591573
Improve error reporting for exts overridden by platform config, fixes #9876
2021-05-24 16:57:33 +02:00
2d21dd675a
Invert strict/lax schema validation
2021-05-24 11:51:04 +02:00
9e2cb30dfb
Revert "Merge remote-tracking branch 'BoShurik/schema'"
...
This reverts commit 89c3045e2b991985792d
2021-05-24 11:46:08 +02:00
41c66b1a2d
Revert "Update docs and add more helpful output to validate command, refs #9782"
...
This reverts commit 458bd41d8f
2021-05-24 11:46:08 +02:00
da3d5e3143
Merge pull request #9699 from ochorocho/improve-installed-versions-9648
...
Add install-path and type to installedVersions.php and installed.php,…
2021-05-24 10:29:40 +02:00
6f255d1230
Merge branch '2.0'
2021-05-21 17:03:16 +02:00
8874ca0e5a
Fix regression introduced in dd54f295fe
2021-05-21 16:58:34 +02:00
ce19bcd992
Upgrade to xdebug-handler 2 ( #9832 )
...
This adds support for Xdebug3 modes and changes the default behaviour
from always restarting if Xdebug is loaded, to only restarting if Xdebug
is active.
Xdebug is considered active if it is loaded, and for Xdebug3, if it is
running in a mode other than `xdebug.mode=off`.
2021-05-21 16:47:29 +02:00
23d1de5d59
Merge branch '2.0'
2021-05-21 16:44:33 +02:00
fee22972ea
Update basic docs on install/update, fixes #9754
2021-05-21 16:44:05 +02:00
6441e1f94f
Merge branch '2.0'
2021-05-21 15:01:18 +02:00
7d19930ca6
Fix minimum-stability validation to match what VersionParser::normalizeStability does, closes #9904
2021-05-21 15:00:48 +02:00
019d051e9e
Fix type
2021-05-21 14:50:30 +02:00
284ec95712
Document new methods and update the composer-runtime-api version to 2.1
2021-05-21 14:34:51 +02:00
82cffa17d3
Undo addition of initializeInstalled and remove inline copy of the data from the class
2021-05-21 14:34:51 +02:00
3fe4f84a76
Fix handling of metapackages with null paths, and handling of paths which do not have a shortest-path and require an absolute path to be addressed
2021-05-21 14:33:10 +02:00
518b44a810
Clean up dump code to avoid reimplementing var export, and remove DIRECTORY_SEPARATOR
2021-05-21 14:33:10 +02:00
5a69a1e483
Add InstalledVersions::getInstallPath($package) getter, and update phpdoc types
2021-05-21 14:33:10 +02:00
8335b49cf0
Rename dev-requirement to dev_requirement for consistency
2021-05-21 14:33:09 +02:00
b6c9d34125
Add install-path and type to installedVersions.php and installed.php, add method to get installed packages by type
...
Issue https://github.com/composer/composer/issues/9648
2021-05-21 14:33:09 +02:00
31cc102850
Merge branch '2.0'
2021-05-21 14:32:06 +02:00
e83e92b2ae
Ignore platform requirements like "ext-*" and "php" when validating the lock file as they don't get locked
2021-05-20 21:14:30 +02:00
32b70142d9
Replace static anonymous function and replace it with normal anonymous function as static ones are only supported on PHP5.4 and up
2021-05-20 20:55:00 +02:00
f4d3a1e478
Detect missing packages that are a requirement or dev-requirement but not locked.
2021-05-20 20:44:53 +02:00
16279d328e
Merge pull request #9816 from Seldaek/install_deprecate
...
Deprecate InstalledVersions::getRawData in favor of getAllRawData
2021-05-20 16:54:33 +02:00
8a3f4a8400
Add secure-svn-domains config option to mark secure svn:// hostnames, fixes #9872
2021-05-20 16:27:58 +02:00
458bd41d8f
Update docs and add more helpful output to validate command, refs #9782
2021-05-20 16:11:51 +02:00
89c3045e2b
Merge remote-tracking branch 'BoShurik/schema'
2021-05-20 15:42:39 +02:00
991985792d
Merge branch '2.0'
2021-05-20 14:16:52 +02:00
251b852fd2
Make sure async processes fail the promise if they fail to start, fixes #9808
2021-05-20 14:15:14 +02:00
8427b6c8ed
Also make sure filesystem is up to date before generating binary links, refs #9627
2021-05-20 13:27:20 +02:00
9ba042ded8
Add Platform-PHP version to user-agent header to improve targetted-php stats ( #9873 )
2021-05-20 10:17:30 +02:00
5bf614a762
Merge branch '2.0'
2021-05-17 22:35:56 +02:00
dd54f295fe
Fix progress output, and remove progress bar on CI env, fixes #9621 , closes #9880
2021-05-17 22:34:32 +02:00
459a7d9623
Use a simpler suggested require version of * to keep things simple for extensions which are versioned like PHP, fixes #9483
2021-05-17 14:36:46 +02:00
0021758e0b
Merge branch '2.0'
2021-05-10 13:14:14 +02:00
d56387edb7
Also handle throwable on supported php versions
2021-05-10 13:14:08 +02:00
649087d6de
Fix type issues with root package interface
2021-05-04 16:47:54 +02:00
22cc96682d
Merge branch '2.0'
2021-05-04 16:43:31 +02:00
b268e20d9f
Fix invalid interface usage
2021-05-04 16:43:24 +02:00
7b77161b7e
Merge branch '2.0'
2021-05-04 16:29:32 +02:00
37f4f531d0
Avoid leaving the event stack in a dirty state if an event listener throws, fixes #9846
2021-05-04 16:18:38 +02:00
a844fce23e
Fix handling of inline-update-constraints with refs or stability flags, fixes #9847
2021-05-04 14:14:57 +02:00
a04202aa7d
Merge pull request #9864 from Seldaek/dev-versions-dx
...
Hint at a branch rename if we detect dev-master can not be found and condense dev-* versions in problem output
2021-05-04 13:38:33 +02:00
3380178798
Introduce a cross-platform safe version of is_readable to support UNC / wsl$ paths on Windows ( #9861 )
2021-05-04 13:25:52 +02:00
298246dccb
Also condense dev-* versions if there are many, refs #9850
2021-05-03 14:42:59 +02:00
9b7a8d4543
Hint at a branch rename if we detect dev-master can not be found but dev-main or dev-default exists, fixes #9850
2021-05-03 14:42:58 +02:00
bfea0f7d1e
BinaryInstaller: install full binaries on WSL when bin-compat=auto ( #9855 )
2021-05-02 16:50:42 +02:00
4842f213a1
Also make sure type is correct for preg_match
2021-04-30 10:07:28 +02:00
832f4007d6
Allow ints in source/dist reference
2021-04-30 09:40:58 +02:00
jrfnl